[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-20 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r219104953 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -1861,6 +1862,76 @@ public void

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-20 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r219104769 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -1861,6 +1862,76 @@ public void

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-19 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r218880876 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -1861,6 +1862,76 @@ public void

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-17 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r218055822 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -1861,6 +1862,76 @@ public void

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217773472 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -60,14 +60,17 @@ MainThread[] mt =

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217770370 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -1861,6 +1862,76 @@ public void

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217769719 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -1057,22 +1065,49 @@ void killSession(long session, long zxid) {

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217739881 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -1057,22 +1065,49 @@ void killSession(long session, long zxid) { //

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217743312 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -60,14 +60,17 @@ MainThread[] mt = null;

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217741801 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerMainTest.java --- @@ -1861,6 +1862,76 @@ public void

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217689682 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -60,14 +60,17 @@ MainThread[] mt =

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217689355 --- Diff: src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java --- @@ -116,6 +120,10 @@ public static Record deserializeTxn(byte

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-14 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217689225 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -1057,22 +1065,49 @@ void killSession(long session, long zxid) {

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r21785 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -60,14 +60,17 @@ MainThread[] mt =

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217555258 --- Diff: src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java --- @@ -116,6 +120,10 @@ public static Record deserializeTxn(byte

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread lvfangmin
Github user lvfangmin commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217554958 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -1057,22 +1065,49 @@ void killSession(long session, long zxid) {

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217546649 --- Diff: src/java/test/org/apache/zookeeper/server/quorum/FuzzySnapshotRelatedTest.java --- @@ -60,14 +60,17 @@ MainThread[] mt =

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217545459 --- Diff: src/java/main/org/apache/zookeeper/server/DataTree.java --- @@ -1057,22 +1065,49 @@ void killSession(long session, long zxid) {

[GitHub] zookeeper pull request #622: [ZOOKEEPER-3145] Fix potential watch missing is...

2018-09-13 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/622#discussion_r217546112 --- Diff: src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java --- @@ -116,6 +120,10 @@ public static Record deserializeTxn(byte