[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/678 ---

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230468188 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230467749 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230465652 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230455088 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230454818 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230423126 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -254,23 +282,54 @@ public static X509KeyManager

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230421926 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,27 +229,47 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230421726 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230419175 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230418985 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/JKSFileLoader.java --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230418497 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-01 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230255350 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -254,23 +282,54 @@ public static X509KeyManager

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-01 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230255232 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,27 +229,47 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-01 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230252932 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-01 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230251259 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/JKSFileLoader.java --- @@ -0,0 +1,67 @@ +/** + * Licensed to the Apache

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-11-01 Thread tumativ
Github user tumativ commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r230250524 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/FileKeyStoreLoader.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-31 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r229938699 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java --- @@ -0,0 +1,224 @@ +/* + * Licensed under the Apache License,

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-30 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r229524910 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java --- @@ -0,0 +1,224 @@ +/* + * Licensed under the Apache

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-30 Thread hanm
Github user hanm commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r229523540 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java --- @@ -0,0 +1,224 @@ +/* + * Licensed under the Apache License,

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-30 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r229202470 --- Diff: NOTICE.txt --- @@ -3,3 +3,9 @@ Copyright 2009-2014 The Apache Software Foundation This product includes software developed at

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r229102998 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -167,47 +222,50 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r229021572 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java --- @@ -0,0 +1,224 @@ +/* + * Licensed under the Apache

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r229013179 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java --- @@ -0,0 +1,224 @@ +/* + * Licensed under the Apache

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r229012448 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -360,4 +476,26 @@ private void

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r229012101 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -167,47 +222,50 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r229011934 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -79,12 +82,56 @@

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r229011448 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -167,47 +222,50 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228957739 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -167,47 +222,50 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228963670 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java --- @@ -0,0 +1,224 @@ +/* + * Licensed under the Apache

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228958388 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -79,12 +82,56 @@

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228958680 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -167,47 +222,50 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-29 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228961395 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -360,4 +476,26 @@ private void

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-28 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228806955 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228805464 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-28 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228764349 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228763521 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-28 Thread ivmaykov
Github user ivmaykov commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228762467 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228760044 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-28 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228738342 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,15 +279,45 @@ public SSLContext

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-28 Thread anmolnar
Github user anmolnar commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228737596 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java --- @@ -221,15 +279,45 @@ public SSLContext createSSLContext(ZKConfig

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-25 Thread eolivelli
Github user eolivelli commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/678#discussion_r228406071 --- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/util/PemReader.java --- @@ -0,0 +1,224 @@ +/* + * Licensed under the Apache

[GitHub] zookeeper pull request #678: ZOOKEEPER-3173: Quorum TLS - support PEM trust/...

2018-10-24 Thread ivmaykov
GitHub user ivmaykov opened a pull request: https://github.com/apache/zookeeper/pull/678 ZOOKEEPER-3173: Quorum TLS - support PEM trust/key stores Add support for loading key and trust stores from PEM files. Unfortunately, this PR includes 2 JIRAs, because it was quite