Justin,
I created this JIRA
thanks
https://issues.apache.org/jira/browse/ZOOKEEPER-4315
we should fix this before any other new release
Enrico
Il giorno ven 11 giu 2021 alle ore 06:25 Ted Dunning
ha scritto:
>
> Justin,
>
> Thanks for the feedback!
>
>
>
> On Thu, Jun 10, 2021 at 8:23 PM
Justin,
Thanks for the feedback!
On Thu, Jun 10, 2021 at 8:23 PM Justin Mclean wrote:
> HI,
>
> I'm not on your PMC but I took a look at your source release and I think
> there a few things that need to be added to the LICENSE file as per the
> guidelines here [1]
>
> These BSD licensed
HI,
I'm not on your PMC but I took a look at your source release and I think there
a few things that need to be added to the LICENSE file as per the guidelines
here [1]
These BSD licensed files:
./zookeeper-client/zookeeper-client-c/src/hashtable/hashtable.c
I'm happy to announce that we have unanimously approved this release.
There are 7 approving votes, 3 of which are binding:
- Damien Diederen
- Norbert Kalmar
- Szalay-Bekő Máté
- Enrico Olivelli (binding)
- Patrick Hunt (binding)
- Flavio Junqueira (binding)
- Mohammad Arshad
There are no
+1
- Built from sources locally (there are a few flaky tests, though)
- Verified digest and signature
- Ran rat for license issues
- Checked NOTICE and LICENSE files
- Resolved zk dependency from staging repo
- Ran a few smoke tests locally using the cli tool
-Flavio
> On 12 Apr 2021, at 18:15,
+1 xsum/sig validate. rat ran clean. I ran dependency check and
launched/tested a few different cluster sizes manually and they all ran
fine.
Patrick
On Thu, Apr 8, 2021 at 10:19 AM Mohammad Arshad wrote:
> This is a bug fix release candidate for 3.6.3. It fixes 52 issues,
> including multiple
+1 (binding)
Run tests on JDK8 + Ubuntu
Run C tests on Ubuntu
Verified RAT
Verified "lib" directory (still we do not have LICENSE file for every .jar ?)
Run smoke tests using the binary tarball on JDK11 on Mac
Thank you Arshad
Enrico
Il giorno lun 12 apr 2021 alle ore 15:44 Szalay-Bekő Máté
+1 (non-binding)
Thank you Arshad, nice job!
My checks:
- I built the java source code and run all the unit tests on MacOS (using
OpenJDK 8u212 and maven 3.6.3)
- checkstyle and spotbugs passed
- apache-rat passed
- owasp (CVE check) passed
- fatjar built
- I built the the C and zkPython code
+1 (non-binding)
Checked on macOS: licenses, build and test passed, ran ZK and few standard
commands, signature.
Also built and run unit tests on ubuntu.
Thanks Arshad!
- Norbert
On Sat, Apr 10, 2021 at 10:34 AM Damien Diederen
wrote:
>
> Hi Arshad, all,
>
> LGTM! +1 (advisory):
>
> *
Hi Arshad, all,
LGTM! +1 (advisory):
* Tarball contents match repository tag;
* Verified checksums and signatures;
* Built and smoke-tested on NixOS with a slightly adapted version of
the Nix recipe and test case;
* Smoke-tested a standalone server with the (corresponding)
This is a bug fix release candidate for 3.6.3. It fixes 52 issues,
including multiple CVE fixes.
The full release notes is available at:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12348703
Please download, test and vote by Sunday, April 11th 2021, 23:59
UTC+0.
11 matches
Mail list logo
