Re: [VOTE] Apache ZooKeeper release 3.6.4 candidate 0

2022-12-15 Thread Szalay-Bekő Máté
> I have confirmed that I can build the current branch-3.6 on my machine,
using GCC 12.2.0.

Thank you for testing it!!


> Does the build/test pipeline need to be updated to verify this? Why make
it a manual/release step.

> Perhaps part of the reason we're seeing this now is lack of CI on
branch-3.6.

Yes, the CI is simpler on branch-3.6. We have some CI, a PR jenkins job is
is building java and C code and runs all the tests (
https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-precommit-github-pr/detail/PR-1965/1/pipeline)
but we definitely miss the new github CI checks on this old branch. On the
other hand, even on newer branches we don't have any explicit checks to
build and test the C code with a matrix of GCC versions and libraries. We
could do something similar to how we test the Java code with multiple JDK
versions. (or at least add a few docker files that one can use locally to
have test environments with more important gcc/library version combinations)

Anyway, I knew about this problem based on other failures on newer
branches. I guess I should have waited for the fix to be merged before
cutting the release.

I am cancelling this VOTE for 3.6.4 RC 0 now.

I will send RC 1 soon.

Thank you for your time and feedback!
Máté

On Fri, Dec 16, 2022 at 1:45 AM Chris Nauroth  wrote:

> I have confirmed that I can build the current branch-3.6 on my machine,
> using GCC 12.2.0. I agree with your point that the GCC version might not be
> root cause, and it's also possible that it's caused by a difference in
> OpenSSL headers. My OpenSSL version is 3.0.7.
>
> Perhaps part of the reason we're seeing this now is lack of CI on
> branch-3.6. If we had CI on that branch, then we would have seen failures
> in recent branch-3.6 pull requests, like this one:
>
> https://github.com/apache/zookeeper/pull/1965
>
> Chris Nauroth
>
>
> On Thu, Dec 15, 2022 at 3:39 PM Patrick Hunt  wrote:
>
> > Does the build/test pipeline need to be updated to verify this? Why make
> it
> > a manual/release step.
> >
> > Patrick
> >
> > On Thu, Dec 15, 2022 at 3:35 PM Szalay-Bekő Máté <
> > szalay.beko.m...@gmail.com>
> > wrote:
> >
> > > Thanks for checking!
> > >
> > > I don't have a strong opinion. It would make sense to support newer gcc
> > > versions in a new release. On the other hand, it is not a regression on
> > the
> > > branch-3.6 (the c-client in this rc compiles with the same gcc versions
> > > which were compatible with 3.6 3).
> > >
> > > But I am OK to make a new RC. I don't have new gcc installed though to
> > test
> > > it locally. Also, I wonder if installing a new gcc is enough, or the
> > > openssl or other library versions also matter?
> > >
> > > Could you maybe check if the current branch-3.6 compiles on your
> machine,
> > > with gcc 12.2.0? As you mentioned, the fix for ZOOKEEPER-4641 is
> already
> > > present there (I merged it after RC 0). If it works for you, then I can
> > add
> > > this commit and cut RC 1.
> > >
> > > Unless someone disagree...
> > >
> > > Thanks,
> > > Máté
> > >
> > >
> > > On Thu, Dec 15, 2022, 6:45 PM Chris Nauroth 
> wrote:
> > >
> > > > Unfortunately, I can't compile the C client because of the FIPS_mode
> > bug
> > > > (ZOOKEEPER-4641). I'm on a newer version of GCC: 12.2.0. I see that
> > > > ZOOKEEPER-4641 was committed to branch-3.6 with a fix version of
> 3.6.5.
> > > > However, we're intending that 3.6.4 is the final 3.6 release, so
> there
> > > > never will be a 3.6.5.
> > > >
> > > > Sorry for the churn, but I'd prefer if we could bring that fix into a
> > new
> > > > release candidate. Let me know your thoughts on it.
> > > >
> > > > Chris Nauroth
> > > >
> > > >
> > > > On Wed, Dec 14, 2022 at 4:08 PM Szalay-Bekő Máté <
> > > > szalay.beko.m...@gmail.com>
> > > > wrote:
> > > >
> > > > > +1 (binding)
> > > > >
> > > > > I did the following tests for the release candidate:
> > > > > - verified checksum and gpg signature of the artifacts
> > > > > - I built the source code (incl. the C-client, using -Pfull-build)
> on
> > > > > Ubuntu 20.04.5 using OpenJDK 8u352, maven 3.6.3 and GCC version
> 9.4.0
> > > > > - all the unit tests passed (both Java and C-client)
> > > > > - I also built and executed unit tests for zkpython
> > > > > - I also built the java code (without -Pfull-build) using other JDK
> > > > > versions: 11.0.15, 17.0.3, 18.0.1, 19.0.1 (but didn't run the tests
> > > this
> > > > > time, just used 'clean install -DskipTests')
> > > > > - checkstyle and spotbugs passed
> > > > > - apache-rat passed
> > > > > - owasp (CVE check) passed
> > > > > - fatjar built
> > > > > - I executed quick rolling-upgrade tests (using
> > > > > https://github.com/symat/zk-rolling-upgrade-test):
> > > > >   - rolling upgrade from 3.5.10 to 3.6.4
> > > > >   - rolling upgrade from 3.6.3 to 3.6.4
> > > > >   - rolling upgrade from 3.6.4 to 3.7.1
> > > > >   - rolling upgrade from 3.6.4 to 3.8.0
> > > > > - checked the generated documentation 

Re: [VOTE] Apache ZooKeeper release 3.6.4 candidate 0

2022-12-15 Thread Chris Nauroth
I have confirmed that I can build the current branch-3.6 on my machine,
using GCC 12.2.0. I agree with your point that the GCC version might not be
root cause, and it's also possible that it's caused by a difference in
OpenSSL headers. My OpenSSL version is 3.0.7.

Perhaps part of the reason we're seeing this now is lack of CI on
branch-3.6. If we had CI on that branch, then we would have seen failures
in recent branch-3.6 pull requests, like this one:

https://github.com/apache/zookeeper/pull/1965

Chris Nauroth


On Thu, Dec 15, 2022 at 3:39 PM Patrick Hunt  wrote:

> Does the build/test pipeline need to be updated to verify this? Why make it
> a manual/release step.
>
> Patrick
>
> On Thu, Dec 15, 2022 at 3:35 PM Szalay-Bekő Máté <
> szalay.beko.m...@gmail.com>
> wrote:
>
> > Thanks for checking!
> >
> > I don't have a strong opinion. It would make sense to support newer gcc
> > versions in a new release. On the other hand, it is not a regression on
> the
> > branch-3.6 (the c-client in this rc compiles with the same gcc versions
> > which were compatible with 3.6 3).
> >
> > But I am OK to make a new RC. I don't have new gcc installed though to
> test
> > it locally. Also, I wonder if installing a new gcc is enough, or the
> > openssl or other library versions also matter?
> >
> > Could you maybe check if the current branch-3.6 compiles on your machine,
> > with gcc 12.2.0? As you mentioned, the fix for ZOOKEEPER-4641 is already
> > present there (I merged it after RC 0). If it works for you, then I can
> add
> > this commit and cut RC 1.
> >
> > Unless someone disagree...
> >
> > Thanks,
> > Máté
> >
> >
> > On Thu, Dec 15, 2022, 6:45 PM Chris Nauroth  wrote:
> >
> > > Unfortunately, I can't compile the C client because of the FIPS_mode
> bug
> > > (ZOOKEEPER-4641). I'm on a newer version of GCC: 12.2.0. I see that
> > > ZOOKEEPER-4641 was committed to branch-3.6 with a fix version of 3.6.5.
> > > However, we're intending that 3.6.4 is the final 3.6 release, so there
> > > never will be a 3.6.5.
> > >
> > > Sorry for the churn, but I'd prefer if we could bring that fix into a
> new
> > > release candidate. Let me know your thoughts on it.
> > >
> > > Chris Nauroth
> > >
> > >
> > > On Wed, Dec 14, 2022 at 4:08 PM Szalay-Bekő Máté <
> > > szalay.beko.m...@gmail.com>
> > > wrote:
> > >
> > > > +1 (binding)
> > > >
> > > > I did the following tests for the release candidate:
> > > > - verified checksum and gpg signature of the artifacts
> > > > - I built the source code (incl. the C-client, using -Pfull-build) on
> > > > Ubuntu 20.04.5 using OpenJDK 8u352, maven 3.6.3 and GCC version 9.4.0
> > > > - all the unit tests passed (both Java and C-client)
> > > > - I also built and executed unit tests for zkpython
> > > > - I also built the java code (without -Pfull-build) using other JDK
> > > > versions: 11.0.15, 17.0.3, 18.0.1, 19.0.1 (but didn't run the tests
> > this
> > > > time, just used 'clean install -DskipTests')
> > > > - checkstyle and spotbugs passed
> > > > - apache-rat passed
> > > > - owasp (CVE check) passed
> > > > - fatjar built
> > > > - I executed quick rolling-upgrade tests (using
> > > > https://github.com/symat/zk-rolling-upgrade-test):
> > > >   - rolling upgrade from 3.5.10 to 3.6.4
> > > >   - rolling upgrade from 3.6.3 to 3.6.4
> > > >   - rolling upgrade from 3.6.4 to 3.7.1
> > > >   - rolling upgrade from 3.6.4 to 3.8.0
> > > > - checked the generated documentation (zookeeper-docs/target/html)
> > > > - compared generated release notes (releasenotes.html) with Jira (
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12350076
> > > > )
> > > >
> > > > Best regards,
> > > > Máté
> > > >
> > > > On Thu, Dec 15, 2022 at 1:05 AM Szalay-Bekő Máté <
> > > > szalay.beko.m...@gmail.com>
> > > > wrote:
> > > >
> > > > > This is a bugfix release candidate for 3.6.4. It fixes 40 issues,
> > > > > including CVE fixes,
> > > > > log4j1 removal (using reload4j from now) and various other bug
> fixes
> > > > > (thread leaks, data
> > > > > corruption, snapshotting and SASL related fixes).
> > > > >
> > > > > Please note, that based on our Release Strategy (
> > > > > https://zookeeper.apache.org/releases.html#release-strategy)
> branch
> > > 3.6
> > > > > should become end-of-life and most likely 3.6.4 will be our last
> 3.6
> > > > > release.
> > > > >
> > > > > The full release notes is available at:
> > > > >
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12350076
> > > > >
> > > > > *** Please download, test and vote by December 23th 2022, 23:59
> > UTC+0.
> > > > ***
> > > > >
> > > > >
> > > > > Source files:
> > > > > https://people.apache.org/~symat/zookeeper-3.6.4-rc0/
> > > > >
> > > > > Maven staging repo:
> > > > >
> > > > >
> > > >
> > >
> >
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.6.4/
> > > > >
> > > > > The release candidate 

Re: [VOTE] Apache ZooKeeper release 3.6.4 candidate 0

2022-12-15 Thread Patrick Hunt
Does the build/test pipeline need to be updated to verify this? Why make it
a manual/release step.

Patrick

On Thu, Dec 15, 2022 at 3:35 PM Szalay-Bekő Máté 
wrote:

> Thanks for checking!
>
> I don't have a strong opinion. It would make sense to support newer gcc
> versions in a new release. On the other hand, it is not a regression on the
> branch-3.6 (the c-client in this rc compiles with the same gcc versions
> which were compatible with 3.6 3).
>
> But I am OK to make a new RC. I don't have new gcc installed though to test
> it locally. Also, I wonder if installing a new gcc is enough, or the
> openssl or other library versions also matter?
>
> Could you maybe check if the current branch-3.6 compiles on your machine,
> with gcc 12.2.0? As you mentioned, the fix for ZOOKEEPER-4641 is already
> present there (I merged it after RC 0). If it works for you, then I can add
> this commit and cut RC 1.
>
> Unless someone disagree...
>
> Thanks,
> Máté
>
>
> On Thu, Dec 15, 2022, 6:45 PM Chris Nauroth  wrote:
>
> > Unfortunately, I can't compile the C client because of the FIPS_mode bug
> > (ZOOKEEPER-4641). I'm on a newer version of GCC: 12.2.0. I see that
> > ZOOKEEPER-4641 was committed to branch-3.6 with a fix version of 3.6.5.
> > However, we're intending that 3.6.4 is the final 3.6 release, so there
> > never will be a 3.6.5.
> >
> > Sorry for the churn, but I'd prefer if we could bring that fix into a new
> > release candidate. Let me know your thoughts on it.
> >
> > Chris Nauroth
> >
> >
> > On Wed, Dec 14, 2022 at 4:08 PM Szalay-Bekő Máté <
> > szalay.beko.m...@gmail.com>
> > wrote:
> >
> > > +1 (binding)
> > >
> > > I did the following tests for the release candidate:
> > > - verified checksum and gpg signature of the artifacts
> > > - I built the source code (incl. the C-client, using -Pfull-build) on
> > > Ubuntu 20.04.5 using OpenJDK 8u352, maven 3.6.3 and GCC version 9.4.0
> > > - all the unit tests passed (both Java and C-client)
> > > - I also built and executed unit tests for zkpython
> > > - I also built the java code (without -Pfull-build) using other JDK
> > > versions: 11.0.15, 17.0.3, 18.0.1, 19.0.1 (but didn't run the tests
> this
> > > time, just used 'clean install -DskipTests')
> > > - checkstyle and spotbugs passed
> > > - apache-rat passed
> > > - owasp (CVE check) passed
> > > - fatjar built
> > > - I executed quick rolling-upgrade tests (using
> > > https://github.com/symat/zk-rolling-upgrade-test):
> > >   - rolling upgrade from 3.5.10 to 3.6.4
> > >   - rolling upgrade from 3.6.3 to 3.6.4
> > >   - rolling upgrade from 3.6.4 to 3.7.1
> > >   - rolling upgrade from 3.6.4 to 3.8.0
> > > - checked the generated documentation (zookeeper-docs/target/html)
> > > - compared generated release notes (releasenotes.html) with Jira (
> > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12350076
> > > )
> > >
> > > Best regards,
> > > Máté
> > >
> > > On Thu, Dec 15, 2022 at 1:05 AM Szalay-Bekő Máté <
> > > szalay.beko.m...@gmail.com>
> > > wrote:
> > >
> > > > This is a bugfix release candidate for 3.6.4. It fixes 40 issues,
> > > > including CVE fixes,
> > > > log4j1 removal (using reload4j from now) and various other bug fixes
> > > > (thread leaks, data
> > > > corruption, snapshotting and SASL related fixes).
> > > >
> > > > Please note, that based on our Release Strategy (
> > > > https://zookeeper.apache.org/releases.html#release-strategy) branch
> > 3.6
> > > > should become end-of-life and most likely 3.6.4 will be our last 3.6
> > > > release.
> > > >
> > > > The full release notes is available at:
> > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12350076
> > > >
> > > > *** Please download, test and vote by December 23th 2022, 23:59
> UTC+0.
> > > ***
> > > >
> > > >
> > > > Source files:
> > > > https://people.apache.org/~symat/zookeeper-3.6.4-rc0/
> > > >
> > > > Maven staging repo:
> > > >
> > > >
> > >
> >
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.6.4/
> > > >
> > > > The release candidate tag in git to be voted upon: release-3.6.4-0
> > > > (please note, branch-3.6.4 will move here only after the vote)
> > > >
> > > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > > > https://www.apache.org/dist/zookeeper/KEYS
> > > >
> > > > The staging version of the website is:
> > > > https://people.apache.org/~symat/zookeeper-3.6.4-rc0/webpage/
> > > >
> > > >
> > > > Should we release this candidate?
> > > >
> > > >
> > > > Best regards,
> > > > Máté
> > > >
> > >
> >
>


Re: [VOTE] Apache ZooKeeper release 3.6.4 candidate 0

2022-12-15 Thread Szalay-Bekő Máté
Thanks for checking!

I don't have a strong opinion. It would make sense to support newer gcc
versions in a new release. On the other hand, it is not a regression on the
branch-3.6 (the c-client in this rc compiles with the same gcc versions
which were compatible with 3.6 3).

But I am OK to make a new RC. I don't have new gcc installed though to test
it locally. Also, I wonder if installing a new gcc is enough, or the
openssl or other library versions also matter?

Could you maybe check if the current branch-3.6 compiles on your machine,
with gcc 12.2.0? As you mentioned, the fix for ZOOKEEPER-4641 is already
present there (I merged it after RC 0). If it works for you, then I can add
this commit and cut RC 1.

Unless someone disagree...

Thanks,
Máté


On Thu, Dec 15, 2022, 6:45 PM Chris Nauroth  wrote:

> Unfortunately, I can't compile the C client because of the FIPS_mode bug
> (ZOOKEEPER-4641). I'm on a newer version of GCC: 12.2.0. I see that
> ZOOKEEPER-4641 was committed to branch-3.6 with a fix version of 3.6.5.
> However, we're intending that 3.6.4 is the final 3.6 release, so there
> never will be a 3.6.5.
>
> Sorry for the churn, but I'd prefer if we could bring that fix into a new
> release candidate. Let me know your thoughts on it.
>
> Chris Nauroth
>
>
> On Wed, Dec 14, 2022 at 4:08 PM Szalay-Bekő Máté <
> szalay.beko.m...@gmail.com>
> wrote:
>
> > +1 (binding)
> >
> > I did the following tests for the release candidate:
> > - verified checksum and gpg signature of the artifacts
> > - I built the source code (incl. the C-client, using -Pfull-build) on
> > Ubuntu 20.04.5 using OpenJDK 8u352, maven 3.6.3 and GCC version 9.4.0
> > - all the unit tests passed (both Java and C-client)
> > - I also built and executed unit tests for zkpython
> > - I also built the java code (without -Pfull-build) using other JDK
> > versions: 11.0.15, 17.0.3, 18.0.1, 19.0.1 (but didn't run the tests this
> > time, just used 'clean install -DskipTests')
> > - checkstyle and spotbugs passed
> > - apache-rat passed
> > - owasp (CVE check) passed
> > - fatjar built
> > - I executed quick rolling-upgrade tests (using
> > https://github.com/symat/zk-rolling-upgrade-test):
> >   - rolling upgrade from 3.5.10 to 3.6.4
> >   - rolling upgrade from 3.6.3 to 3.6.4
> >   - rolling upgrade from 3.6.4 to 3.7.1
> >   - rolling upgrade from 3.6.4 to 3.8.0
> > - checked the generated documentation (zookeeper-docs/target/html)
> > - compared generated release notes (releasenotes.html) with Jira (
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12350076
> > )
> >
> > Best regards,
> > Máté
> >
> > On Thu, Dec 15, 2022 at 1:05 AM Szalay-Bekő Máté <
> > szalay.beko.m...@gmail.com>
> > wrote:
> >
> > > This is a bugfix release candidate for 3.6.4. It fixes 40 issues,
> > > including CVE fixes,
> > > log4j1 removal (using reload4j from now) and various other bug fixes
> > > (thread leaks, data
> > > corruption, snapshotting and SASL related fixes).
> > >
> > > Please note, that based on our Release Strategy (
> > > https://zookeeper.apache.org/releases.html#release-strategy) branch
> 3.6
> > > should become end-of-life and most likely 3.6.4 will be our last 3.6
> > > release.
> > >
> > > The full release notes is available at:
> > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12350076
> > >
> > > *** Please download, test and vote by December 23th 2022, 23:59 UTC+0.
> > ***
> > >
> > >
> > > Source files:
> > > https://people.apache.org/~symat/zookeeper-3.6.4-rc0/
> > >
> > > Maven staging repo:
> > >
> > >
> >
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.6.4/
> > >
> > > The release candidate tag in git to be voted upon: release-3.6.4-0
> > > (please note, branch-3.6.4 will move here only after the vote)
> > >
> > > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > > https://www.apache.org/dist/zookeeper/KEYS
> > >
> > > The staging version of the website is:
> > > https://people.apache.org/~symat/zookeeper-3.6.4-rc0/webpage/
> > >
> > >
> > > Should we release this candidate?
> > >
> > >
> > > Best regards,
> > > Máté
> > >
> >
>


Re: [VOTE] Apache ZooKeeper release 3.6.4 candidate 0

2022-12-15 Thread Chris Nauroth
Unfortunately, I can't compile the C client because of the FIPS_mode bug
(ZOOKEEPER-4641). I'm on a newer version of GCC: 12.2.0. I see that
ZOOKEEPER-4641 was committed to branch-3.6 with a fix version of 3.6.5.
However, we're intending that 3.6.4 is the final 3.6 release, so there
never will be a 3.6.5.

Sorry for the churn, but I'd prefer if we could bring that fix into a new
release candidate. Let me know your thoughts on it.

Chris Nauroth


On Wed, Dec 14, 2022 at 4:08 PM Szalay-Bekő Máté 
wrote:

> +1 (binding)
>
> I did the following tests for the release candidate:
> - verified checksum and gpg signature of the artifacts
> - I built the source code (incl. the C-client, using -Pfull-build) on
> Ubuntu 20.04.5 using OpenJDK 8u352, maven 3.6.3 and GCC version 9.4.0
> - all the unit tests passed (both Java and C-client)
> - I also built and executed unit tests for zkpython
> - I also built the java code (without -Pfull-build) using other JDK
> versions: 11.0.15, 17.0.3, 18.0.1, 19.0.1 (but didn't run the tests this
> time, just used 'clean install -DskipTests')
> - checkstyle and spotbugs passed
> - apache-rat passed
> - owasp (CVE check) passed
> - fatjar built
> - I executed quick rolling-upgrade tests (using
> https://github.com/symat/zk-rolling-upgrade-test):
>   - rolling upgrade from 3.5.10 to 3.6.4
>   - rolling upgrade from 3.6.3 to 3.6.4
>   - rolling upgrade from 3.6.4 to 3.7.1
>   - rolling upgrade from 3.6.4 to 3.8.0
> - checked the generated documentation (zookeeper-docs/target/html)
> - compared generated release notes (releasenotes.html) with Jira (
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12350076
> )
>
> Best regards,
> Máté
>
> On Thu, Dec 15, 2022 at 1:05 AM Szalay-Bekő Máté <
> szalay.beko.m...@gmail.com>
> wrote:
>
> > This is a bugfix release candidate for 3.6.4. It fixes 40 issues,
> > including CVE fixes,
> > log4j1 removal (using reload4j from now) and various other bug fixes
> > (thread leaks, data
> > corruption, snapshotting and SASL related fixes).
> >
> > Please note, that based on our Release Strategy (
> > https://zookeeper.apache.org/releases.html#release-strategy) branch 3.6
> > should become end-of-life and most likely 3.6.4 will be our last 3.6
> > release.
> >
> > The full release notes is available at:
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12350076
> >
> > *** Please download, test and vote by December 23th 2022, 23:59 UTC+0.
> ***
> >
> >
> > Source files:
> > https://people.apache.org/~symat/zookeeper-3.6.4-rc0/
> >
> > Maven staging repo:
> >
> >
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.6.4/
> >
> > The release candidate tag in git to be voted upon: release-3.6.4-0
> > (please note, branch-3.6.4 will move here only after the vote)
> >
> > ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> > https://www.apache.org/dist/zookeeper/KEYS
> >
> > The staging version of the website is:
> > https://people.apache.org/~symat/zookeeper-3.6.4-rc0/webpage/
> >
> >
> > Should we release this candidate?
> >
> >
> > Best regards,
> > Máté
> >
>


Re: [VOTE] Apache ZooKeeper release 3.6.4 candidate 0

2022-12-14 Thread Szalay-Bekő Máté
+1 (binding)

I did the following tests for the release candidate:
- verified checksum and gpg signature of the artifacts
- I built the source code (incl. the C-client, using -Pfull-build) on
Ubuntu 20.04.5 using OpenJDK 8u352, maven 3.6.3 and GCC version 9.4.0
- all the unit tests passed (both Java and C-client)
- I also built and executed unit tests for zkpython
- I also built the java code (without -Pfull-build) using other JDK
versions: 11.0.15, 17.0.3, 18.0.1, 19.0.1 (but didn't run the tests this
time, just used 'clean install -DskipTests')
- checkstyle and spotbugs passed
- apache-rat passed
- owasp (CVE check) passed
- fatjar built
- I executed quick rolling-upgrade tests (using
https://github.com/symat/zk-rolling-upgrade-test):
  - rolling upgrade from 3.5.10 to 3.6.4
  - rolling upgrade from 3.6.3 to 3.6.4
  - rolling upgrade from 3.6.4 to 3.7.1
  - rolling upgrade from 3.6.4 to 3.8.0
- checked the generated documentation (zookeeper-docs/target/html)
- compared generated release notes (releasenotes.html) with Jira (
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12350076
)

Best regards,
Máté

On Thu, Dec 15, 2022 at 1:05 AM Szalay-Bekő Máté 
wrote:

> This is a bugfix release candidate for 3.6.4. It fixes 40 issues,
> including CVE fixes,
> log4j1 removal (using reload4j from now) and various other bug fixes
> (thread leaks, data
> corruption, snapshotting and SASL related fixes).
>
> Please note, that based on our Release Strategy (
> https://zookeeper.apache.org/releases.html#release-strategy) branch 3.6
> should become end-of-life and most likely 3.6.4 will be our last 3.6
> release.
>
> The full release notes is available at:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12350076
>
> *** Please download, test and vote by December 23th 2022, 23:59 UTC+0. ***
>
>
> Source files:
> https://people.apache.org/~symat/zookeeper-3.6.4-rc0/
>
> Maven staging repo:
>
> https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.6.4/
>
> The release candidate tag in git to be voted upon: release-3.6.4-0
> (please note, branch-3.6.4 will move here only after the vote)
>
> ZooKeeper's KEYS file containing PGP keys we use to sign the release:
> https://www.apache.org/dist/zookeeper/KEYS
>
> The staging version of the website is:
> https://people.apache.org/~symat/zookeeper-3.6.4-rc0/webpage/
>
>
> Should we release this candidate?
>
>
> Best regards,
> Máté
>


[VOTE] Apache ZooKeeper release 3.6.4 candidate 0

2022-12-14 Thread Szalay-Bekő Máté
This is a bugfix release candidate for 3.6.4. It fixes 40 issues, including
CVE fixes,
log4j1 removal (using reload4j from now) and various other bug fixes
(thread leaks, data
corruption, snapshotting and SASL related fixes).

Please note, that based on our Release Strategy (
https://zookeeper.apache.org/releases.html#release-strategy) branch 3.6
should become end-of-life and most likely 3.6.4 will be our last 3.6
release.

The full release notes is available at:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310801=12350076

*** Please download, test and vote by December 23th 2022, 23:59 UTC+0. ***


Source files:
https://people.apache.org/~symat/zookeeper-3.6.4-rc0/

Maven staging repo:
https://repository.apache.org/content/groups/staging/org/apache/zookeeper/zookeeper/3.6.4/

The release candidate tag in git to be voted upon: release-3.6.4-0
(please note, branch-3.6.4 will move here only after the vote)

ZooKeeper's KEYS file containing PGP keys we use to sign the release:
https://www.apache.org/dist/zookeeper/KEYS

The staging version of the website is:
https://people.apache.org/~symat/zookeeper-3.6.4-rc0/webpage/


Should we release this candidate?


Best regards,
Máté