[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804071#comment-13804071 ] Hudson commented on ZOOKEEPER-1499: --- SUCCESS: Integrated in ZooKeeper-trunk #2099 (See [https://builds.apache.org/job/ZooKeeper-trunk/2099/]) ZOOKEEPER-1499. clientPort config changes not backwards-compatible (Alexander Shraer via phunt, breed) (phunt: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1535280) * /zookeeper/trunk/CHANGES.txt * /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java * /zookeeper/trunk/src/java/test/org/apache/zookeeper/test/ReconfigTest.java clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Alexander Shraer Priority: Blocker Fix For: 3.5.0 Attachments: ZOOKEEPER-1499.patch, ZOOKEEPER-1499-ver1.java, ZOOKEEPER-1499-ver2.java, ZOOKEEPER-1499-ver3.patch With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13793517#comment-13793517 ] Benjamin Reed commented on ZOOKEEPER-1499: -- +1 looks good alex! clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Alexander Shraer Priority: Blocker Fix For: 3.5.0 Attachments: ZOOKEEPER-1499.patch, ZOOKEEPER-1499-ver1.java, ZOOKEEPER-1499-ver2.java, ZOOKEEPER-1499-ver3.patch With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13791230#comment-13791230 ] Hadoop QA commented on ZOOKEEPER-1499: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12607742/ZOOKEEPER-1499-ver3.patch against trunk revision 1530809. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1672//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1672//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1672//console This message is automatically generated. clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Alexander Shraer Priority: Blocker Fix For: 3.5.0 Attachments: ZOOKEEPER-1499.patch, ZOOKEEPER-1499-ver1.java, ZOOKEEPER-1499-ver2.java, ZOOKEEPER-1499-ver3.patch With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13791270#comment-13791270 ] Hadoop QA commented on ZOOKEEPER-1499: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12607752/ZOOKEEPER-1499-ver3.patch against trunk revision 1530809. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1673//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1673//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1673//console This message is automatically generated. clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Alexander Shraer Priority: Blocker Fix For: 3.5.0 Attachments: ZOOKEEPER-1499.patch, ZOOKEEPER-1499-ver1.java, ZOOKEEPER-1499-ver2.java, ZOOKEEPER-1499-ver3.patch With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790922#comment-13790922 ] Alexander Shraer commented on ZOOKEEPER-1499: - thanks Ben. I made a slight change to the patch. clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Alexander Shraer Priority: Blocker Fix For: 3.5.0 Attachments: ZOOKEEPER-1499.patch, ZOOKEEPER-1499-ver1.java With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13790955#comment-13790955 ] Hadoop QA commented on ZOOKEEPER-1499: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12607672/ZOOKEEPER-1499-ver1.java against trunk revision 1530809. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1670//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1670//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1670//console This message is automatically generated. clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Alexander Shraer Priority: Blocker Fix For: 3.5.0 Attachments: ZOOKEEPER-1499.patch, ZOOKEEPER-1499-ver1.java With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13791049#comment-13791049 ] Hadoop QA commented on ZOOKEEPER-1499: -- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12607695/ZOOKEEPER-1499-ver2.java against trunk revision 1530809. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1671//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1671//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1671//console This message is automatically generated. clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Alexander Shraer Priority: Blocker Fix For: 3.5.0 Attachments: ZOOKEEPER-1499.patch, ZOOKEEPER-1499-ver1.java, ZOOKEEPER-1499-ver2.java With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789811#comment-13789811 ] Patrick Hunt commented on ZOOKEEPER-1499: - [~fournc], [~breed] [~shralex] is this still an issue? clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Benjamin Reed Priority: Blocker With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789852#comment-13789852 ] Alexander Shraer commented on ZOOKEEPER-1499: - I tried this: clientPort is being read, but if you specified both clientPort and the port in the new format (after ;) they must be the same. Same for clientPortAddress. But seems like Camille is right in her comment that if you specified the clientPort with the new format you won't be able to connect to it using localhost. I'm not sure if this is a problem but I'm guessing that it may be because previously if you just specified clientPort, the IP was taken as localhost implicitly. Whereas now if you say a:b:c;d, a is taken as the ip for d. To achieve the same as before you can write a:b:c;localhost:d. While trying this I found a corner case missing in zkServer.sh -- if the specification uses the new format but still appears in the static configuration file (backward compatibility), zkServer.sh won't find the port (for example if you say ./bin/zkServer.sh status it will complain). Attached is a small patch for this. clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Benjamin Reed Priority: Blocker With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789869#comment-13789869 ] Alexander Shraer commented on ZOOKEEPER-1499: - I opened a separate Jira for the zkServer.sh change. I suggest to close this one, since I verified that clientPort keyword is working. clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Alexander Shraer Priority: Blocker Fix For: 3.5.0 With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789886#comment-13789886 ] Hadoop QA commented on ZOOKEEPER-1499: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12607472/zkServersh.patch against trunk revision 1530166. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1661//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1661//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1661//console This message is automatically generated. clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Alexander Shraer Priority: Blocker Fix For: 3.5.0 With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789896#comment-13789896 ] Camille Fournier commented on ZOOKEEPER-1499: - I'm not sure I can remember anything about 2012 at this point. Seems strange that this is something fixed by a change to a shell script though, is that the way the config is always parsed now? clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Alexander Shraer Priority: Blocker Fix For: 3.5.0 With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13789913#comment-13789913 ] Alexander Shraer commented on ZOOKEEPER-1499: - Hi Camille, There are two issues pointed out in this JIRA. 1) (in the description) clientPort no longer gets read and 2) (in your first comment) and a client can't use localhost:... I tried but can't reproduce issue 1, seems like clientPort is being read. Thats why I suggested to close the JIRA. For issue 2, I think you're right, and I think this follows from how the ip address is inferred if you don't explicitly specify it. Previously it was assumed to be 'localhost' whereas now its assumed to be the ip from the server spec line. I'm not sure if this is a problem. I moved the patch to zkServer.sh to a separate JIRA - ZOOKEEPER-1785 since it solves a different problem clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Alexander Shraer Priority: Blocker Fix For: 3.5.0 With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (ZOOKEEPER-1499) clientPort config changes not backwards-compatible
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13406137#comment-13406137 ] Camille Fournier commented on ZOOKEEPER-1499: - Also this change causes you to be unable to connect to the localhost if you do a config like server.1=111.222.333.44:2888:3888;2181 you can only connect to 111.222.333.44 instead of 127.0.0.1 or whatever. clientPort config changes not backwards-compatible -- Key: ZOOKEEPER-1499 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1499 Project: ZooKeeper Issue Type: Bug Components: server Affects Versions: 3.5.0 Reporter: Camille Fournier Assignee: Benjamin Reed Priority: Blocker With the new reconfig logic, clientPort=2181 in the zoo.cfg file no longer gets read, and clients can't connect without adding ;2181 to the end of their server lines. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
