[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15475074#comment-15475074
]
Hudson commented on ZOOKEEPER-1962:
---
FAILURE: Integrated in Jenkins build ZooKeeper-trunk #3070 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15474603#comment-15474603
]
Enis Soztutar commented on ZOOKEEPER-1962:
--
Thanks [~phunt] for the changes. +1, let's get
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472582#comment-15472582
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472479#comment-15472479
]
Hadoop QA commented on ZOOKEEPER-1962:
--
+1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472455#comment-15472455
]
Patrick Hunt commented on ZOOKEEPER-1962:
-
Hm. Playing around I noticed another issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472242#comment-15472242
]
Patrick Hunt commented on ZOOKEEPER-1962:
-
I noticed another issue - the default behavior
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472234#comment-15472234
]
Patrick Hunt commented on ZOOKEEPER-1962:
-
bq. Could add one or two more test cases (i.e. list
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472228#comment-15472228
]
Patrick Hunt commented on ZOOKEEPER-1962:
-
Hm, doesn't work for me:
{noformat}
[zk:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15459281#comment-15459281
]
Michael Han commented on ZOOKEEPER-1962:
Thanks for the patch, [~enis]! Patch looks good to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15456924#comment-15456924
]
Enis Soztutar commented on ZOOKEEPER-1962:
--
Any interest in reviews?
> Add a CLI command to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446855#comment-15446855
]
Hadoop QA commented on ZOOKEEPER-1962:
--
+1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15446770#comment-15446770
]
Enis Soztutar commented on ZOOKEEPER-1962:
--
bq. However, listSubTreeBFS would buffer entire
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440398#comment-15440398
]
Patrick Hunt commented on ZOOKEEPER-1962:
-
bq. fail intelligently
+1 on that
bq. add a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15440041#comment-15440041
]
Michael Han commented on ZOOKEEPER-1962:
+1 on the idea of reusing existing code.
However,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15439531#comment-15439531
]
Abraham Fine commented on ZOOKEEPER-1962:
-
I agree with [~phunt] that reusing the logic from
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15438285#comment-15438285
]
Patrick Hunt commented on ZOOKEEPER-1962:
-
Not to derail things, but did the "deleteall" (used
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15432088#comment-15432088
]
Hadoop QA commented on ZOOKEEPER-1962:
--
+1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342915#comment-15342915
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15094419#comment-15094419
]
Chris Nauroth commented on ZOOKEEPER-1962:
--
+1 for Enis's proposal. That logic agrees with
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087223#comment-15087223
]
Enis Soztutar commented on ZOOKEEPER-1962:
--
We can still do depth-first search, but sort the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15080855#comment-15080855
]
Enis Soztutar commented on ZOOKEEPER-1962:
--
I think the {{jute.maxBuffer}} is not relevant
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15081985#comment-15081985
]
Chris Nauroth commented on ZOOKEEPER-1962:
--
bq. One minor improvement might be that instead
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15082007#comment-15082007
]
Gautam Gopalakrishnan commented on ZOOKEEPER-1962:
--
Thanks [~cnauroth] and [~enis], I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071867#comment-15071867
]
Hadoop QA commented on ZOOKEEPER-1962:
--
+1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071863#comment-15071863
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15071862#comment-15071862
]
Gautam Gopalakrishnan commented on ZOOKEEPER-1962:
--
I made a mistake in my earlier
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050167#comment-15050167
]
Raul Gutierrez Segales commented on ZOOKEEPER-1962:
---
[~busbey], [~ggop]: sorry for
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15050146#comment-15050146
]
Gautam Gopalakrishnan commented on ZOOKEEPER-1962:
--
I'll submit a patch in the next
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876657#comment-14876657
]
Edward Ribeiro commented on ZOOKEEPER-1962:
---
This issue is really cool! A few code review
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742632#comment-14742632
]
Roman Shaposhnik commented on ZOOKEEPER-1962:
-
+1 (non-binding) from me as well. I find
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692974#comment-14692974
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14692993#comment-14692993
]
Gautam Gopalakrishnan commented on ZOOKEEPER-1962:
--
The failed tests
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14693737#comment-14693737
]
Sean Busbey commented on ZOOKEEPER-1962:
+1 (non-binding). All the java tests
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14682067#comment-14682067
]
Sean Busbey commented on ZOOKEEPER-1962:
patch still applies to trunk and
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14682160#comment-14682160
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491251#comment-14491251
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124686#comment-14124686
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124724#comment-14124724
]
Gautam Gopalakrishnan commented on ZOOKEEPER-1962:
--
Thank you
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14118087#comment-14118087
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112541#comment-14112541
]
Patrick Hunt commented on ZOOKEEPER-1962:
-
Can we remove the dependency on
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098595#comment-14098595
]
Hongchao Deng commented on ZOOKEEPER-1962:
--
Hi [~ggop].
Sorry to get you
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14098125#comment-14098125
]
Gautam Gopalakrishnan commented on ZOOKEEPER-1962:
--
Any feedback on
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086469#comment-14086469
]
Hongchao Deng commented on ZOOKEEPER-1962:
--
+1 for the patch. Would be a nice
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078313#comment-14078313
]
Hongchao Deng commented on ZOOKEEPER-1962:
--
[~ggop]
Concise and neat!
It
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14078833#comment-14078833
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077353#comment-14077353
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065359#comment-14065359
]
Hongchao Deng commented on ZOOKEEPER-1962:
--
hi [~ggop],
Great idea and nice
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065364#comment-14065364
]
Hongchao Deng commented on ZOOKEEPER-1962:
--
[~ggop] Let me separate
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065450#comment-14065450
]
Hongchao Deng commented on ZOOKEEPER-1962:
--
A few programming improvement
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061720#comment-14061720
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061797#comment-14061797
]
Hadoop QA commented on ZOOKEEPER-1962:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14061711#comment-14061711
]
Gautam Gopalakrishnan commented on ZOOKEEPER-1962:
--
Sample run with
52 matches
Mail list logo
