[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14186700#comment-14186700
]
Hudson commented on ZOOKEEPER-2052:
---
FAILURE: Integrated in ZooKeeper-trunk #2484
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14186351#comment-14186351
]
Rakesh R commented on ZOOKEEPER-2052:
-
Thank you [~hdeng] and [~yipng].
Committed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14184004#comment-14184004
]
Rakesh R commented on ZOOKEEPER-2052:
-
I think [~fpj] has already given +1. Please
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176045#comment-14176045
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
[~fpj][~rakeshr]
The two patches
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14176076#comment-14176076
]
Rakesh R commented on ZOOKEEPER-2052:
-
+1, the latest patch looks good to me.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14173911#comment-14173911
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
My local jenkins job showed the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172057#comment-14172057
]
Rakesh R commented on ZOOKEEPER-2052:
-
[~hdeng] Thanks for the patch. Test cases
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172551#comment-14172551
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
[~rakeshr]
Thanks for the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172677#comment-14172677
]
Hadoop QA commented on ZOOKEEPER-2052:
--
+1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172715#comment-14172715
]
Hadoop QA commented on ZOOKEEPER-2052:
--
+1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171618#comment-14171618
]
Flavio Junqueira commented on ZOOKEEPER-2052:
-
Sure, got it. Initially I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171636#comment-14171636
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
This patch is tested on trunk. I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171988#comment-14171988
]
Marshall McMullen commented on ZOOKEEPER-2052:
--
I'm going to go look over
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14171996#comment-14171996
]
Marshall McMullen commented on ZOOKEEPER-2052:
--
I reviewed the RB and the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170164#comment-14170164
]
Flavio Junqueira commented on ZOOKEEPER-2052:
-
Here is my initial reaction
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170185#comment-14170185
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
Hi [~fpj]. Thanks for looking at
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170245#comment-14170245
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
[~fpj]
bq. I was wondering why a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14170332#comment-14170332
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
bq. I'm wondering though if we
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166509#comment-14166509
]
Marshall McMullen commented on ZOOKEEPER-2052:
--
I'm just seeing this jira
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165303#comment-14165303
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
[~rakeshr] [~fpj] [~marshall]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166065#comment-14166065
]
Flavio Junqueira commented on ZOOKEEPER-2052:
-
I haven't been following
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166076#comment-14166076
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
[~fpj]
Great!
Just a brief sum-up
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163139#comment-14163139
]
Hadoop QA commented on ZOOKEEPER-2052:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164016#comment-14164016
]
Hadoop QA commented on ZOOKEEPER-2052:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164080#comment-14164080
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
[~fpj] [~rakeshr] [~rgs]
This
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164134#comment-14164134
]
Hadoop QA commented on ZOOKEEPER-2052:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164168#comment-14164168
]
Raul Gutierrez Segales commented on ZOOKEEPER-2052:
---
[~hdeng]:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164196#comment-14164196
]
Hadoop QA commented on ZOOKEEPER-2052:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164451#comment-14164451
]
Hadoop QA commented on ZOOKEEPER-2052:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162039#comment-14162039
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
I think the root cause is for
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162066#comment-14162066
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
I also believe that in
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162073#comment-14162073
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
Hi [~marshall].
Please see my
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162344#comment-14162344
]
Yip Ng commented on ZOOKEEPER-2052:
---
Hongchao Deng wrote:
I think the root cause is
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162392#comment-14162392
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
[~yipng]
I agree that your patch
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162462#comment-14162462
]
Yip Ng commented on ZOOKEEPER-2052:
---
Hongchao
I agree, perhaps getPendingChanges()
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14162877#comment-14162877
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
[~rakeshr]
Good catch!
I think
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163013#comment-14163013
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
[~yipng]
I am almost done with my
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163029#comment-14163029
]
Yip Ng commented on ZOOKEEPER-2052:
---
Hongchao:
Sure, no problem.
Unable to delete
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163065#comment-14163065
]
Yip Ng commented on ZOOKEEPER-2052:
---
Just took a brief look at the latest patch. In
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163070#comment-14163070
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
That's right.
I should add a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163091#comment-14163091
]
Yip Ng commented on ZOOKEEPER-2052:
---
Hongchao:
You meant you will place back the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163094#comment-14163094
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
Yes. I also added a note on the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14163111#comment-14163111
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
Created a RB:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14160057#comment-14160057
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
[~yipng]
Thanks for the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14160158#comment-14160158
]
Yip Ng commented on ZOOKEEPER-2052:
---
Hongchao:
Thanks for taking a look at the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14160289#comment-14160289
]
Rakesh R commented on ZOOKEEPER-2052:
-
[~yipng] Good catch and thanks for unit
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14160821#comment-14160821
]
Hadoop QA commented on ZOOKEEPER-2052:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14160955#comment-14160955
]
Yip Ng commented on ZOOKEEPER-2052:
---
Thanks Rakesh, it took some time for us to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161406#comment-14161406
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
Thanks for [~yipng] and
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161408#comment-14161408
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
So in the fix I mean also
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161471#comment-14161471
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
I have another question: what's
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14161505#comment-14161505
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
Hi [~thawan].
ZOOKEEPER-1624
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159582#comment-14159582
]
Hadoop QA commented on ZOOKEEPER-2052:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159614#comment-14159614
]
Yip Ng commented on ZOOKEEPER-2052:
---
The patch was generated on v3.4.6. Will
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159647#comment-14159647
]
Hongchao Deng commented on ZOOKEEPER-2052:
--
Hi [~yipng].
This sounds a known
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14160006#comment-14160006
]
Yip Ng commented on ZOOKEEPER-2052:
---
Hi Hongchao:
As illustrated in the junit
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14160013#comment-14160013
]
Hadoop QA commented on ZOOKEEPER-2052:
--
-1 overall. Here are the results of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14159279#comment-14159279
]
Yip Ng commented on ZOOKEEPER-2052:
---
Appreciate if someone can review and comment on
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158745#comment-14158745
]
Yip Ng commented on ZOOKEEPER-2052:
---
Got abit curious, so went through the code in
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156163#comment-14156163
]
Yip Ng commented on ZOOKEEPER-2052:
---
This issue looks very similar to
60 matches
Mail list logo