[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833877#comment-15833877
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user rakeshadr commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833876#comment-15833876
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user rakeshadr closed the pull request
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833796#comment-15833796
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user hanm commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795648#comment-15795648
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user hanm commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795616#comment-15795616
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user rakeshadr commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795574#comment-15795574
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user hanm commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15773279#comment-15773279
]
Rakesh R commented on ZOOKEEPER-2383:
-
[PR_135|https://github.com/apache/zookeeper/pull/135] is
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15773276#comment-15773276
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
GitHub user rakeshadr opened a pull request:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15770897#comment-15770897
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~hanm] for merging this to {{branch-3.5}}
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768992#comment-15768992
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thank you [~fpj] for the help in resolving this.
bq. pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768490#comment-15768490
]
Hudson commented on ZOOKEEPER-2383:
---
SUCCESS: Integrated in Jenkins build ZooKeeper-trunk #3204 (See
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15768361#comment-15768361
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754824#comment-15754824
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user rakeshadr commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754797#comment-15754797
]
Hadoop QA commented on ZOOKEEPER-2383:
--
+1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754181#comment-15754181
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user fpj commented on the issue:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754062#comment-15754062
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754060#comment-15754060
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15754024#comment-15754024
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user rakeshadr commented on a diff in
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15752671#comment-15752671
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
Github user fpj commented on a diff in the pull
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15724255#comment-15724255
]
Rakesh R commented on ZOOKEEPER-2383:
-
Hi [~fpj], would be great to see your feedback on the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15643583#comment-15643583
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. GitHub Pull Request Build
+1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642088#comment-15642088
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642086#comment-15642086
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15642047#comment-15642047
]
ASF GitHub Bot commented on ZOOKEEPER-2383:
---
GitHub user rakeshadr opened a pull request:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636680#comment-15636680
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~fpj]. OK, I'll modify the test case and create
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636584#comment-15636584
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
Moving the {{start()}} call to the end of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15636358#comment-15636358
]
Rakesh R commented on ZOOKEEPER-2383:
-
Will this proposed fix induce any other component
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528370#comment-15528370
]
Rakesh R commented on ZOOKEEPER-2383:
-
[~fpj], any thoughts about the above points? Thanks!
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507169#comment-15507169
]
Rakesh R commented on ZOOKEEPER-2383:
-
bq. The test case isn't covering the whole modified code.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502833#comment-15502833
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
Actually, what prevents us from doing this:
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15502828#comment-15502828
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
[~rakesh_r] the try/finally suggestion
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499350#comment-15499350
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~fpj] for the comments.
bq. In NettyServerCnxn,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15499075#comment-15499075
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
[~rakesh_r] I have checked the 3.4 patch.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15470882#comment-15470882
]
Rakesh R commented on ZOOKEEPER-2383:
-
I've got +1(non-binding) from [~steve_rowe] and [~hanm].
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15422902#comment-15422902
]
Rakesh R commented on ZOOKEEPER-2383:
-
I am moving this out to 3.4.10 for now. Please feel free to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420205#comment-15420205
]
Patrick Hunt commented on ZOOKEEPER-2383:
-
[~rgs] possible for you take another look?
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410820#comment-15410820
]
Rakesh R commented on ZOOKEEPER-2383:
-
[~rgs], would you take another look at the latest patch and
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410424#comment-15410424
]
Hadoop QA commented on ZOOKEEPER-2383:
--
+1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409917#comment-15409917
]
Michael Han commented on ZOOKEEPER-2383:
Thanks Rakesh for quick reply - looks good to me.
>
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409886#comment-15409886
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409673#comment-15409673
]
Michael Han commented on ZOOKEEPER-2383:
One small suggestion - the condition of {code}
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409640#comment-15409640
]
Michael Han commented on ZOOKEEPER-2383:
ZOOKEEPER-2383-br-3-4.patch may also be updated with
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409316#comment-15409316
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408930#comment-15408930
]
Hadoop QA commented on ZOOKEEPER-2383:
--
+1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408906#comment-15408906
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~rgs]. Attached new patch addressing the comments.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408826#comment-15408826
]
Raul Gutierrez Segales commented on ZOOKEEPER-2383:
---
[~rakeshr]: looks good to me,
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408810#comment-15408810
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks a lot [~steve_rowe] for the feedback.
[~fpj],
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15408727#comment-15408727
]
Steve Rowe commented on ZOOKEEPER-2383:
---
[~rakeshr], I patched branch-3.4 at revision 1754563
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399789#comment-15399789
]
Hadoop QA commented on ZOOKEEPER-2383:
--
-1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399783#comment-15399783
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~steve_rowe]. I'm attaching another patch based on
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399680#comment-15399680
]
Steve Rowe commented on ZOOKEEPER-2383:
---
[~rakeshr], looks like your patch is against trunk - if
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399613#comment-15399613
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thank you [~suda] for the feedback.
> Startup race in
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399042#comment-15399042
]
Akihiro Suda commented on ZOOKEEPER-2383:
-
+1 (non-binding).
Locally tested
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15396992#comment-15396992
]
Hadoop QA commented on ZOOKEEPER-2383:
--
+1 overall. Here are the results of testing the latest
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392021#comment-15392021
]
Rakesh R commented on ZOOKEEPER-2383:
-
fyi: The patch got a green
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391877#comment-15391877
]
Rakesh R commented on ZOOKEEPER-2383:
-
Attached initial patch where I've used
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391428#comment-15391428
]
Rakesh R commented on ZOOKEEPER-2383:
-
[~ozawa], thanks for the interest. I was busy with other
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15391420#comment-15391420
]
Tsuyoshi Ozawa commented on ZOOKEEPER-2383:
---
[~rakeshr] hi Rakesh, how is the progress of
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206310#comment-15206310
]
Jason Rosenberg commented on ZOOKEEPER-2383:
Yes, agreed, you wouldn't use a
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206169#comment-15206169
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~jbrosenb...@gmail.com]. Disbaling or mocking may
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198781#comment-15198781
]
Jason Rosenberg commented on ZOOKEEPER-2383:
I've run into similar issues, with the
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189157#comment-15189157
]
Rakesh R commented on ZOOKEEPER-2383:
-
I think I found the code changes which results in this bug.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186556#comment-15186556
]
Rakesh R commented on ZOOKEEPER-2383:
-
Thanks [~steve_rowe] for reporting this issue and good
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185740#comment-15185740
]
Steve Rowe commented on ZOOKEEPER-2383:
---
Similarly to the subclassed ZooKeeperServer above, if I
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185412#comment-15185412
]
Steve Rowe commented on ZOOKEEPER-2383:
---
FWIW, I was able to work around the problem in Solr
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185323#comment-15185323
]
Flavio Junqueira commented on ZOOKEEPER-2383:
-
[~steve_rowe] Thanks for reporting this
[
https://issues.apache.org/jira/browse/ZOOKEEPER-2383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185285#comment-15185285
]
Steve Rowe commented on ZOOKEEPER-2383:
---
This program triggers the problem for me roughly 10% of
67 matches
Mail list logo
