[jira] [Commented] (ZOOKEEPER-2979) Use dropwizard library histogram for proposal-related metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465494#comment-16465494 ] Hadoop QA commented on ZOOKEEPER-2979: -- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 16 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1662//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1662//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1662//console This message is automatically generated. > Use dropwizard library histogram for proposal-related metrics > - > > Key: ZOOKEEPER-2979 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2979 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > > This Jira in intended to be the successor of ZOOKEEPER-2939. > By using dropwizard library's Histogram component we'll be able to provide > more sophisticated statistics on Proposal sizes. > From the docs: > "A histogram measures the statistical distribution of values in a stream of > data. In addition to minimum, maximum, mean, etc., it also measures median, > 75th, 90th, 95th, 98th, 99th, and 99.9th percentiles." > [http://metrics.dropwizard.io/3.1.0/manual/core/#histograms] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2979) Use dropwizard library histogram for proposal-related metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16451403#comment-16451403 ] ASF GitHub Bot commented on ZOOKEEPER-2979: --- Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/440 3.5 is still in beta, so I'm not super worried wrt it being an addition. I also think it's super valuable to improve reporting. I'm erring on the side of inclusion - any objections? > Use dropwizard library histogram for proposal-related metrics > - > > Key: ZOOKEEPER-2979 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2979 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > > This Jira in intended to be the successor of ZOOKEEPER-2939. > By using dropwizard library's Histogram component we'll be able to provide > more sophisticated statistics on Proposal sizes. > From the docs: > "A histogram measures the statistical distribution of values in a stream of > data. In addition to minimum, maximum, mean, etc., it also measures median, > 75th, 90th, 95th, 98th, 99th, and 99.9th percentiles." > [http://metrics.dropwizard.io/3.1.0/manual/core/#histograms] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2979) Use dropwizard library histogram for proposal-related metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449782#comment-16449782 ] ASF GitHub Bot commented on ZOOKEEPER-2979: --- Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/440 @phunt right, I misunderstood your comment. I think not merging this patch to 3.4 is acceptable, but I'd argue with 3.5/3.6 a little bit. Given that how much time is needed to release a major version of ZooKeeper - even if we're successful at accelerating a little bit - I'm afraid this patch won't see a stable release in the foreseeable future. That's my only reason why I'd put this into 3.5 and keep the dumb implementation (last/min/max) in 3.4. > Use dropwizard library histogram for proposal-related metrics > - > > Key: ZOOKEEPER-2979 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2979 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > > This Jira in intended to be the successor of ZOOKEEPER-2939. > By using dropwizard library's Histogram component we'll be able to provide > more sophisticated statistics on Proposal sizes. > From the docs: > "A histogram measures the statistical distribution of values in a stream of > data. In addition to minimum, maximum, mean, etc., it also measures median, > 75th, 90th, 95th, 98th, 99th, and 99.9th percentiles." > [http://metrics.dropwizard.io/3.1.0/manual/core/#histograms] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2979) Use dropwizard library histogram for proposal-related metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16449004#comment-16449004 ] ASF GitHub Bot commented on ZOOKEEPER-2979: --- Github user phunt commented on the issue: https://github.com/apache/zookeeper/pull/440 @anmolnar I believe you misunderstood my comment above: > likely this change will go into master (3.6.0+) - impact on backports. I'm assuming we would want to take advantage of this library across the board. (can we do that? I assume yes?) > Sure, I'll have to backport it to branch-3.4, it will need some manual work for sure, but I don't expect it to be the end of the world. I meant that I was planning to only commit this change for 3.6.0+ - I am generally reticent to add a new dependency so late in the 3.5 train. Do you feel strongly otw? > Use dropwizard library histogram for proposal-related metrics > - > > Key: ZOOKEEPER-2979 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2979 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > > This Jira in intended to be the successor of ZOOKEEPER-2939. > By using dropwizard library's Histogram component we'll be able to provide > more sophisticated statistics on Proposal sizes. > From the docs: > "A histogram measures the statistical distribution of values in a stream of > data. In addition to minimum, maximum, mean, etc., it also measures median, > 75th, 90th, 95th, 98th, 99th, and 99.9th percentiles." > [http://metrics.dropwizard.io/3.1.0/manual/core/#histograms] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (ZOOKEEPER-2979) Use dropwizard library histogram for proposal-related metrics
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371492#comment-16371492 ] ASF GitHub Bot commented on ZOOKEEPER-2979: --- Github user anmolnar commented on the issue: https://github.com/apache/zookeeper/pull/440 @aberghage Did you have a chance to take look? @afine I changed the implementation to use a configurable sliding window. Do you see any other thing that I should improve? > Use dropwizard library histogram for proposal-related metrics > - > > Key: ZOOKEEPER-2979 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2979 > Project: ZooKeeper > Issue Type: Sub-task > Components: server >Reporter: Andor Molnar >Assignee: Andor Molnar >Priority: Major > > This Jira in intended to be the successor of ZOOKEEPER-2939. > By using dropwizard library's Histogram component we'll be able to provide > more sophisticated statistics on Proposal sizes. > From the docs: > "A histogram measures the statistical distribution of values in a stream of > data. In addition to minimum, maximum, mean, etc., it also measures median, > 75th, 90th, 95th, 98th, 99th, and 99.9th percentiles." > [http://metrics.dropwizard.io/3.1.0/manual/core/#histograms] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
