[jira] [Updated] (ZOOKEEPER-3009) Potential NPE in NIOServerCnxnFactory
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han updated ZOOKEEPER-3009:
---
Fix Version/s: 3.4.14
> Potential NPE in NIOServerCnxnFactory
> -
>
> Key: ZOOKEEPER-3009
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3009
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.6.0, 3.4.12
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5, 3.4.14
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Inspired by ZK-3006 , I develop a simple static analysis tool to find other
> Potential NPE like ZK-3006. This bug is found by this tool ,and I have
> carefully studied it. But i am a newbie at here so i may be wrong, hope
> someone could confirm it and help me improve this tool.
> h2. Bug description:
> class NIOServerCnxn has three method
> :getSocketAddress,getRemoteSocketAddress can return null just like :
> {code:java}
> // code placeholder
> if (sock.isOpen() == false) {
> return null;
> }
> {code}
> some of their caller give null checker, some(total 3 list in below) are not.
> {code:java}
> // ServerCnxn#getConnectionInfo
> Map info = new LinkedHashMap();
> info.put("remote_socket_address", getRemoteSocketAddress());// Map.put will
> throw NPE if parameter is null
> //IPAuthenticationProvider#handleAuthentication
> tring id = cnxn.getRemoteSocketAddress().getAddress().getHostAddress();
> cnxn.addAuthInfo(new Id(getScheme(), id));// finally call Set.add(it will
> throw NPE if parameter is null )
> //NIOServerCnxnFactory#addCnxn
> InetAddress addr = cnxn.getSocketAddress();
> Set set = ipMap.get(addr);// Map.get will throw NPE if
> parameter is null{code}
> I think we should add null check in above three caller .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3009) Potential NPE in NIOServerCnxnFactory
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Han updated ZOOKEEPER-3009:
---
Affects Version/s: 3.4.12
> Potential NPE in NIOServerCnxnFactory
> -
>
> Key: ZOOKEEPER-3009
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3009
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.6.0, 3.4.12
>Reporter: lujie
>Assignee: lujie
>Priority: Major
> Labels: pull-request-available
> Fix For: 3.6.0, 3.5.5
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Inspired by ZK-3006 , I develop a simple static analysis tool to find other
> Potential NPE like ZK-3006. This bug is found by this tool ,and I have
> carefully studied it. But i am a newbie at here so i may be wrong, hope
> someone could confirm it and help me improve this tool.
> h2. Bug description:
> class NIOServerCnxn has three method
> :getSocketAddress,getRemoteSocketAddress can return null just like :
> {code:java}
> // code placeholder
> if (sock.isOpen() == false) {
> return null;
> }
> {code}
> some of their caller give null checker, some(total 3 list in below) are not.
> {code:java}
> // ServerCnxn#getConnectionInfo
> Map info = new LinkedHashMap();
> info.put("remote_socket_address", getRemoteSocketAddress());// Map.put will
> throw NPE if parameter is null
> //IPAuthenticationProvider#handleAuthentication
> tring id = cnxn.getRemoteSocketAddress().getAddress().getHostAddress();
> cnxn.addAuthInfo(new Id(getScheme(), id));// finally call Set.add(it will
> throw NPE if parameter is null )
> //NIOServerCnxnFactory#addCnxn
> InetAddress addr = cnxn.getSocketAddress();
> Set set = ipMap.get(addr);// Map.get will throw NPE if
> parameter is null{code}
> I think we should add null check in above three caller .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3009) Potential NPE in NIOServerCnxnFactory
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated ZOOKEEPER-3009:
--
Labels: pull-request-available (was: )
> Potential NPE in NIOServerCnxnFactory
> -
>
> Key: ZOOKEEPER-3009
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3009
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.6.0
>Reporter: lujie
>Priority: Major
> Labels: pull-request-available
>
> Inspired by ZK-3006 , I develop a simple static analysis tool to find other
> Potential NPE like ZK-3006. This bug is found by this tool ,and I have
> carefully studied it. But i am a newbie at here so i may be wrong, hope
> someone could confirm it and help me improve this tool.
> h2. Bug description:
> class NIOServerCnxn has three method
> :getSocketAddress,getRemoteSocketAddress can return null just like :
> {code:java}
> // code placeholder
> if (sock.isOpen() == false) {
> return null;
> }
> {code}
> some of their caller give null checker, some(total 3 list in below) are not.
> {code:java}
> // ServerCnxn#getConnectionInfo
> Map info = new LinkedHashMap();
> info.put("remote_socket_address", getRemoteSocketAddress());// Map.put will
> throw NPE if parameter is null
> //IPAuthenticationProvider#handleAuthentication
> tring id = cnxn.getRemoteSocketAddress().getAddress().getHostAddress();
> cnxn.addAuthInfo(new Id(getScheme(), id));// finally call Set.add(it will
> throw NPE if parameter is null )
> //NIOServerCnxnFactory#addCnxn
> InetAddress addr = cnxn.getSocketAddress();
> Set set = ipMap.get(addr);// Map.get will throw NPE if
> parameter is null{code}
> I think we should add null check in above three caller .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (ZOOKEEPER-3009) Potential NPE in NIOServerCnxnFactory
[
https://issues.apache.org/jira/browse/ZOOKEEPER-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lujie updated ZOOKEEPER-3009:
-
Summary: Potential NPE in NIOServerCnxnFactory (was: Potential NPE: class
NIOServerCnxn has two method can return null)
> Potential NPE in NIOServerCnxnFactory
> -
>
> Key: ZOOKEEPER-3009
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3009
> Project: ZooKeeper
> Issue Type: Bug
>Affects Versions: 3.6.0
>Reporter: lujie
>Priority: Major
>
> Inspired by ZK-3006 , I develop a simple static analysis tool to find other
> Potential NPE like ZK-3006. This bug is found by this tool ,and I have
> carefully studied it. But i am a newbie at here so i may be wrong, hope
> someone could confirm it and help me improve this tool.
> h2. Bug description:
> class NIOServerCnxn has three method
> :getSocketAddress,getRemoteSocketAddress can return null just like :
> {code:java}
> // code placeholder
> if (sock.isOpen() == false) {
> return null;
> }
> {code}
> some of their caller give null checker, some(total 3 list in below) are not.
> {code:java}
> // ServerCnxn#getConnectionInfo
> Map info = new LinkedHashMap();
> info.put("remote_socket_address", getRemoteSocketAddress());// Map.put will
> throw NPE if parameter is null
> //IPAuthenticationProvider#handleAuthentication
> tring id = cnxn.getRemoteSocketAddress().getAddress().getHostAddress();
> cnxn.addAuthInfo(new Id(getScheme(), id));// finally call Set.add(it will
> throw NPE if parameter is null )
> //NIOServerCnxnFactory#addCnxn
> InetAddress addr = cnxn.getSocketAddress();
> Set set = ipMap.get(addr);// Map.get will throw NPE if
> parameter is null{code}
> I think we should add null check in above three caller .
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
