Re: Patch for ZOOKEEPER-2184 feedback

2017-03-31 Thread powell molleti
Hi Flavio, Here are the changes: https://github.com/apache/zookeeper/pull/199 Let me know if this is headed in the right direction due to the fact that I had to modify many files to accommodate changes to StaticHostProvider and its API. We can move the discussion to the JIRA if required.

Re: Patch for ZOOKEEPER-2184 feedback

2017-03-31 Thread Flavio Junqueira
I'd love to see ZK-2184 fixed. If you have come up with a PR, Powell, I'd be happy to have a look and see if we can converge to a common set of changes. Michael is right that there is already a PR there, so we would eventually need to decide whether to make changes to it, drop or what. -Flavio

Re: Patch for ZOOKEEPER-2184 feedback

2017-03-31 Thread powell molleti
Hi Michael, I did look at it and I can attempt to rebase to it that should not be a problem but that again the changes could undo most of it. I am pointing to the comment:

Re: Patch for ZOOKEEPER-2184 feedback

2017-03-30 Thread Michael Han
HI Powell, Have you looked at the existing PR ( https://github.com/apache/zookeeper/pull/150) for ZOOKEEPER-2184? I think that's what community is working on, and it's close to get merged, so probably worth to adjust your work on top of that issue? On Wed, Mar 29, 2017 at 9:25 PM, powell molleti

Patch for ZOOKEEPER-2184 feedback

2017-03-29 Thread powell molleti
Hi, I was wondering if anyone has cycles to look at the PR I have for ZOOKEEPER-2184: Resolve address only on demand ( https://github.com/apache/zookeeper/pull/199 ). Let me know if I am heading in the wrong direction any pointers will help me to use these changes or drop them from a