Re: [oxid-dev-general] Private methods in current security patch

2016-06-20 Thread Tomas Kvietkauskas
Ah ok, checked the code, you are talking about cleanBillingAddress and cleanDeliveryAddress methods. You are right, this could affect extended createUser method functionality, just because its one huge mess and I assume nobody calls parent on it’s extended method and this core patch becomes

[oxid-dev-general] Private methods in current security patch

2016-06-20 Thread Dirk Mueller
Hi, be aware that the two new implemented methods in oxcmp_user class at the previous security patch have been declared as "private functions". Is there any reason to use "private functions" instead of "protected functions"? Current situation could kill modules which are overwriting