Hey. > On 2. Aug 2017, at 18:22, Ben Withers <manicbe...@gmail.com> wrote: > As far as I know, Ichnaea supports MLS and Combain (and Google?) APIs as > fallback.
Yes. They all support almost the same API, with some very minor differences for special cases. So we end up with one implementation to support them all. > The UnWired Labs Location API docs can be found here: > http://unwiredlabs.com/api#documentation > > As you can see, it's not too different from other APIs, but the field names > are identical to the Google API and the addition of a token field for the API > token (rather than having token in the URL) and a status and balance field in > the response (used for query status and token credit balance). > > I think the best approach is to make a copy of the json constructors that > build the json dict up as per the UnWired API when the api_key.fallback_name > is "unwired" for example. Of course, schemas would be added to do the > response checking and so on. > > I would just like to know if anyone else has tried doing anything like this > or if anyone has any advice for tackling this. I can imagine that once I > start, I'll probably run into loads of issues regarding schema validation and > so on. I've added two bits to make this easier and created an issue over at https://github.com/mozilla/ichnaea/issues/508 <https://github.com/mozilla/ichnaea/issues/508> There's a new fallback_schema column (varchar 64 )in the api_key table, which can be used as an explicit source for determining the fallback API schema. I've also changed our fallback provider code to look up the API schema based on this column. If it's null or ''ichnaea/v1'', it uses our own schema. It could act on something like 'unwiredlabs/v1' to use a different schema. I think it should be enough to add new JSON colander schemas to https://github.com/mozilla/ichnaea/blob/master/ichnaea/api/locate/fallback.py <https://github.com/mozilla/ichnaea/blob/master/ichnaea/api/locate/fallback.py> and appropriate tests to https://github.com/mozilla/ichnaea/blob/master/ichnaea/api/locate/tests/test_fallback.py <https://github.com/mozilla/ichnaea/blob/master/ichnaea/api/locate/tests/test_fallback.py>. Nothing else in the codebase should require changes. The only other problem I can see is the fallback cache. I think it's currently not separated by fallback name. It could make sense to separate it by fallback schema, so you don't end up mixing results from too very different providers. But that's only a concern in the unlikely case you are using multiple different fallback providers in one installation. Hope this helps, Hanno _______________________________________________ dev-geolocation mailing list dev-geolocation@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-geolocation
