[magnolia-dev] [JIRA] (MGNLUI-4031) Unreferenced properties created by the BasicTransformer (fix for MGNL-2494 has side effects)
Title: Message Title Daniel Kasmeroglu created an issue Magnolia UI / MGNLUI-4031 Unreferenced properties created by the BasicTransformer (fix for MGNL-2494 has side effects) Issue Type: Bug Affects Versions: 5.3.10 Assignee: Unassigned Components: dialogs Created: 07/Oct/16 9:17 PM Environment: Linux (Ubuntu 15.10), Java 7 Priority: Major Reporter: Daniel Kasmeroglu Security Level: Public The fix for MGNL-2494 introduced an attempt to fix a type consistency issue while replacing a property on an item. The code in question (BasicTransformer@156):
[magnolia-dev] [JIRA] (MGNLUI-4031) Unreferenced properties created by the BasicTransformer (fix for MGNL-2494 has side effects)
Title: Message Title Daniel Kasmeroglu updated an issue Magnolia UI / MGNLUI-4031 Unreferenced properties created by the BasicTransformer (fix for MGNL-2494 has side effects) Change By: Daniel Kasmeroglu The fix for MGNL MGNLUI -2494 introduced an attempt to fix a type consistency issue while replacing a property on an item. The code in question (BasicTransformer@156):{code:java}property = new DefaultProperty(type, value);// This will replace the previous property (with the wrong type) with the new one (correctly typed).relatedFormItem.addItemProperty(propertyName, property);{code}As the comment mentions this code assumes that the original property will be replaced while calling *addItemProperty*. I couldn't see any indication of this within the Vaadin documentation which clearly says that a *new* property will be added.If someone runs into this section when the *relatedFormItem* is of type *PropertysetItem* (or a descendent such as *BeanItem*) this will cause problems.Calling *addItemProperty* in these instances won't have any effect as *PropertysetItem* won't allow to add the new property which is therefore not linked to the *relatedFormItem*.The new and unreferenced property with the *fixed* type is being returned and might get used by the caller without having any real effect since it's not referenced by the *relatedFormItem*.This is somewhat problematic since it's hard to notice. Each call to *getOrCreateProperty(Class type)* might give an unreferenced property so these locations must be investigated (it's probably a good idea to check JIRA first).One quick fix might be the removal of the property which then essentially implements the replacement operation.If I find the time I will try to create a small project in order to provide an error causing example. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
[magnolia-dev] [JIRA] (MGNLUI-4031) Unreferenced properties created by the BasicTransformer (fix for MGNLUI-2494 has side effects)
Title: Message Title Daniel Kasmeroglu updated an issue Magnolia UI / MGNLUI-4031 Unreferenced properties created by the BasicTransformer (fix for MGNLUI-2494 has side effects) Change By: Daniel Kasmeroglu Summary: Unreferenced properties created by the BasicTransformer (fix for MGNL MGNLUI -2494 has side effects) Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (CFGUI-46) Fix linking to definitions in overview subapp
Title: Message Title Cedric Reichenbach updated an issue Definitions app / CFGUI-46 Fix linking to definitions in overview subapp Change By: Cedric Reichenbach There's an action `OpenDefinitionActionDefinition` which currently only opens the overview subapp, but doesn't highlight the corresponding definition node.This is related to opening detail locations not working properly in the definitions app in general. Action bar definiton to be re-added afterwards:{noformat}actionbar: sections:file: groups:default: items:- name: showDefinition availability:rules: IsFileDefinitionRule:implementationClass: info.magnolia.definitions.app.overview.availability.IsDefinitionRule{noformat} Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (NOWDEMO-9) use navfn
Title: Message Title Tomáš Gregovský created an issue NOW demo / NOWDEMO-9 use navfn Issue Type: Task Assignee: Tomáš Gregovský Created: 07/Oct/16 12:01 PM Priority: Neutral Reporter: Tomáš Gregovský temporary with SNAPSHOT libraries Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
[magnolia-dev] [JIRA] (MTE-91) searchfn is not searching in parent page
Title: Message Title Tomáš Gregovský created an issue Magnolia Templating Essentials / MTE-91 searchfn is not searching in parent page Issue Type: Bug Affects Versions: 0.13 Assignee: Unassigned Created: 07/Oct/16 11:57 AM Priority: Neutral Reporter: Tomáš Gregovský When multiple root pages exists (e.g. /en, /de, /es, ) then when want to search for something only in /en tree have to use this: searchfn.searchPages(queryStr, "/en") then results are only from subpages of /en and if match is also on /en page itself then its ignored. Add Comment
[magnolia-dev] [JIRA] (MGNLCE-48) Switch default bundle db to H2
Title: Message Title Ilgun Ilgun updated an issue Magnolia Community Edition / MGNLCE-48 Switch default bundle db to H2 Change By: Ilgun Ilgun Fix Version/s: 5.5 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (CFGUI-48) Provide detail view for problems
Title: Message Title Cedric Reichenbach created an issue Definitions app / CFGUI-48 Provide detail view for problems Issue Type: Sub-task Assignee: Unassigned Created: 07/Oct/16 11:38 AM Priority: Neutral Reporter: Cedric Reichenbach With, only information from the tree view is visible, which are severity (icon), title and description. However, there is more metadata collected, which should be exposed in some kind of detail view: Attached Exception Location of problem (within definition) One possible way to implement this would be a detail subapp, opened through an action. Otherwise, it could also be provided through a popup appearing on mouseover, or triggered by an action too. Add Comment
[magnolia-dev] [JIRA] (CFGUI-47) Use mono-space font for code-related detail messages
Title: Message Title Cedric Reichenbach created an issue Definitions app / CFGUI-47 Use mono-space font for code-related detail messages Issue Type: Sub-task Assignee: Unassigned Created: 07/Oct/16 11:27 AM Priority: Neutral Reporter: Cedric Reichenbach For instance, YAML syntax errors contain code sippets which may be misaligned when using non-monospace fonts: Failed to parse YAML file: Parser: while parsing a block mapping in 'reader', line 1, column 1: form: ^ expected , but found BlockSequenceStart in 'reader', line 3, column 5: - name: tabMain ^ Add Comment
[magnolia-dev] [JIRA] (CFGUI-46) Fix linking to definitions in overview subapp
Title: Message Title Cedric Reichenbach created an issue Definitions app / CFGUI-46 Fix linking to definitions in overview subapp Issue Type: Sub-task Assignee: Unassigned Created: 07/Oct/16 11:24 AM Priority: Neutral Reporter: Cedric Reichenbach There's an action `OpenDefinitionActionDefinition` which currently only opens the overview subapp, but doesn't highlight the corresponding definition node. This is related to opening detail locations not working properly in the definitions app in general. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
[magnolia-dev] [JIRA] (CFGUI-45) Polish problems subapp
Title: Message Title Cedric Reichenbach created an issue Definitions app / CFGUI-45 Polish problems subapp Issue Type: Improvement Assignee: Unassigned Created: 07/Oct/16 11:02 AM Priority: Neutral Reporter: Cedric Reichenbach The first shot at the problems subapp as been kept simple and rough to have a working solution in time, thus it requires some further polishing. See sub-tasks for details. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
[magnolia-dev] [JIRA] (SUGGEST-54) Blog app list component
Title: Message Title Ben Price updated an issue Suggestion Box / SUGGEST-54 Blog app list component Change By: Ben Price Issue Type: Bug Task Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (SUGGEST-54) Blog app list component
Title: Message Title Ben Price updated an issue Suggestion Box / SUGGEST-54 Blog app list component Change By: Ben Price Component listing teasers to blog posts Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (SUGGEST-54) Blog app list compkentn
Title: Message Title Ben Price created an issue Suggestion Box / SUGGEST-54 Blog app list compkentn Issue Type: Bug Assignee: Unassigned Created: 07/Oct/16 10:48 AM Priority: Neutral Reporter: Ben Price Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (SUGGEST-54) Blog app list component
Title: Message Title Ben Price updated an issue Suggestion Box / SUGGEST-54 Blog app list component Change By: Ben Price Summary: Blog app list compkentn component Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLDEMO-111) Navigation in travel demo should be based on MTE
Title: Message Title Milan Divilek updated an issue Magnolia Demo Projects / MGNLDEMO-111 Navigation in travel demo should be based on MTE Change By: Milan Divilek Sprint: Kromeriz 64 Account: null (null) Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLDEMO-111) Navigation in travel demo should be based on MTE
Title: Message Title Milan Divilek updated an issue Magnolia Demo Projects / MGNLDEMO-111 Navigation in travel demo should be based on MTE Change By: Milan Divilek Assignee: Milan Divilek Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLDEMO-111) Navigation in travel demo should be based on MTE
Title: Message Title Milan Divilek updated an issue Magnolia Demo Projects / MGNLDEMO-111 Navigation in travel demo should be based on MTE Change By: Milan Divilek Story Points: 5 2 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to: