[magnolia-dev] [JIRA] (SUGGEST-55) Pages with form components (Form Module) should be cacheable by config
Title: Message Title Edwin Guilbert updated an issue Suggestion Box / SUGGEST-55 Pages with form components (Form Module) should be cacheable by config Change By: Edwin Guilbert It's a common use case to have forms in pages you need to be cached. Cache strategies are available for any page in Magnolia and that can be managed just by config.The problem comes when you try to enable caching on a page containing form components from the Magnolia Form Module, because no matter what config you have in the cache module policies, it will get overriden by a line of code in AbstractFormModel#execute():{code}if (MgnlContext.isWebContext()) {MgnlContext.getWebContext().getResponse().setHeader("Cache-Control", "no-cache");}{code}Even though this is a good practice in the sense that the form component can't ever be cached or it will run into known issues, there should be an easy way to disable this behaviour in order to be able to cache the page containing this component. Later on you could apply other strategies to update (or not cache) just the form element from the page by for example requesting this component by Ajax every time the page is loaded or just using the [Dynamic Page Caching|https://documentation.magnolia-cms.com/display/DOCS/Advanced+Cache+Dynamic+Page+Caching] in Magnolia 5.4.5+We need a "config easy way" of disabling this default behaviour of form components. Right now the only way is by overriding the whole AbstractFormModel because it can't be properly extended. Its using private global attributes inside the execute method so you have to override all methods from the class, otherwise you will get NPEs. See the example class attached.This option is really bad in general because it has maintainability issues: whenever you update the form module you will have to check if the original class changed to make the same changes in your copy.I also attached another class approach (extending the execute method and just resetting the header) but this one will reset the cache-control header which is wrong in general because none of the browser cache policies get applied to the response of the page.What we need is a refactoring of the AbstractFormModel class allowing the cache functionality to be managed by config. Add Comment
[magnolia-dev] [JIRA] (SUGGEST-55) Pages with form components (Form Module) should be cacheable by config
Title: Message Title Edwin Guilbert created an issue Suggestion Box / SUGGEST-55 Pages with form components (Form Module) should be cacheable by config Issue Type: Improvement Assignee: Unassigned Created: 28/Oct/16 3:02 PM Environment: Labels: collector-0cf1239d Reporter: Edwin Guilbert It's a common use case to have forms in pages you need to be cached. Cache strategies are available for any page in Magnolia and that can be managed just by config. The problem comes when you try to enable caching on a page containing form components from the Magnolia Form Module, because no matter what config you have in the cache module policies, it will get overriden by a line of code in AbstractFormModel#execute(): if (MgnlContext.isWebContext()) { MgnlContext.getWebContext().getResponse().setHeader("Cache-Control", "no-cache"); } Even though this is a good practice in the sense that the form component can't ever be cached or it will run into known issues, there should be an easy way to disable this behaviour in order to be able to cache the page containing this component. Later on you could apply other strategies to update (or not cache) just the form element from the page by for example requesting this component by Ajax every time the page is loaded or just using the Dynamic Page Caching in Magnolia 5.4.5+
[magnolia-dev] Re: Deep Link to asset
Hey Guys- I think the reason this doesn't work is because you need a special servlet for delivering pdf files. The repository mapping is only half the battle. See https://documentation.magnolia-cms.com/display/DOCS53/DAM+core+functionality. At the bottom of that page we show the mapping and the servlet. Without the servlet you'll hit rendering which won't know what to do with this request. HTH richg -- Context is everything: http://forum.magnolia-cms.com/forum/thread.html?threadId=19ada310-7e65-4f26-b0e9-0a507d23b21d For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-4043) Since Vaadin update (7.7.0?) app-specific themes sometimes aren't applied
Title: Message Title Aleksandr Pchelintcev updated an issue Magnolia UI / MGNLUI-4043 Since Vaadin update (7.7.0?) app-specific themes sometimes aren't applied Change By: Aleksandr Pchelintcev Sprint: Basel 68 67 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLWORKFLOW-342) Add custom fields to the page publication dialog.
Title: Message Title Adrien Manzoni created an issue Magnolia Workflow Module / MGNLWORKFLOW-342 Add custom fields to the page publication dialog. Issue Type: Improvement Affects Versions: 5.4.9 Assignee: Unassigned Components: Base Created: 28/Oct/16 1:29 PM Priority: Neutral Reporter: Adrien Manzoni In the config app (/modules/workflow/dialogs/publish/form), it is possible to configure the publication dialog (for instance to add one field). However, if we have a look to the related dialog presenter (info.magnolia.module.workflow.action.WorkflowFormDialogPresenter), in the configureDialogActions action, my action definition object will be copied over a WorkflowPublicationActionDefinition one. As my new field does not exist in WorkflowPublicationActionDefinition, it will not be transmitted to the publication task and I will not be able to display it in the publication task dialog.
[magnolia-dev] [JIRA] (MGNLUI-4043) Since Vaadin update (7.7.0?) app-specific themes sometimes aren't applied
Title: Message Title Aleksandr Pchelintcev updated an issue Magnolia UI / MGNLUI-4043 Since Vaadin update (7.7.0?) app-specific themes sometimes aren't applied Change By: Aleksandr Pchelintcev Assignee: Aleksandr Pchelintcev Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-4059) Correct the Java DB driver parser
Title: Message Title Maxime Michel created an issue Magnolia UI / MGNLUI-4059 Correct the Java DB driver parser Issue Type: Bug Affects Versions: 5.4.9 Assignee: Unassigned Attachments: Screen Shot 2016-10-28 at 11.42.23.png Created: 28/Oct/16 11:44 AM Priority: Neutral Reporter: Maxime Michel Security Level: Public As the following URL currently shows, there is a problem in the About page: https://demo.magnolia-cms.com/.magnolia/admincentral#app:about:; The revision is parsed incorrectly.
[magnolia-dev] [JIRA] (MGNLDEMO-171) 'sportstation' site should not extend domains from 'travel' site
Title: Message Title Maxime Michel updated an issue Magnolia Demo Projects / MGNLDEMO-171 'sportstation' site should not extend domains from 'travel' site Change By: Maxime Michel Story Points: 2 3 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLSITE-73) Remove theme subapp from site-app
Title: Message Title Philip Mundt updated an issue Magnolia Site Module / MGNLSITE-73 Remove theme subapp from site-app Change By: Philip Mundt Release notes required: Yes Account: null (null) Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] Re: Deep Link to asset
Thank you Tom for your input!!! I've now removed the "class" from URI2Repository. So now there are only the following entries for the "maps-assets"-node of "URI2RepositoryMapping": URIPrevix /maps-assets/ handlePrefix - repository maps-assets With the "cmsf.link" now I get back the URL "/connect-hearing-webapp/connect-hearing/maps-assets/gateB/Magnolia-Flyer-4.0.pdf.html". So new there is a ".html" added at the end. But this still gives me a "404" if I enter this URL in a separate Tab of my browser (of course with preset "localhost:8080"). Any other ideas? Thanks Roland -- Context is everything: http://forum.magnolia-cms.com/forum/thread.html?threadId=19ada310-7e65-4f26-b0e9-0a507d23b21d For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (PAGES-101) Get rid of MGWT from AdminCentral
Title: Message Title Hieu Nguyen Duc updated an issue Magnolia pages module / PAGES-101 Get rid of MGWT from AdminCentral Change By: Hieu Nguyen Duc Issue Type: Bug Improvement Account: null (null) Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-2787) Get rid of MGWT from AdminCentral
Title: Message Title Hieu Nguyen Duc updated an issue Magnolia UI / MGNLUI-2787 Get rid of MGWT from AdminCentral Change By: Hieu Nguyen Duc Summary: Get rid of MGWT from AdminCentral . Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (PAGES-101) Get rid of MGWT from AdminCentral
Title: Message Title Hieu Nguyen Duc created an issue Magnolia pages module / PAGES-101 Get rid of MGWT from AdminCentral Issue Type: Bug Assignee: Hieu Nguyen Duc Created: 28/Oct/16 10:05 AM Fix Versions: 5.5 Labels: client-side gwt mgwt Priority: Major Reporter: Hieu Nguyen Duc The gesture/touch events provided by MGWT are quite useful in AdminCentral's client-side implementation, but 20 permutations most of which are irrelevant to our case is a huge stress for continuous deployment (especially with closure-compiler option on). We could consider implementing the functionality provided by MGWT directly in AdminCentral and dropping dependency on it. Add Comment
[magnolia-dev] [JIRA] (MGNLCI-8) Pulse task list should display name of file to import
Title: Message Title Ilgun Ilgun updated an issue Magnolia Content Importer Module / MGNLCI-8 Pulse task list should display name of file to import Change By: Ilgun Ilgun Sprint: Basel 68 67 Account: null (null) Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to: