[magnolia-dev] [JIRA] (MGNLUI-4168) FieldDefinitionKeyGenerator#getParentName should emit log messages less severe than warnings

2017-03-27 Thread on behalf of Michael Mühlebach 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Mühlebach updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4168  
 
 
  FieldDefinitionKeyGenerator#getParentName should emit log messages less severe than warnings   
 

  
 
 
 
 

 
Change By: 
 Michael Mühlebach  
 
 
Story Points: 
 2  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-4168) FieldDefinitionKeyGenerator#getParentName should emit log messages less severe than warnings

2017-03-20 Thread JIRA (on behalf of Philip Mundt) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Mundt updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4168  
 
 
  FieldDefinitionKeyGenerator#getParentName should emit log messages less severe than warnings   
 

  
 
 
 
 

 
Change By: 
 Philip Mundt  
 
 
Sprint: 
 Basel 88  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-4168) FieldDefinitionKeyGenerator#getParentName should emit log messages less severe than warnings

2017-03-20 Thread JIRA (on behalf of Aleksandr Pchelintcev) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Aleksandr Pchelintcev updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4168  
 
 
  FieldDefinitionKeyGenerator#getParentName should emit log messages less severe than warnings   
 

  
 
 
 
 

 
Change By: 
 Aleksandr Pchelintcev  
 

  
 
 
 
 

 
 Currently when field's keys are populated, the generator walks from parent to parent and collects their names (via {{FieldDefinitionKeyGenerator#getParentName}} which merely attempts to call a {{getName()}} method). Under certain circumstances, some parents in such chain may not produce the name for some reason.One example could be a {{ContentDefinition}}:  { { code:java} @ I18nable I18nabe public class ContentDefinition {private List outlineFields;  private String defaultBlock;  private List blocks;public List getOutlineFields() {return outlineFields;}public void setOutlineFields(List outlineFields) {this.outlineFields = outlineFields;} public String getDefaultBlock() { ...  return defaultBlock; } public void setDefaultBlock(String defaultBlock)  { this.defaultBlock = defaultBlock; code } public List Such definition is included in an article editor sub-app descriptor and delivers such information as block identifiers and also the collection of the outline field definitions. Those fields should be i18n-izable and sufficient keys could look like {{ < String app >  getBlocks() ..}}. All works fine except for  { return blocks; {ContentDefinition } } does not provide its name which results in a warning similar to the following:  public void setBlocks {{..:Cannot obtain name of parent object: info.magnolia.editor.content.ContentDefinition$$EnhancerByCGLIB$$614a4d1b.getName ( List blocks )  { }}.  this We don't care about the content definition's name and field key generator doesn't fail on its absence - only emits the warning and moves on . blocks = blocks;  }  }}} Shouldn't we just lower the severity of the log statement to debug for such cases?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment

[magnolia-dev] [JIRA] (MGNLUI-4168) FieldDefinitionKeyGenerator#getParentName should emit log messages less severe than warnings

2017-03-20 Thread JIRA (on behalf of Aleksandr Pchelintcev) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Aleksandr Pchelintcev created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4168  
 
 
  FieldDefinitionKeyGenerator#getParentName should emit log messages less severe than warnings   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Affects Versions: 
 5.5.2  
 
 
Assignee: 
 Aleksandr Pchelintcev  
 
 
Created: 
 20/Mar/17 10:44 AM  
 
 
Fix Versions: 
 5.5.3  
 
 
Priority: 
  Neutral  
 
 
Reporter: 
 Aleksandr Pchelintcev  
 

  
 
 
 
 

 
 Currently when field's keys are populated, the generator walks from parent to parent and collects their names (via FieldDefinitionKeyGenerator#getParentName which merely attempts to call a getName() method). Under certain circumstances, some parents in such chain may not produce the name for some reason. One example could be a ContentDefinition: {{ @I18nable public class ContentDefinition {  private List outlineFields;  private String defaultBlock;  private List blocks;  public List getOutlineFields()  { return outlineFields; }  public void setOutlineFields(List outlineFields)  { this.outlineFields = outlineFields; }  public String getDefaultBlock()  { return defaultBlock; }  public void setDefaultBlock(String defaultBlock)  { this.defaultBlock = defaultBlock; }  public List getBlocks()  { return blocks; }  public void setBlocks(List blocks)  { this.blocks = blocks; } } }}