[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Philip Mundt)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Mundt updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Philip Mundt  
 
 
Story Points: 
 2 3  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Philip Mundt)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Mundt updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Philip Mundt  
 
 
Sprint: 
 Basel 94, Basel 95, Basel 96 , Basel 97  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Philip Mundt)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Philip Mundt updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Philip Mundt  
 
 
Sprint: 
 Basel 94, Basel 95 , Basel 96  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 

  
 
 
 
 

 
 Before saving to JCR  {{JcrNewNodeAdapter#isNew}}  currently  returns  always  {{true}}  (hardcoded), even after the first successful save . Saving to JCR doesn't necessarily mean that e.g. an app (or subapp) is done with the adapter, therefore, after the first save, subsequent calls to {{JcrNewNodeAdapter#isNew}} should return {{false}} in order to avoid incorrect or unexpected  behaviour in code relying on that method. To the objection that changing the behaviour of {{JcrNewNodeAdapter#isNew}} now may cause unexpected behaviour in code relying on the fact that it always returns {{true}}  we  one  could reply by saying that we would just make the method honour its semantics as per javadoc at {{info.magnolia.ui.vaadin.integration.ItemAdapter#isNew}}  {code}@return true if it's a new Item (not already persisted).{code}which basically is the same as {{javax.jcr.Item#isNew}}{code}Returns true if this is a new item, meaning that it existsonly in transient storage on the Session and has not yet been saved.{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 

  
 
 
 
 

 
 A more correct way Before saving  to  reflect the actual status of a  JCR  {{JcrNewNodeAdapter #isNew }}  would be to return the reverse value of the  returns  {{ appliedChanges}} field. That is initially {{false}} but becomes {{ true}}  as soon as the new node is saved to JCR . Saving to JCR doesn't necessarily mean that e.g. an app (or subapp) is done with the adapter, therefore, after the first save, subsequent calls to {{JcrNewNodeAdapter#isNew}} should return {{false}} in order to avoid incorrect or unexpected  behaviour in code relying on that method. To the objection that changing the behaviour of {{JcrNewNodeAdapter#isNew}} now may cause unexpected behaviour in code relying on the fact that it always returns {{true}} we could reply by saying that we would just make the method honour its semantics as per javadoc at {{info.magnolia.ui.vaadin.integration.ItemAdapter#isNew}}  {code}@return true if it's a new Item (not already persisted).{code}which basically is the same as {{javax.jcr.Item#isNew}}{code}Returns true if this is a new item, meaning that it existsonly in transient storage on the Session and has not yet been saved.{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

  

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 

  
 
 
 
 

 
 A more correct way to reflect the actual status of a {{JcrNewNodeAdapter}} would be to return the reverse value of the {{appliedChanges}} field. That is initially {{false}} but becomes {{true}} as soon as the new node is saved to JCR. Saving to JCR doesn't necessarily mean that e.g. an app (or subapp) is done with the adapter, therefore, after the first save, subsequent calls to {{JcrNewNodeAdapter#isNew}} should return {{false}} in order to avoid incorrect or unexpected  behaviour in code relying on that method. To the objection that changing the behaviour of {{JcrNewNodeAdapter#isNew}} now may cause unexpected behaviour in code relying on the fact that it always returns {{true}} we could reply by saying that we would just make the method honour its semantics as per javadoc at {{info.magnolia.ui.vaadin.integration.ItemAdapter#isNew}}  {code}@return true if it's a new Item (not already persisted).{code}which basically is the same as {{javax.jcr.Item#isNew}}{code}Returns true if this is a new item, meaning that it existsonly in transient storage on the   Session   and has not yet been saved.{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
 

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 

  
 
 
 
 

 
 A more correct way to reflect the actual status of a {{JcrNewNodeAdapter}} would be to return the reverse value of the {{appliedChanges}} field. That is initially {{false}} but becomes {{true}} as soon as the new node is saved to JCR. Saving to JCR doesn't necessarily mean that e.g. an app (or subapp) is done with the adapter, therefore, after the first save, subsequent calls to {{JcrNewNodeAdapter#isNew}} should return {{false}} in order to avoid incorrect or unexpected  behaviour in code relying on that method. To the objection that changing the behaviour of {{JcrNewNodeAdapter#isNew}} now may cause unexpected behaviour in code relying on the fact that it always returns {{true}} we could reply by saying that we would just make the method honour its semantics as per javadoc at {{info.magnolia.ui.vaadin.integration.ItemAdapter#isNew}}  { quote code }@return true if it's a new Item (not already persisted).{ quote code } which basically is the same as {{javax.jcr.Item#isNew}}{code}Returns true if this is a new item, meaning that it existsonly in transient storage on the Session and has not yet been saved.{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

  

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Fix Version/s: 
 5.5.5  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Comment: 
 Looking closer when changes are applied the node isn't persisted yet, rather it's added to its parent (which does exist in JCR) but  it's only transient in the current JCR session. Only {{session.save()}} will persist it to JCR. So I'm afraid we can't do this without changing the meaning of {{new}} in this context (sadpanda).   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[on behalf of Michael Mühlebach]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Mühlebach updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Michael Mühlebach  
 
 
Sprint: 
 Basel 94 , Basel 95  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 

  
 
 
 
 

 
 A more correct way to reflect the actual status of a {{JcrNewNodeAdapter}} would be to return the reverse value of the {{appliedChanges}} field. That is initially {{false}} but becomes {{true}} as soon as the new node is saved to JCR. Saving to JCR doesn't necessarily mean that e.g. an app (or subapp) is done with the adapter, therefore, after the first save, subsequent calls to {{JcrNewNodeAdapter#isNew}} should return {{false}} in order to avoid incorrect or unexpected  behaviour in code relying on that method.To the objection that changing the behaviour of {{JcrNewNodeAdapter#isNew}} now may cause unexpected behaviour in code relying on the fact that it always returns {{true}} we could reply by saying that we would just make the method honour its semantics as per javadoc at {{info.magnolia.ui.vaadin.integration.ItemAdapter#isNew}}  {quote}@return true if it's a new Item (not already persisted).{quote}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
   

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 

  
 
 
 
 

 
 A more correct way to reflect the actual status of a {{JcrNewNodeAdapter}} would be to return the  reverse  value of the {{appliedChanges}} field. That is initially {{false}} but becomes {{true}} as soon as the new node is saved to JCR. Saving to JCR doesn't necessarily mean that e.g. an app (or subapp) is done with the adapter, therefore, after the first save, subsequent calls to {{JcrNewNodeAdapter#isNew}} should return {{false}} in order to avoid incorrect or unexpected  behaviour in code relying on that method.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Release notes required: 
 Yes  
 
 
Story Points: 
 2  
 
 
Sprint: 
 Basel 94  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Assignee: 
 Federico Grilli  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLUI-4203) JcrNewNodeAdapter#isNew should not return hardcoded true

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia UI /  MGNLUI-4203  
 
 
  JcrNewNodeAdapter#isNew should not return hardcoded true
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Summary: 
 JcrNewNodeAdapter#isNew should not return hardcoded  false  true
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: