[magnolia-dev] [JIRA] (MGNLUI-3945) Jump to next error doesn't work with tab has 1 field
Title: Message Title Sang Ngo Huu updated an issue Magnolia UI / MGNLUI-3945 Jump to next error doesn't work with tab has 1 field Change By: Sang Ngo Huu Sprint: Saigon 91 , Saigon 92 Add Comment This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3945) Jump to next error doesn't work with tab has 1 field
Title: Message Title Ngoc Nguyenthanh updated an issue Magnolia UI / MGNLUI-3945 Jump to next error doesn't work with tab has 1 field Change By: Ngoc Nguyenthanh Original Estimate: 0.5h Remaining Estimate: 0.5h Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3945) Jump to next error doesn't work with tab has 1 field
Title: Message Title Ngoc Nguyenthanh updated an issue Magnolia UI / MGNLUI-3945 Jump to next error doesn't work with tab has 1 field Change By: Ngoc Nguyenthanh Fix Version/s: 5.5.4 Add Comment This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3945) Jump to next error doesn't work with tab has 1 field
Title: Message Title Ngoc Nguyenthanh updated an issue Magnolia UI / MGNLUI-3945 Jump to next error doesn't work with tab has 1 field Change By: Ngoc Nguyenthanh Sprint: Saigon 91 Add Comment This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3945) Jump to next error doesn't work with tab has 1 field
Title: Message Title Ngoc Nguyenthanh updated an issue Magnolia UI / MGNLUI-3945 Jump to next error doesn't work with tab has 1 field Change By: Ngoc Nguyenthanh Assignee: Ngoc Nguyenthanh Add Comment This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf) For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html Alternatively, use our forums: http://forum.magnolia-cms.com/ To unsubscribe, E-mail to:
[magnolia-dev] [JIRA] (MGNLUI-3945) Jump to next error doesn't work with tab has 1 field
Title: Message Title Oanh Thai Hoang updated an issue Magnolia UI / MGNLUI-3945 Jump to next error doesn't work with tab has 1 field Change By: Oanh Thai Hoang *Step to reproduce*:- Prepare 1 dialog definition has 3 tabs that the second and the third tab has only 1 required field. [^dialog-show-all.png]- Open that dialog- Doesn't need to input anything and click Save button*Output*: Can see the correct error number but clicking to "Jump to next error" doesn't jump any where [^clicking-to-jump-to-next-error-but-nothing-happens.png] even the second tab and the third tab has error [^second-tab-error.png][^third-tab-error.png]*Problem*: comes from {{FormSection.getNextProblematicField(Connector) }} function{code}public Component getNextProblematicField(Connector currentFocused) {int startIndex = components.indexOf(currentFocused) + 1;if (startIndex < components.size() - 1) {while (startIndex < components.size()) {Component c = components.get(startIndex++);if (c instanceof AbstractField && !((AbstractField) c).isValid()) {return c;}}}return null;}{code}The if condition {{if (startIndex < components.size() - 1)}} is incorrect for the case: tab has only one field. startIndex is 0 and (components.size() - 1) is 0 also. So can't find the invalid component as expected Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see:
[magnolia-dev] [JIRA] (MGNLUI-3945) Jump to next error doesn't work with tab has 1 field
Title: Message Title Oanh Thai Hoang updated an issue Magnolia UI / MGNLUI-3945 Jump to next error doesn't work with tab has 1 field Change By: Oanh Thai Hoang *Step to reproduce*:- Prepare 1 dialog definition has 3 tabs that the second and the third tab has only 1 required field. [^dialog-show-all.png]- Open that dialog- Doesn't need to input anything and click Save button*Output*: Can see the correct error number but clicking to "Jump to next error" doesn't jump any where [^clicking-to-jump-to-next-error-but-nothing-happens.png] even the second tab and the third tab has error [^second-tab-error.png][^third-tab-error.png]*Problem*: comes from {{FormSection.getNextProblematicField(Connector)}}function{code}public Component getNextProblematicField(Connector currentFocused) {int startIndex = components.indexOf(currentFocused) + 1;if (startIndex < components.size() - 1) {while (startIndex < components.size()) {Component c = components.get(startIndex++);if (c instanceof AbstractField && !((AbstractField) c).isValid()) {return c;}}}return null;}{code}The if condition {{if (startIndex < components.size() - 1)} } is incorrect for the case: tab has only one field. startIndex is 0 and (components.size() - 1) is 0 also. So can't find the invalid component as expected Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see:
[magnolia-dev] [JIRA] (MGNLUI-3945) Jump to next error doesn't work with tab has 1 field
Title: Message Title Oanh Thai Hoang updated an issue Magnolia UI / MGNLUI-3945 Jump to next error doesn't work with tab has 1 field Change By: Oanh Thai Hoang *Step to reproduce*:- Prepare 1 dialog definition has 3 tabs that the second and the third tab has only 1 required field. [^dialog-show-all.png]- Open that dialog- Doesn't need to input anything and click Save button*Output*: Can see the correct error number but clicking to "Jump to next error" doesn't jump any where [^clicking-to-jump-to-next-error-but-nothing-happens.png] even the second tab and the third tab has error [^second-tab-error.png][^third-tab-error.png]*Problem*: comes from {{ FormSection.getNextProblematicField(Connector) }} function{code}public Component getNextProblematicField(Connector currentFocused) {int startIndex = components.indexOf(currentFocused) + 1;if (startIndex < components.size() - 1) {while (startIndex < components.size()) {Component c = components.get(startIndex++);if (c instanceof AbstractField && !((AbstractField) c).isValid()) {return c;}}}return null;}{code}The if condition {{if (startIndex < components.size() - 1)}} is incorrect for the case: tab has only one field. startIndex is 0 and (components.size() - 1) is 0 also. So can't find the invalid component as expected Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see:
[magnolia-dev] [JIRA] (MGNLUI-3945) Jump to next error doesn't work with tab has 1 field
Title: Message Title Oanh Thai Hoang updated an issue Magnolia UI / MGNLUI-3945 Jump to next error doesn't work with tab has 1 field Change By: Oanh Thai Hoang *Step to reproduce*:- Prepare 1 dialog definition has 3 tabs that the second and the third tab has only 1 required field. [^dialog-show-all.png]- Open that dialog- Doesn't need to input anything and click Save button*Output*: Can see the correct error number but clicking to "Jump to next error" doesn't jump any where [^clicking-to-jump-to-next-error-but-nothing-happens.png] even the second tab and the third tab has error [^second-tab-error.png][^third-tab-error.png]*Problem*: comes from {{FormSection.getNextProblematicField(Connector) ) }} function{code}public Component getNextProblematicField(Connector currentFocused) {int startIndex = components.indexOf(currentFocused) + 1;if (startIndex < components.size() - 1) {while (startIndex < components.size()) {Component c = components.get(startIndex++);if (c instanceof AbstractField && !((AbstractField) c).isValid()) {return c;}}}return null;}{code}The if condition {{if (startIndex < components.size() - 1)} is incorrect for the case: tab has only one field. startIndex is 0 and (components.size() - 1) is 0 also. So can't find the invalid component as expected Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) For list details, see:
[magnolia-dev] [JIRA] (MGNLUI-3945) Jump to next error doesn't work with tab has 1 field
Title: Message Title Oanh Thai Hoang created an issue Magnolia UI / MGNLUI-3945 Jump to next error doesn't work with tab has 1 field Issue Type: Bug Affects Versions: 5.4.7 Assignee: Unassigned Attachments: clicking-to-jump-to-next-error-but-nothing-happens.png, dialog-show-all.png, second-tab-error.png, third-tab-error.png Created: 12/Jul/16 10:39 AM Priority: Neutral Reporter: Oanh Thai Hoang Security Level: Public Step to reproduce: Prepare 1 dialog definition has 3 tabs that the second and the third tab has only 1 required field. dialog-show-all.png Open that dialog