[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Labels: 
 blocked  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Fix Version/s: 
 5.5.6  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Labels: 
 blocked  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[on behalf of Michael Mühlebach]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Mühlebach updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Michael Mühlebach  
 
 
Sprint: 
 Basel 101 , Basel 102  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Story Points: 
 3  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 

  
 
 
 
 

 
 *Steps to reproduce:*# Make some changes to the pages and submit for publish. (Req1)# Again submit the same page for publish without making any changes. (req2)# Now make another change on a different component in the same page and submit for approval. (Res 3)# Check the notifications tab and you can see 3 requests for approval for the same page.# Now click on Req1 and say show changes.*Expected:*The changes made first should only be displayed.*Actual:*Changes made as part of third request is highlighted as the changes. So the approver cannot actually know what has been changed in this version and in the next versions.-After a bit of investigation the problem seems to be at {{info.magnolia.module.workflow.action.WorkItemLocalizedDiffAction#getLocation}} #61 et seq. The diff URL is built there always starting from the last version and comparing it with the previous one. No matter how many versions you have in there the last two are compared.  Solution consists in comparing the version created with a given publication request with its previous version, if one exists.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
  

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Fix Version/s: 
 5.6.4  
 
 
Fix Version/s: 
 5.5.6  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Sprint: 
 Basel 101  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 

  
 
 
 
 

 
 *Steps to reproduce:*# Make some changes to the pages and submit for publish. (Req1)# Again submit the same page for publish without making any changes. (req2)# Now make another change on a different component in the same page and submit for approval. (Res 3)# Check the notifications tab and you can see 3 requests for approval for the same page.# Now click on Req1 and say show changes.*Expected:*The changes made first should only be displayed.*Actual:*Changes made as part of third request is highlighted as the changes. So the approver cannot actually know what has been changed in this version and in the next versions. -After a bit of investigation the problem seems to be at {{info.magnolia.module.workflow.action.WorkItemLocalizedDiffAction#getLocation}} #61 et seq. The diff URL is built there always starting from the last version and comparing it with the previous one. No matter how many versions you have in there the last two are compared.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 
 

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Comment: 
 A comment with security level 'magnolia-intl-staff' was removed.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Assignee: 
 Federico Grilli  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Component/s: 
 Base  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: 

[magnolia-dev] [JIRA] (MGNLWORKFLOW-353) Incorrect displaying of the changes when comparing versions

[JIRA (on behalf of Federico Grilli)]

Title: Message Title


 
 
 
 

 
 
 

 
   
 Federico Grilli updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Magnolia Workflow Module /  MGNLWORKFLOW-353  
 
 
  Incorrect displaying of the changes when comparing versions   
 

  
 
 
 
 

 
Change By: 
 Federico Grilli  
 
 
Summary: 
 Incorrect displaying of the changes  when comparing versions  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.2.6#72008-sha1:26175bf)  
 
 

 
   
 

  
 

  
 

   




For list details, see: http://www.magnolia-cms.com/community/mailing-lists.html
Alternatively, use our forums: http://forum.magnolia-cms.com/
To unsubscribe, E-mail to: