New MFBT features: enum underlying type and enum classes

2012-08-09 Thread Aryeh Gregor
Support just landed for two new C++11 features in MFBT: https://bugzilla.mozilla.org/show_bug.cgi?id=751554 They're described in this paper: http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2007/n2347.pdf In brief, this lets you do two new things. One is you can use MOZ_ENUM_TYPE() to

Re: New MFBT features: enum underlying type and enum classes

2012-08-09 Thread Aryeh Gregor
On Thursday, August 9, 2012 3:05:56 PM UTC+3, Ted Mielczarek wrote: Did you mean VC++ 2010 or 2012? There's no version called 2011. (VC 2010 is VC 10.0, and VC 2012 is VC 11.0, confusingly.) I meant Visual Studio 11, based on this:

Re: New MFBT features: enum underlying type and enum classes

2012-08-09 Thread David Rajchenbach-Teller
On 8/9/12 11:29 AM, Aryeh Gregor wrote: The other is to define enum classes, a.k.a. strongly-typed or scoped enumerations. This is done as follows: [...] That sounds great! Perhaps, at some point, we will want to adapt xpidl to take advantage of this. Also, with this new feature, should we

Switching to stdint types on mozilla-central

2012-08-09 Thread Ehsan Akhgari
Hello everybody, We have had a long history of using NSPR types such as PRInt32 everywhere on mozilla-central. This is no longer necessary as we have decent support for stdint types in mozilla/StandardInteger.h. I have a series of patches up for review on bug 579517 which switch us away

Re: Switching to stdint types on mozilla-central

2012-08-09 Thread Ehsan Akhgari
...and I forgot to include the list! PRInt8 - int8_t PRUint8 - uint8_t PRInt16 - int16_t PRUint16 - uint16_t PRInt32 - int32_t PRUint32 - uint32_t PRInt64 - int64_t PRUint64 - uint64_t PRIntn - int32_t PRUintn - uint32_t PRSize - size_t PROffset32 - int32_t PROffset64 - int64_t PRPtrdiff -

Re: Switching to stdint types on mozilla-central

2012-08-09 Thread Mike Hommey
On Thu, Aug 09, 2012 at 12:26:33PM -0400, Justin Lebar wrote: This will however bitrot most of your patches, so I have put together a script here https://bugzilla.mozilla.org/attachment.cgi?id=650572 which helps you unbitrot them. This script handles mq patches, and needs to be run in the

Re: Increase in mozilla-inbound bustage due to people not using Try

2012-08-09 Thread Justin Wood (Callek)
Justin Lebar wrote: In addition, please bear in mind that landing bustage on trunk trees actually makes the Try wait times worse (since the trunk backouts/retriggers take test job priority over Try) - leading to others not bothering to use Try either, and so the situation cascades. I thought