Re: Proposal for an inbound2 branch

2013-05-04 Thread Justin Dolske
On 5/1/13 8:41 PM, Ehsan Akhgari wrote: Another disadvantage of project branches in addition to the ones mentioned before is that it limits/delays the amount of testing that you can get on Nightly and from all of the developers who run things like fuzzers on ours code. Not everyone's project has

Re: Accelerating exact rooting work

2013-05-04 Thread Boris Zbarsky
On 5/4/13 3:43 PM, Ehsan Akhgari wrote: As far as I can tell they seem to map to mozilla::ErrorResult values being used in some contexts. Should we just ignore them? Yes. ErrorResult has a union which sometimes contains a JS::Value (which it then manually roots) and the analysis was confused

Re: Accelerating exact rooting work

2013-05-04 Thread Tom Schuster
You can ignore unnecessary roots. They don't hurt us right now and we can fix them after everything else is done. On Sat, May 4, 2013 at 9:43 PM, Ehsan Akhgari wrote: > There are a ton of messages in that list of the following form: > > Function 'foo' has unnecessary root 'bar' in 'baz.cpp:123' >

Re: Accelerating exact rooting work

2013-05-04 Thread Ehsan Akhgari
There are a ton of messages in that list of the following form: Function 'foo' has unnecessary root 'bar' in 'baz.cpp:123' As far as I can tell they seem to map to mozilla::ErrorResult values being used in some contexts. Should we just ignore them? Ehsan On 2013-05-04 12:56 PM, Boris Zbarsk

Re: Accelerating exact rooting work

2013-05-04 Thread Boris Zbarsky
On 4/23/13 11:18 AM, Ehsan Akhgari wrote: Can the stuff in objdir/dom/bindings be fixed whole-sale by changing the WebIDL codegen? This is nearly done: we're down to the issues in bug 868715, which largely affect the js-implemented codegen at the moment, and the problem of what to do with Typ

Re: smartmake-like functionality has landed in mach

2013-05-04 Thread Neil
Gregory Szorc wrote: On 5/3/2013 11:19 AM, Reuben Morais wrote: You can also use |ac_add_options --with-chrome-format=symlink| to do something similar for the chrome JAR, it doesn't work with stuff that is preprocessed, but greatly reduces the number of files that require rebuildling browser