Re: proposal to use JS GC Handle/Rooted typedefs everywhere

2013-09-18 Thread Nicholas Nethercote
On Wed, Sep 18, 2013 at 12:55 PM, Luke Wagner wrote: > So, can we agree to use the typedefs all over Gecko? And note that js/public/TypeDecls.h (included with |#include "js/TypeDecls.h") has the most common of these typedefs in one convenient location. Nick

Add-ons Firefox 24 crash due to recent change in JSAPI

2013-09-18 Thread vasuyadavkrishn
Hi We are facing problem with our Add-ons support for FireFox 24.Firefox is crashing. In earlier approach we was using 'JS_GetGlobalObject' to get global object from docShell. https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/JSAPI_reference/JS_GetGlobalObject?redirectloca

Re: Logging of "quality events"

2013-09-18 Thread Nicholas Nethercote
> Does anyone know of prior art that we could apply to this problem, or > suggestions for how to implement this kind of logging safely, correctly, and > efficiently? It's possible that the system will need to be different across > platforms, using a logging service on B2G, some kind of native loggi

Re: Should the "Prevent this page from creating additional dialogs" checkbox prevent the page from creating any additional dialogs?

2013-09-18 Thread Mark Hammond
On 18/09/2013 8:06 AM, Tim Abraldes wrote: This is a re-post from firefox-dev [3], in case anyone in dev-platform is aware of historical context. Please follow-up here in dev.platform (I think it's easier for users/mail-clients to jump into a newsgroup discussion than a mailing list discussion)

Re: underflow event firing for overflowed content

2013-09-18 Thread Neil
Georg Fritzsche wrote: Now the underflow event is fired, but #inner is actually still overflowing in the other dimension. What's the detail of the event? -- Warning: May contain traces of nuts. ___ dev-platform mailing list dev-platform@lists.moz

Re: Logging of "quality events"

2013-09-18 Thread Chris Hofmann
> suggestions for other types of error log events that should be include in this system On 9/18/13 1:52 PM, Benjamin Smedberg wrote: hangs while running we should try to get a bit more pre-emptive and detailed about this kind of event. It would be great if I could look at a real-time hea

Logging of "quality events"

2013-09-18 Thread Benjamin Smedberg
Right now our stability efforts are primarily focused on crashes. However, as we have been very successful at reducing our crash rate, some other stability issues which are not crashes have come to be more prominent. Some examples: * very slow startup * very slow/hung shutdown * hangs while ru

Re: proposal to use JS GC Handle/Rooted typedefs everywhere

2013-09-18 Thread Bobby Holley
On Wed, Sep 18, 2013 at 12:55 PM, Luke Wagner wrote: > Given that the JS engine has the official style of "use the typedefs", it > seems like a shame for Gecko to use a different style; while the difference > may > be insignificant, we do strive for consistency. So, can we agree to use the > t

Re: proposal to use JS GC Handle/Rooted typedefs everywhere

2013-09-18 Thread smaug
On 09/18/2013 10:55 PM, Luke Wagner wrote: To save typing, the JS engine has typedefs like typedef Handle HandleObject; typedef Rooted RootedValue; and the official style is to prefer the HandleX/RootedX typedefs when there is no need to use the Handle/Rooted template-ids directly. This issue

proposal to use JS GC Handle/Rooted typedefs everywhere

2013-09-18 Thread Luke Wagner
To save typing, the JS engine has typedefs like typedef Handle HandleObject; typedef Rooted RootedValue; and the official style is to prefer the HandleX/RootedX typedefs when there is no need to use the Handle/Rooted template-ids directly. This issue was discussed off and on in the JS engine

Re: Python 2.7.3 now required to build

2013-09-18 Thread Gregory Szorc
This was backed out a few days after it landed because it was disrupting the Oslo B2G work. It just landed in inbound again. |mach bootstrap| is now more intelligent about detecting $PATH issues and telling you how to install a modern Python. While OS X should "just work," some manual work ma

Re: Should the "Prevent this page from creating additional dialogs" checkbox prevent the page from creating any additional dialogs?

2013-09-18 Thread N. S. S.
It doesn't seem like the timing was part of that bug. Initially, when I was involved at least, the timing was used to set mDialogAbuseCount so that we could track if there was an abuse at all. Once the abuse count was hit, we prompted the user and, if the user so chose, disabled dialogs for the dur

proposal: removing talos dirty tests

2013-09-18 Thread jmaher
One of my goals is to review all the talos tests for accuracy and usefulness. It came to my attention earlier this summer that the dirty tests (tspaint_places_generated_med, tspaint_places_generated_max) are outdated and providing little to no value. After investigating these tests in more deta

underflow event firing for overflowed content

2013-09-18 Thread Georg Fritzsche
I noticed that the underflow event [1] can fire when the content still overflows, by having it underflow in one dimension. While i can guard against this in the event handler, does anyone know if this is a bug or intended behaviour? STR: * http://jsfiddle.net/LbbJw/11/ * click "Shrink" -> overflow

Re: Should the "Prevent this page from creating additional dialogs" checkbox prevent the page from creating any additional dialogs?

2013-09-18 Thread Gavin Sharp
I remember discovering some of this confusing behavior while working on bug 391834. It dates back to bug 61098, and following the reasoning from those bug comments is a bit tricky. jst or Natch might recall the details, but I doubt it :) I wouldn't really assume that there's some great reason for

Re: XBL cache?

2013-09-18 Thread Neil
Neil wrote: I'm trying to debug some XBL and the remote debugger isn't working due to bug 914930. Having updated to a version pre bug 914930 I've now got remote debugging working and figured out what my problem is (wrong XBL file...) -- Warning: May contain traces of nuts. _