Intent to ship: Gamepad API

2013-12-06 Thread Ted Mielczarek
As of Firefox 28 I intend to turn the Gamepad API on by default (on desktop Firefox). It has been developed behind the dom.gamepad.enabled preference, and shipped preffed-off in Firefox 24. Google has shipped a prefixed but mostly-compatible implementation in Chrome for multiple releases now.

Re: Intent to ship: Gamepad API

2013-12-06 Thread Ehsan Akhgari
Thanks for posting this, Ted! What is the dom.gamepad.non_standard_events.enabled controlling, and why do we have a different value of this pref in our release and non-release builds? Thanks! Ehsan On 12/6/2013, 7:47 AM, Ted Mielczarek wrote: As of Firefox 28 I intend to turn the Gamepad

Re: Intent to ship: Gamepad API

2013-12-06 Thread Ted Mielczarek
On 12/6/2013 11:33 AM, Ehsan Akhgari wrote: Thanks for posting this, Ted! What is the dom.gamepad.non_standard_events.enabled controlling, and why do we have a different value of this pref in our release and non-release builds? That pref controls whether we send gamepadbutton{up,down} and

Re: Intent to ship: Gamepad API

2013-12-06 Thread Ehsan Akhgari
On 12/6/2013, 11:43 AM, Ted Mielczarek wrote: On 12/6/2013 11:33 AM, Ehsan Akhgari wrote: Thanks for posting this, Ted! What is the dom.gamepad.non_standard_events.enabled controlling, and why do we have a different value of this pref in our release and non-release builds? That pref

Re: NSPR logging dropping log messages

2013-12-06 Thread Ehsan Akhgari
On 12/6/2013, 11:59 AM, Honza Bambas wrote: On 12/6/2013 5:31 PM, Ehsan Akhgari wrote: Can you please file a bug about this so that we can try to get this patch landed? WTC recently indicated to me (in https://bugzilla.mozilla.org/show_bug.cgi?id=941854#c10) that we should probably start

Re: NSPR logging dropping log messages

2013-12-06 Thread Honza Bambas
On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the right place to do that. Cheers, Ehsan My patch is probably not something that should

Re: NSPR logging dropping log messages

2013-12-06 Thread Ehsan Akhgari
On 12/6/2013, 1:19 PM, Honza Bambas wrote: On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the right place to do that. Cheers, Ehsan My

Re: NSPR logging dropping log messages

2013-12-06 Thread Honza Bambas
On 12/6/2013 7:24 PM, Ehsan Akhgari wrote: On 12/6/2013, 1:19 PM, Honza Bambas wrote: On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the

Re: NSPR logging dropping log messages

2013-12-06 Thread Ehsan Akhgari
On 12/6/2013, 1:33 PM, Honza Bambas wrote: On 12/6/2013 7:24 PM, Ehsan Akhgari wrote: On 12/6/2013, 1:19 PM, Honza Bambas wrote: On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think

Re: Intent to ship: Gamepad API

2013-12-06 Thread Ehsan Akhgari
On 12/6/2013, 12:00 PM, Ehsan Akhgari wrote: On 12/6/2013, 11:43 AM, Ted Mielczarek wrote: On 12/6/2013 11:33 AM, Ehsan Akhgari wrote: Thanks for posting this, Ted! What is the dom.gamepad.non_standard_events.enabled controlling, and why do we have a different value of this pref in our