Re: Controlling font size as per system DPI in Windows

2014-04-02 Thread bhargava . animesh29
On Tuesday, April 1, 2014 5:56:53 PM UTC+5:30, Jonathan Kew wrote: Hi, We have a property in greprefs.js layout.css.dpi by which we can control pixel size , but this doesn't work in Windows. There is another property layout.css.devPixelsPerPx which control font size in

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Neil
Ehsan Akhgari wrote: On 2014-04-01, 8:10 PM, Martin Thomson wrote: count_type tmp = --mRefCnt; if (tmp == 0) { delete this; } And how do we enforce people to write code like the above example using the current Atomic interface? Would WARN_UNUSED_RESULT help here, so that you remember

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Nicolas B. Pierron
On 04/01/2014 02:32 PM, Ehsan Akhgari wrote: The summary is that I think the mozilla::Atomic API which is modeled after std::atomic is harmful in that it makes it very non-obvious that you're dealing with atomic integers. Basically the existing interface makes mozilla::Atomic look like a normal

Web APIs documentation meeting Friday at 9 AM PDT

2014-04-02 Thread Eric Shepherd
The Web API documentation meeting is Friday at 9 AM Pacific Time. Everyone's welcome to attend; if you're interested in ensuring that these APIs are properly documented, we'd love your input. We have an agenda, as well as details on how to join, here:

Re: Enable -Wswitch-enum? [was Re: MOZ_ASSUME_UNREACHABLE is being misused]

2014-04-02 Thread Aryeh Gregor
On Tue, Apr 1, 2014 at 5:56 PM, Zack Weinberg za...@panix.com wrote: The downside of turning this on would be that any switch statements that *deliberately* include only a subset of the enumerators, plus a default case, would now have to be expanded to cover all the enumerators. If there are

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Honza Bambas
On 4/2/2014 11:33 AM, Nicolas B. Pierron wrote: --lock(mRefCnt); if (lock(mRefCnt) == 0) { delete this; } This way, this is more obvious that we might not be doing the right things, as long as we are careful to refuse AtomicHandler references in reviews. I personally don't think this

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Trevor Saunders
On Wed, Apr 02, 2014 at 05:03:53PM +0200, Honza Bambas wrote: On 4/2/2014 11:33 AM, Nicolas B. Pierron wrote: --lock(mRefCnt); if (lock(mRefCnt) == 0) { delete this; } This way, this is more obvious that we might not be doing the right things, as long as we are careful to refuse

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Honza Bambas
On 4/2/2014 5:24 PM, Trevor Saunders wrote: On Wed, Apr 02, 2014 at 05:03:53PM +0200, Honza Bambas wrote: On 4/2/2014 11:33 AM, Nicolas B. Pierron wrote: --lock(mRefCnt); if (lock(mRefCnt) == 0) { delete this; } This way, this is more obvious that we might not be doing the right things, as

Re: Firefox build (Nightly) thread with root permission

2014-04-02 Thread Mike Hoye
On 2014-04-02, 1:46 AM, Paul wrote: I strongly suspect this happens due to the permission issue while Nightly does not allow me to gain root privileges. However, this is necessary for me to complete my experiment. How can I obtain a decent permission while I do this? strace -f should see

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Trevor Saunders
On Wed, Apr 02, 2014 at 05:37:39PM +0200, Honza Bambas wrote: On 4/2/2014 5:24 PM, Trevor Saunders wrote: On Wed, Apr 02, 2014 at 05:03:53PM +0200, Honza Bambas wrote: On 4/2/2014 11:33 AM, Nicolas B. Pierron wrote: --lock(mRefCnt); if (lock(mRefCnt) == 0) { delete this; } This way,

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Ehsan Akhgari
On 2014-04-02, 12:11 AM, Joshua Cranmer  wrote: On 4/1/2014 4:32 PM, Ehsan Akhgari wrote: So, over in bug 987887 I'm proposing to remove all of the methods on mozilla::Atomic except for copy construction and assignment and replace them with global functions that can operate on the atomic type.

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Ehsan Akhgari
On 2014-04-02, 11:03 AM, Honza Bambas wrote: On 4/2/2014 11:33 AM, Nicolas B. Pierron wrote: --lock(mRefCnt); if (lock(mRefCnt) == 0) { delete this; } This way, this is more obvious that we might not be doing the right things, as long as we are careful to refuse AtomicHandler references in

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Ehsan Akhgari
On 2014-04-02, 4:43 AM, Neil wrote: Ehsan Akhgari wrote: On 2014-04-01, 8:10 PM, Martin Thomson wrote: count_type tmp = --mRefCnt; if (tmp == 0) { delete this; } And how do we enforce people to write code like the above example using the current Atomic interface? Would

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Joshua Cranmer 
On 4/2/2014 3:52 PM, Ehsan Akhgari wrote: On 2014-04-02, 12:11 AM, Joshua Cranmer  wrote: On 4/1/2014 4:32 PM, Ehsan Akhgari wrote: So, over in bug 987887 I'm proposing to remove all of the methods on mozilla::Atomic except for copy construction and assignment and replace them with global

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Ehsan Akhgari
On Wed, Apr 2, 2014 at 5:29 PM, Joshua Cranmer  pidgeo...@gmail.comwrote: On 4/2/2014 3:52 PM, Ehsan Akhgari wrote: On 2014-04-02, 12:11 AM, Joshua Cranmer  wrote: On 4/1/2014 4:32 PM, Ehsan Akhgari wrote: So, over in bug 987887 I'm proposing to remove all of the methods on

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Martin Thomson
On 2014-04-02, at 14:01, Ehsan Akhgari ehsan.akhg...@gmail.com wrote: AtomicFetchAndSub(mRefCnt, -1); I think that I’ll join those who seem to favour member functions over statics, as you seem to prefer for some reason. If you want to avoid inventing names and such, how about copying from

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Benoit Jacob
2014-04-02 11:03 GMT-04:00 Honza Bambas honzab@firemni.cz: On 4/2/2014 11:33 AM, Nicolas B. Pierron wrote: --lock(mRefCnt); if (lock(mRefCnt) == 0) { delete this; } This way, this is more obvious that we might not be doing the right things, as long as we are careful to refuse

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Joshua Cranmer 
On 4/2/2014 5:30 PM, Ehsan Akhgari wrote: I have no reservations against making them member functions with a clear name that do not return T/T*/etc. I was trying to not be super inconsistent with std::atomic, but if you think that's ok, that's fine by me. std::atomic has the fetch_* methods

Gamepad API problems

2014-04-02 Thread Geoff Lankow
I'm trying to use a gamepad in Firefox on Ubuntu 13.10. It shows up fine in lsusb and jstest, but neither Firefox nor Chromium seem to see it. It seems like I'm missing a crucial package or something. Any ideas? My code works fine if I forward the USB device to a VM, but I don't want to have

Re: Gamepad API problems

2014-04-02 Thread Kevin Brosnan
Using a Mozilla build or the Ubuntu package? http://nightly.mozilla.org/ or http://www.mozilla.org/en-US/firefox/all/ Kevin On Apr 2, 2014 6:15 PM, Geoff Lankow ge...@darktrojan.net wrote: I'm trying to use a gamepad in Firefox on Ubuntu 13.10. It shows up fine in lsusb and jstest, but

Re: Gamepad API problems

2014-04-02 Thread Geoff Lankow
I've tried both, and also Firefox built on this machine. On 03/04/14 15:16, Kevin Brosnan wrote: Using a Mozilla build or the Ubuntu package? http://nightly.mozilla.org/ or http://www.mozilla.org/en-US/firefox/all/ Kevin On Apr 2, 2014 6:15 PM, Geoff Lankow ge...@darktrojan.net wrote: I'm