Re: The worst piece of Mozilla code

2014-10-20 Thread Gabriele Svelto
On 17/10/2014 00:32, Nicholas Nethercote wrote: Thanks for the replies so far! I deliberately left this question vague to see what kind of responses people would give. But mostly I'm interested in code whose awfulness impacts users in a serious way. Ones where refactoring/rewriting efforts

Re: Intent to Implement: webview

2014-10-20 Thread 陳侃如
Ehsan Akhgari ehsan.akhg...@gmail.com writes: On 2014-10-13, 10:35 PM, Kan-Ru Chen (陳侃如) wrote: Jonas Sicking jo...@sicking.cc writes: On Mon, Oct 13, 2014 at 4:36 PM, Kan-Ru Chen (陳侃如) kc...@mozilla.com wrote: Jonas Sicking jo...@sicking.cc writes: This will only be exposed to

Re: The worst piece of Mozilla code

2014-10-20 Thread Thomas Zimmermann
Hi, this mail made me laugh, because I can tell very similar stories with different examples. (Not sure if :) or :( ) On the positive side, I think we got a lot better since then by both, fixing broken designs and code, and also applying learned lessons to new sub-systems. Best regards Thomas

Test Informant Report - Week of Oct 12th

2014-10-20 Thread Andrew Halberstadt
Test Informant report for 2014-10-18. State of test manifests at revision 33c0181c4a25. Using revision f547cf19d104 as a baseline for comparisons. Showing tests enabled or disabled between 2014-10-12 and 2014-10-18. 86% of tests across all suites and configurations are enabled. Full Report

Re: Switching to Visual Studio 2013

2014-10-20 Thread Mike Hoye
On 2014-10-20 11:44 AM, Gijs Kruitbosch wrote: Hi, Can you or someone else in the know update https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Windows_Prerequisites and friends, Working on it. - mhoye ___ dev-platform

Re: Switching to Visual Studio 2013

2014-10-20 Thread Gijs Kruitbosch
Hi, Can you or someone else in the know update https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Windows_Prerequisites and friends, or (if you don't like wiki software, don't want to create an account, or have other reasons not to want to do this...) provide

Re: Switching to Visual Studio 2013

2014-10-20 Thread Ehsan Akhgari
On 2014-10-20 11:44 AM, Gijs Kruitbosch wrote: Hi, Can you or someone else in the know update https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Windows_Prerequisites and friends, or (if you don't like wiki software, don't want to create an account, or have other

Re: Switching to Visual Studio 2013

2014-10-20 Thread Gijs Kruitbosch
On 20/10/2014 16:56, Ehsan Akhgari wrote: On 2014-10-20 11:44 AM, Gijs Kruitbosch wrote: Hi, Can you or someone else in the know update https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Windows_Prerequisites and friends, or (if you don't like wiki software, don't

Re: Switching to Visual Studio 2013

2014-10-20 Thread Mike Hoye
On 2014-10-20 11:56 AM, Ehsan Akhgari wrote: On 2014-10-20 11:44 AM, Gijs Kruitbosch wrote: Hi, Can you or someone else in the know update https://developer.mozilla.org/en-US/docs/Developer_Guide/Build_Instructions/Windows_Prerequisites and friends, or (if you don't like wiki software,

Re: Switching to Visual Studio 2013

2014-10-20 Thread Stefan Sitter
Hi, are there plans to switch the Thunderbird builders from VS2010 to VS2013 as well? /Stefan On 14.10.2014 08:10, David Major wrote: VS2013 is now on inbound and all Windows builds are green. (Win64 builds were actually switched late last week, as they are unaffected by trains.) Please

Re: Compiler version expectations

2014-10-20 Thread Ehsan Akhgari
So I just spoke with Callek about his plans to move SeaMonkey off of their existing Windows 2003 builders that cannot install Visual Studio 2012 or newer, and it seems like Dec 15th is a date that will probably work fine for SM, and that is still within the Gecko 37 cycle. Jeff, can we hold off

Re: PSA: content/{base,html,media,svg,xul} will move to dom/

2014-10-20 Thread Robert O'Callahan
Hurrah! Rob -- oIo otoeololo oyooouo otohoaoto oaonoyooonoeo owohooo oioso oaonogoroyo owoiotoho oao oboroootohoeoro oooro osoiosotoeoro owoiololo oboeo osouobojoeocoto otooo ojouodogomoeonoto.o oAogoaoiono,o oaonoyooonoeo owohooo osoaoyoso otooo oao oboroootohoeoro oooro osoiosotoeoro,o

Re: Switching to Visual Studio 2013

2014-10-20 Thread Mike Hommey
On Mon, Oct 20, 2014 at 12:09:40PM -0400, Mike Hoye wrote: On 2014-10-20 11:56 AM, Ehsan Akhgari wrote: On 2014-10-20 11:44 AM, Gijs Kruitbosch wrote: Hi, Can you or someone else in the know update

Re: PSA: content/{base,html,media,svg,xul} will move to dom/

2014-10-20 Thread Nicholas Nethercote
On Mon, Oct 20, 2014 at 1:17 PM, Robert O'Callahan rob...@ocallahan.org wrote: Hurrah! Indeed. Thank you, Poiru, for all your work sanding down rough edges throughout the codebase. Nick ___ dev-platform mailing list dev-platform@lists.mozilla.org

About the bitfield requirement for portibility

2014-10-20 Thread Xidorn Quan
Hi, I read the C++ portibility guide [1], in which it is said that all bitfields should have the same type, or some compiler may mishandle the code. Is that still true for the compiler set we currently use? The compiler the doc mentioned is MSVC++8 which I believe we have dropped. Can we use

Re: About the bitfield requirement for portibility

2014-10-20 Thread David Major
Mixing types will likely produce unexpected and/or wasteful results. Examples at http://randomascii.wordpress.com/2010/06/06/bit-field-packing-with-visual-c/. I believe that is still true in VS2013. David - Original Message - From: Xidorn Quan quanxunz...@gmail.com To:

Re: About the bitfield requirement for portibility

2014-10-20 Thread Xidorn Quan
OK. I think it might worth a mention in that document that even the latest compiler by now may produce wasteful result. Xidorn On Tue, Oct 21, 2014 at 2:29 PM, David Major dma...@mozilla.com wrote: Mixing types will likely produce unexpected and/or wasteful results. Examples at