Re: Intent to implement and ship: document.origin

2015-03-18 Thread Boris Zbarsky
On 3/18/15 2:39 AM, Anne van Kesteren wrote: On Wed, Mar 18, 2015 at 1:09 AM, Jonas Sicking jo...@sicking.cc wrote: I think making the location object match URLUtils is futile. There's so much weirdness about the location object that I think we should treat it as the special flower that it is.

Re: Review problems

2015-03-18 Thread Kyle Huey
On Wed, Mar 18, 2015 at 8:39 AM, Gabor Krizsanits gkrizsan...@mozilla.com wrote: I think I'm not the only one experienced issues with reviews from one side or the other. I'm wondering if we could do some improvements here for everyone's sake. Here are the issues the way I see it: * some

Review problems

2015-03-18 Thread Gabor Krizsanits
I think I'm not the only one experienced issues with reviews from one side or the other. I'm wondering if we could do some improvements here for everyone's sake. Here are the issues the way I see it: * some parts of the code need more peers - we should identify the areas - we should select

Re: Review problems

2015-03-18 Thread Gavin Sharp
This is a difficult problem to discuss in the abstract. It should never be the case that you are waiting for weeks/months - you should either be getting reviews within a week (at worst), or be getting responses saying can't spend time reviewing this now. Where that is not happening, the

Intent to Ship: 3rd Party Install Tracking

2015-03-18 Thread Mark Finkle
We wanted to start some transparency around a new integration coming to Firefox on Mobile [1]. We are planning to integrate a 3rd party install tracking SDK from a company called Adjust [2] which will send data, possibly device identity data [3], to a 3rd party server. We don't do this very much

Re: Is anyone still using JS strict warnings?

2015-03-18 Thread bgrinstead
On Friday, December 19, 2014 at 12:19:11 PM UTC-8, Jason Orendorff wrote: So if you go to about:config and set the javascript.options.strict pref, you'll get warnings about accessing undefined properties. js Math.TAU undefined /!\ ReferenceError: reference to undefined property

Re: Intent to Ship: 3rd Party Install Tracking

2015-03-18 Thread kgupta
On Wednesday, March 18, 2015 at 2:29:32 PM UTC-4, Mark Finkle wrote: There are good reasons for wanting to collect the data. Our marketing and growth goals for 2015 will require spending non-trivial amounts of money. The data will help us spend the money responsibly and efficiently. We still

Re: Intent to Ship: 3rd Party Install Tracking

2015-03-18 Thread Mark Finkle
On Wed, Mar 18, 2015 at 2:49 PM, kgu...@mozilla.com wrote: It seems to me that when doing something as privacy sensitive as this we should probably figure out exactly what data we want to collect *first*. Then, if and only if we can't collect it using in-house code, we should consider going

Re: Intent to Ship: 3rd Party Install Tracking

2015-03-18 Thread Mark Finkle
On Wed, Mar 18, 2015 at 2:49 PM, kgu...@mozilla.com wrote: On Wednesday, March 18, 2015 at 2:29:32 PM UTC-4, Mark Finkle wrote: There are good reasons for wanting to collect the data. Our marketing and growth goals for 2015 will require spending non-trivial amounts of money. The data will

Re: Intent to implement and ship: document.origin

2015-03-18 Thread Anne van Kesteren
On Wed, Mar 18, 2015 at 1:09 AM, Jonas Sicking jo...@sicking.cc wrote: I think making the location object match URLUtils is futile. There's so much weirdness about the location object that I think we should treat it as the special flower that it is. Other than the location object tracking a