Re: Busy indicator API

2015-07-05 Thread Mike Connor
On 5 July 2015 at 11:53, Dirkjan Ochtman wrote: > On Sun, Jul 5, 2015 at 5:11 PM, Anne van Kesteren > wrote: > > Is there a reason we shouldn't expose a hook for this? > > On the one hand, this seems really useful. On the other hand, I'm > pretty worried about the UX implications here. I wouldn'

Re: Busy indicator API

2015-07-05 Thread smaug
On 07/05/2015 06:11 PM, Anne van Kesteren wrote: A while back there have been some requests from developers (seconded by those working on GitHub) to have an API to indicate whether a site is busy with one thing or another (e.g. networking). They'd like to use this to avoid having to create their

Better Test Case Coding for Reviewers

2015-07-05 Thread fantasai
[CCing m.d.platform, since it might be helpful for layout tests there, too.] I've been reviewing some tests lately, and there are three things that would help a lot in a correct and efficient review. #1: Good indentation. The contents of each block should be indented. It's much harder to re

Re: Busy indicator API

2015-07-05 Thread Anne van Kesteren
On Sun, Jul 5, 2015 at 6:21 PM, fantasai wrote: > On 07/05/2015 11:11 AM, Anne van Kesteren wrote: >> A while back there have been some requests from developers (seconded >> by those working on GitHub) to have an API to indicate whether a site >> is busy with one thing or another (e.g. networking)

Re: Busy indicator API

2015-07-05 Thread fantasai
On 07/05/2015 11:11 AM, Anne van Kesteren wrote: A while back there have been some requests from developers (seconded by those working on GitHub) to have an API to indicate whether a site is busy with one thing or another (e.g. networking). They'd like to use this to avoid having to create their

Re: Busy indicator API

2015-07-05 Thread Dirkjan Ochtman
On Sun, Jul 5, 2015 at 5:11 PM, Anne van Kesteren wrote: > Is there a reason we shouldn't expose a hook for this? On the one hand, this seems really useful. On the other hand, I'm pretty worried about the UX implications here. I wouldn't want a dozen flashing/spinning/moving things in my tab bar.

Busy indicator API

2015-07-05 Thread Anne van Kesteren
A while back there have been some requests from developers (seconded by those working on GitHub) to have an API to indicate whether a site is busy with one thing or another (e.g. networking). They'd like to use this to avoid having to create their own UI. In Firefox this could manifest itself by t

Re: mozilla::TemporaryRef is gone; please use already_AddRefed

2015-07-05 Thread Aryeh Gregor
On Fri, Jul 3, 2015 at 3:56 PM, Neil wrote: > Aryeh Gregor wrote: > >> we still want a new type for function parameters that accepts implicit >> conversions from nsRefPtr/nsCOMPtr, to use instead of raw pointers. >> > Sure, but that won't stop someone from writing Arg foo = ReturnFoo2(); > will it