MozReview now uses Bugzilla's auth delegation

2015-08-26 Thread Mark Côté
tl;dr We improved the authentication system in MozReview. Please log out (if necessary) and back into the MozReview UI (Review Board) before pushing any commits up for review. Today we deployed a change to MozReview's authentication system. Rather than logging into Review Board with your

Re: Intent to implement and ship

2015-08-26 Thread Ehsan Akhgari
On 2015-08-26 10:08 AM, Adam Roach wrote: On 8/26/15 08:36, Ehsan Akhgari wrote: Have you considered the implications of making the alias falsey in conditions, similar to document.all? The issue with doing so is that we see code in the wild that looks like this: |var NativeRTCPeerConnection

Arrow functions now have a lexical `arguments` binding

2015-08-26 Thread Jan De Mooij
Hi all, Yesterday I landed a patch to change how `arguments` works inside arrow functions [0]. `arguments` is now lexically bound (inherited from the outer function), similar to `this`. For example, the following function will now return 1 instead of 2: (function() { var f = () =

Re: Intent to implement and ship

2015-08-26 Thread Ehsan Akhgari
On 2015-08-25 5:45 PM, Martin Thomson wrote: Maybe some day we can remove the aliases by just backing out the patch that creates prefixed aliases, but that seems unlikely in the short term [1][2]. Do the aliases only work when you call them or can the webpage also detect them? IOW, what would

Re: Intent to implement and ship

2015-08-26 Thread Adam Roach
On 8/26/15 08:36, Ehsan Akhgari wrote: Have you considered the implications of making the alias falsey in conditions, similar to document.all? The issue with doing so is that we see code in the wild that looks like this: |var NativeRTCPeerConnection = (window.webkitRTCPeerConnection ||

Re: Intent to implement and ship

2015-08-26 Thread Ms2ger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/26/2015 03:36 PM, Ehsan Akhgari wrote: Hmm, I see. Have you considered the implications of making the alias falsey in conditions, similar to document.all? No. No. Nononononono. Ms2ger -BEGIN PGP SIGNATURE-