Re: Static analysis for "use-after-move"?

On Thu, Apr 28, 2016 at 8:22 PM, wrote: > Jim Blandy於 2016年4月28日星期四 UTC+8下午1時51分15秒寫道： > > I don't really think it's a good example. TakeMediaIfKnown is accepting a > > UniquePtr as an inout parameter: it uses, and may modify, its > > value. It should take UniquePtr &. >

Re: Static analysis for "use-after-move"?

Jim Blandy於 2016年4月28日星期四 UTC+8下午1時51分15秒寫道： > I don't really think it's a good example. TakeMediaIfKnown is accepting a > UniquePtr as an inout parameter: it uses, and may modify, its > value. It should take UniquePtr &. IIUC, UniquePtr can't be an inout parameter for its unique semantics which

NS_New*RunnableMethod* -> New*RunnableMethod

NS_NewRunnableMethod has been replaced with mozilla::NewRunnableMethod. NS_NewRunnableMethodWithArg[s] has also been collapsed into mozilla::NewRunnableMethod. It also now returns an already_AddRefed. The Chromium versions of these methods have been removed. NS_NewRunnableFunction still

Re: Intent to implement and ship: IIRFilterNode

Thanks for the replies, Dan and Roy. A first order filter node with AudioParam inputs seems a likely future addition AFAIK. Even with that though, having a way to apply a custom biquad without needing to decompose into multiple textbook filters is useful I think. And I agree that implementing

Intent to ship: Speech synthesis API

Hello, In Firefox 49 I intend to turn on the speech synthesis API on by default in desktop. For those paying close attention, this is not the first mail like this. Last time I turned it on in Nightly only to allow some fuzz testing. As of this writing there is one blocker we are tracking. All

Re: ICU proposing to drop support for WinXP (and OS X 10.6)

On 04/28/2016 10:00 AM, Jonathan Kew wrote: > Thoughts? Another option is to ship a WinXP-specific Firefox build that doesn't provide ICU and ECMAScript's Intl functionality. This would break anyone's expectation that any version of Firefox past the mid-30s somewhere has Intl available in it.

Re: ICU proposing to drop support for WinXP (and OS X 10.6)

On Thu, Apr 28, 2016 at 1:39 PM, Jonathan Kew wrote: > On 28/4/16 18:11, Jeff Muizelaar wrote: > >> Do we use any of the OS specific parts of ICU? >> > > I don't know. > > But even if we don't, I suspect that once they drop support for XP / 10.6, > it won't be long before the

Re: ICU proposing to drop support for WinXP (and OS X 10.6)

On 28/4/16 18:11, Jeff Muizelaar wrote: Do we use any of the OS specific parts of ICU? I don't know. But even if we don't, I suspect that once they drop support for XP / 10.6, it won't be long before the project as a whole becomes increasingly difficult to build for those targets, as it'll

Re: ICU proposing to drop support for WinXP (and OS X 10.6)

Do we use any of the OS specific parts of ICU? -Jeff On Thu, Apr 28, 2016 at 1:00 PM, Jonathan Kew wrote: > We make considerable (and growing) use of ICU for various aspects of i18n > support in Gecko.† > > The ICU project is proposing to drop support for Windows XP and OS

ICU proposing to drop support for WinXP (and OS X 10.6)

We make considerable (and growing) use of ICU for various aspects of i18n support in Gecko.† The ICU project is proposing to drop support for Windows XP and OS X 10.6 in version 58; I guess this will be released sometime shortly after Unicode 9.0, which is due to appear in June. Markus (in

Re: Intent to implement and ship: IIRFilterNode

On Wed, Apr 27, 2016 at 6:35 PM, Karl Tomlinson wrote: > Daniel Minor writes: > > > Summary: This provides an alternative to using BiquadFilterNode when > > odd-order filters are required or automation is not needed. It is part of > > the Web Audio spec and is already

Re: PSA: Cancel your old Try pushes

On 2016-04-26 05:54 PM, Mike Hommey wrote: On Tue, Apr 26, 2016 at 03:49:11PM +0200, Gabor Krizsanits wrote: As someone who was high on the list of try server usage for two weeks My problem was a test I tried to fix for both e10s and non-e10s, and it timed out _sometimes_ on _some_

Re: Static analysis for "use-after-move"?

Xidorn Quan writes: > I think this specific case should actually use UniquePtr& rather > than && in parameter for conditional move, so that callsite can only pass > in an lvalue, and we don't need a Move there. Jim Blandy writes: > TakeMediaIfKnown is accepting a > UniquePtr as an inout