Re: Checkin-needed requests - Please include complete information in the commit message :)

2016-07-10 Thread Xidorn Quan
On Mon, Jul 11, 2016, at 04:26 PM, Martin Thomson wrote: > On Mon, Jul 11, 2016 at 2:18 PM, Xidorn Quan wrote: > > I also use checkin-needed for small changes which I don't think it's > > worth to run a full testset for, to save some infra resources. > > Hmm, that's an odd optimization. I'd have

Re: Checkin-needed requests - Please include complete information in the commit message :)

2016-07-10 Thread Martin Thomson
On Mon, Jul 11, 2016 at 2:18 PM, Xidorn Quan wrote: > Isn't it still necessary for people who don't yet have permission to > push? That suggests to me that there are missing safeguards on autoland. Otherwise we could just enable it even for those with try access. > I also use checkin-needed for

Re: Checkin-needed requests - Please include complete information in the commit message :)

2016-07-10 Thread Nils Ohlmeier
> On Jul 10, 2016, at 21:18, Xidorn Quan wrote: > > On Mon, Jul 11, 2016, at 12:29 PM, Martin Thomson wrote: >> Is now the right time to start talking about retiring checkin-needed, >> or is it still heavily used? > > Isn't it still necessary for people who don't yet have permission to > push?

Re: Checkin-needed requests - Please include complete information in the commit message :)

2016-07-10 Thread Xidorn Quan
On Mon, Jul 11, 2016, at 12:29 PM, Martin Thomson wrote: > Is now the right time to start talking about retiring checkin-needed, > or is it still heavily used? Isn't it still necessary for people who don't yet have permission to push? I also use checkin-needed for small changes which I don't thin

Re: Checkin-needed requests - Please include complete information in the commit message :)

2016-07-10 Thread Martin Thomson
Is now the right time to start talking about retiring checkin-needed, or is it still heavily used? On Sat, Jul 9, 2016 at 4:58 AM, Gregory Szorc wrote: > On Fri, Jul 8, 2016 at 11:39 AM, Felipe G wrote: > >> Is there a way to make the checkin-needed flag generate a template comment >> (like the