Re: New [must_use] property in XPIDL

2016-08-23 Thread Nicholas Nethercote
On Tue, Aug 23, 2016 at 11:40 PM, Benjamin Smedberg wrote: > cast-to-void is commonly suggested as an alternative to an explicit unused > marking, and it is something that I wanted to use originally. > Unfortunately, we have not been able to make that work: this is

Re: Intent to deprecate: Building mozilla-central without Skia enabled

2016-08-23 Thread Jeff Gilbert
Agreed. On Mon, Aug 22, 2016 at 11:08 AM, George Wright wrote: > I'm looking to remove the option to build mozilla-central without Skia. > > Currently we default to Skia being disabled, and enable it using > --enable-skia. This is problematic because all of our officially

Re: Intent to unship: WorkerGlobalScope.onclose

2016-08-23 Thread smaug
On 08/22/2016 02:27 PM, Ms2ger wrote: On 22/08/16 10:03, Andrea Marchesini wrote: I'm planning to remove |partial interface WorkerGlobalScope { attribute EventHandler onclose; }|. This EventHandler has been in our code base since ever but it's not part of the Workers spec and no other browses

Re: New [must_use] property in XPIDL

2016-08-23 Thread Gerald Squelart
On the build-time vs static analysis point: I'd much prefer to have errors pointed out right from './mach build', which I can fix on the spot; rather than wait hours until I notice static analysis errors on a treeherder build. (e.g., I always forget explicit/MOZ_IMPLICIT!) Unless we can get

RFC: Decommision of Persona Auth on BMO

2016-08-23 Thread Dave Lawrence
The Mozilla supported Persona authentication service will be decommissioned and cease to operate on November 30th. Since bugzilla.mozilla.org (BMO) allows users to authenticate using Persona, the BMO developers will need to also remove the authentication method from BMO before that time. We have

Re: New [must_use] property in XPIDL

2016-08-23 Thread Michael Layzell
We already have mozilla::Unused in mfbt/Unused.h. You can use it as `mozilla::unused << SomethingReturningAValue();`. I believe that the existing static analyses which look at unused variables respect this. On Tue, Aug 23, 2016 at 9:47 AM, Eric Rescorla wrote: > Fair enough. I

TaskCluster issues closing tree this morning

2016-08-23 Thread Dustin Mitchell
Admin Assigned: jhford Impact to service: Some TaskCluster worker types had backlogs of 30-60 minutes, including taskcluster-images jobs which must run before builds can begin. Trees are closed, preventing further check-ins. Start Date/Time: 2016-08-23 07:12:00 PDT Bug:

Re: New [must_use] property in XPIDL

2016-08-23 Thread Eric Rescorla
Fair enough. I wouldn't be against introducing a separate unused marker for this purpose. -Ekr On Tue, Aug 23, 2016 at 6:40 AM, Benjamin Smedberg wrote: > cast-to-void is commonly suggested as an alternative to an explicit unused > marking, and it is something that I

Re: New [must_use] property in XPIDL

2016-08-23 Thread Benjamin Smedberg
cast-to-void is commonly suggested as an alternative to an explicit unused marking, and it is something that I wanted to use originally. Unfortunately, we have not been able to make that work: this is primarily because compilers often remove the cast-to-void as part of the parsing phase, so it's

Re: New [must_use] property in XPIDL

2016-08-23 Thread Eric Rescorla
I'm indifferent to this particular case, but I think that rkent's point about static checking is a good one. Given that C++ has existing annotations that say: - This does not produce a useful return value (return void) - I am explicitly ignoring the return value (cast to void) And that we have