Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread jmaher
On Tuesday, June 6, 2017 at 3:17:20 PM UTC-4, Ben Kelly wrote: > On Tue, Jun 6, 2017 at 3:07 PM, Chris Peterson > wrote: > > > On 6/6/17 10:33 AM, Boris Zbarsky wrote: > > > >> On 6/1/17 9:04 PM, Mike Hommey wrote: > >> > >>> Ah, forgot to mention that. No, it doesn't affect *our* shipped builds

Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread Ben Kelly
On Tue, Jun 6, 2017 at 3:07 PM, Chris Peterson wrote: > On 6/6/17 10:33 AM, Boris Zbarsky wrote: > >> On 6/1/17 9:04 PM, Mike Hommey wrote: >> >>> Ah, forgot to mention that. No, it doesn't affect *our* shipped builds >>> (because PGO uses a different set of optimization flags). >>> >>> But it do

Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread Chris Peterson
On 6/6/17 10:33 AM, Boris Zbarsky wrote: On 6/1/17 9:04 PM, Mike Hommey wrote: Ah, forgot to mention that. No, it doesn't affect *our* shipped builds (because PGO uses a different set of optimization flags). But it does affect downstream builds that don't PGO. Based on the jump I see on June

Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread William Lachance
On 2017-06-06 1:33 PM, Boris Zbarsky wrote: On 6/1/17 9:04 PM, Mike Hommey wrote: Ah, forgot to mention that. No, it doesn't affect *our* shipped builds (because PGO uses a different set of optimization flags). But it does affect downstream builds that don't PGO. Based on the jump I see on Ju

Re: Linux builds now default to -O2 instead of -Os

2017-06-06 Thread Boris Zbarsky
On 6/1/17 9:04 PM, Mike Hommey wrote: Ah, forgot to mention that. No, it doesn't affect *our* shipped builds (because PGO uses a different set of optimization flags). But it does affect downstream builds that don't PGO. Based on the jump I see on June 2 at https://treeherder.mozilla.org/perf.

Errors found by cppcheck

2017-06-06 Thread Andrew Halberstadt
I was doing a bit of research into cppcheck [1] to see if it might be worth running as a linter (alongside eslint, flake8 etc). More discussion in bug 1370292 [2]. I ran it against the entire tree [3] and got these results: https://bug1370292.bmoattachments.org/attachment.cgi?id=8874498 So far it

[Firefox Desktop] Issues found: May 29th to June 2nd

2017-06-06 Thread Cornel Ionce
Hi everyone, Here's the list of new issues found and filed by the Desktop Release QA Team last week, *May 29 - June 2*(week 22). Additional details on the team's priorities last week, as well as the plans for the current week are available at: https://public.etherpad-mozilla.org/p/Deskto