Prefs overhaul

2018-03-06 Thread Nicholas Nethercote
Hi, I've been doing a lot of work to improve libpref recently, and there is more in the pipeline. I've written a brief roadmap that might be of interest to people: https://wiki.mozilla.org/Platform/PrefsOverhaul I'd be happy to hear feedback, via this list or other means. Thanks. Nick

Re: skip-if(verify)

2018-03-06 Thread Emilio Cobos Álvarez
On 03/06/2018 08:05 PM, Kyle Machulis wrote: > In my experience, many tests were written pre-test-verify, and don't clean > up correctly to deal with multiple runs in the same process. They work fine > when running as a single session, but blow up in TV. Having skip-if(verify) > means that we can

Re: skip-if(verify)

2018-03-06 Thread Kyle Machulis
In my experience, many tests were written pre-test-verify, and don't clean up correctly to deal with multiple runs in the same process. They work fine when running as a single session, but blow up in TV. Having skip-if(verify) means that we can at least mark those tests as known broken on TV

Re: skip-if(verify)

2018-03-06 Thread Emilio Cobos Álvarez
On 03/06/2018 06:04 PM, Geoffrey Brown wrote: > It is now possible to skip tests in test-verify. Simplify annotate the > manifest for your test: > > [test] > skip-if = verify > > or, for reftests: > > skip-if(verify) ... > > and the test-verify (TV) test task will not try to verify the

Re: Intent to unship: "storage" attribute in options for indexedDB.open()

2018-03-06 Thread Andrew Sutherland
QuotaManager already has a notion of "internal" origins[1] that explicitly white-lists devtools' synthetic "indexeddb" fake scheme.  It's this check that avoids the prompt when persistent storage is requested. It might make sense to expand the existing logic that acts like all

Re: PSA: Build bustage with Visual Studio 2017 15.6

2018-03-06 Thread Ryan VanderMeulen
As an update, the fix for bug 1443367 has been merged to m-c. There doesn't appear to be any other bustage lurking behind it, so updating should be less fraught with peril now. -Ryan On Mon, Mar 5, 2018 at 7:41 PM, Ryan VanderMeulen wrote: > Today, Microsoft

Re: Intent to unship: "storage" attribute in options for indexedDB.open()

2018-03-06 Thread J. Ryan Stinnett
DevTools is one chrome caller that might be impacted. We craft a custom principal and pass `storage: persistent`[1] when using IndexedDB in the tools. DevTools uses this storage for developer settings that should be retained over time. It sounds like with the proposed change here, DevTools

skip-if(verify)

2018-03-06 Thread Geoffrey Brown
It is now possible to skip tests in test-verify. Simplify annotate the manifest for your test: [test] skip-if = verify or, for reftests: skip-if(verify) ... and the test-verify (TV) test task will not try to verify the annotated test. Please don't abuse this feature! Most TV failures indicate

Intent to unship: "storage" attribute in options for indexedDB.open()

2018-03-06 Thread Johann Hofmann
I would like to unship the proprietary "storage" attribute in indexedDB.open()[0]. It allows developers to prevent their indexedDB storage from being evicted as part of quota management[1]. However, there is a web standard which specifies a better persistent storage mechanism and has broader