incremental compilation for opt Rust builds

2018-03-12 Thread Nathan Froyd
Hi all, In bug 1437627, I turned on incremental compilation for Rust for local developer opt builds as the default behavior. Debug builds should be using incremental compilation already, and automation builds continue to *not* use incremental compilation, due to environmental considerations that

Re: Unifying the common platform parity-* whiteboard flags as keywords

2018-03-12 Thread Jonathan Watt
TL;DR: The keywords will use browser names, not engine names, even for platform bugs. Due to feedback on the bug, the plan is now to add parity-[browser] keywords instead of compat-[engine] keywords so they can be shared with non-platform bugs. We could have keywords for both, but that would

PSA: Visual Studio 2017 15.6 now required to build 61+

2018-03-12 Thread Ryan VanderMeulen
While I know I'm tempting fate by sending this out while the patches are still on autoland, I wanted to start giving people a heads-up now that bug 1424281 has been pushed, which will make Visual Studio 2017 15.6 (Update 6) the minimum version required to build Gecko 61+ once it merges to m-c.

Re: Prefs overhaul

2018-03-12 Thread Nicholas Nethercote
The old code read the entire file into memory before starting parsing. In one place it did this with URLPreloader::ReadZip() (for default pref files), and in another place it did this with URLPreloader::ReadFile() (for user pref files). It was simplest to leave that code unchanged. Nick On Mon,

Re: PSA: Chrome-only WebIDL interfaces no longer require DOM peer review

2018-03-12 Thread Robert Helmer
On Mon, Mar 12, 2018 at 11:56 AM, Myk Melez wrote: > Nicholas Nethercote > 2018 March 9 at 20:02 > > What's your definition of XPCOM? > > This is basically what I'm asking Kris. I define it as the system that > Firefox uses to make intra- and inter-language calls between C++

Re: PSA: Chrome-only WebIDL interfaces no longer require DOM peer review

2018-03-12 Thread Bobby Holley
On Mon, Mar 12, 2018 at 11:56 AM, Myk Melez wrote: > Nicholas Nethercote > 2018 March 9 at 20:02 > > What's your definition of XPCOM? > > This is basically what I'm asking Kris. I define it as the system that > Firefox uses to make intra- and

Re: PSA: Chrome-only WebIDL interfaces no longer require DOM peer review

2018-03-12 Thread Myk Melez
Nicholas Nethercote 2018 March 9 at 20:02 What's your definition of XPCOM? This is basically what I'm asking Kris. I define it as the system that Firefox uses to make intra- and inter-language calls between C++ and JS via XPIDL and XPConnect. I'm interested in

Re: Soft code freeze for Firefox 60 starts March 1

2018-03-12 Thread Julien Cristau
The version bump to 61 has landed, central thawed and is open for business. Thanks, Julien On Thu, Feb 22, 2018 at 3:37 PM, Julien Cristau wrote: > Hi all, > > On March 1st, we will be merging Firefox 60 from mozilla-central to beta > for the first time. In order to

[desktop] Bugs logged by Desktop Release QA in the last 8 days

2018-03-12 Thread Bogdan Maris
Hello, Here's the list of new issues found and filed by the Desktop Release QA team last week. Additional details on the team's priorities last week, as well as the plans for the current week are available at: https://goo.gl/t8hQQQ Bugs logged by Desktop Release QA in the last 8 days Firefox:

Re: Prefs overhaul

2018-03-12 Thread David Teller
Out of curiosity, why is the read handled by C++ code? On 12/03/2018 10:38, Nicholas Nethercote wrote: > I don't know. But libpref's file-reading is done by C++ code, which passes > a string to the Rust code for parsing. > > Nick > ___ > dev-platform

Re: Prefs overhaul

2018-03-12 Thread Nicholas Nethercote
On Sun, Mar 11, 2018 at 4:24 AM, ISHIKAWA,chiaki wrote: > > I have noticed that you mentioned rewrite in Rust. > > Does the I/O primitive Rust uses handle the following "short read" case > niciely? > I don't know. But libpref's file-reading is done by C++ code, which