Re: NS_NewURI is now thread-safe

2019-06-10 Thread Cameron McCormack
This is going to let us simplify a whole lot of URL handling code in the style system, where we otherwise have to store strings and lazily creating nsIURIs when we're back on the main thread. Thanks so much! On Mon, Jun 10, 2019, at 1:08 PM, Valentin Gosu wrote: > Hello everyone, > > nsIURI

Re: NS_NewURI is now thread-safe

2019-06-10 Thread Bobby Holley
This is awesome work and has been years in the making. Thanks to everyone involved for getting it over the line! On Mon, Jun 10, 2019 at 1:42 PM Valentin Gosu wrote: > On Mon, 10 Jun 2019 at 22:25, Boris Zbarsky wrote: > > > On 6/10/19 4:07 PM, Valentin Gosu wrote: > > > which means nsIURI > >

Re: NS_NewURI is now thread-safe

2019-06-10 Thread Valentin Gosu
On Mon, 10 Jun 2019 at 22:25, Boris Zbarsky wrote: > On 6/10/19 4:07 PM, Valentin Gosu wrote: > > which means nsIURI > > can now be safely used and created on any thread via NS_NewURI. > > That's awesome news! > > > and if you want to add any other special scheme to Gecko you should do > so in

Re: NS_NewURI is now thread-safe

2019-06-10 Thread Boris Zbarsky
On 6/10/19 4:07 PM, Valentin Gosu wrote: which means nsIURI can now be safely used and created on any thread via NS_NewURI. That's awesome news! and if you want to add any other special scheme to Gecko you should do so in NS_NewURI in nsNetUtil.cpp Here "special" is in the sense of

NS_NewURI is now thread-safe

2019-06-10 Thread Valentin Gosu
Hello everyone, nsIURI has been immutable for a few releases now, meaning once you had one it was safe to use it on any thread (even change it using nsIURIMutator). But until recently you couldn't create a new URI off the main thread (unless you already knew the type of the URI). A few days ago I

Image format documentation review requested

2019-06-10 Thread Eric Shepherd (Sheppy)
I’ve just finished writing up a guide to image file types and formats. Before making it widely hooked into the main body of our documentation, I would like to get it reviewed by engineers to ensure accuracy. https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types Feel free to edit

Re: To what extent is sccache's distributed compilation usable?

2019-06-10 Thread Jonathan Watt
Just in case you're not aware of it, there are a couple of perf issues that may make people prefer ccache for now: https://github.com/mozilla/sccache/issues/219 https://github.com/mozilla/sccache/issues/160 Jonathan On 07/06/2019 18:13, Chris M. wrote: > I've been working through issues with

[desktop] Bugs logged by Desktop Release QA in the last 7 days

2019-06-10 Thread Bogdan Maris
Hello, Here's the list of new issues found and filed by the Desktop Release QA team last two weeks. Additional details on the team's priorities last week, as well as the plans for the current week are available at: https://tinyurl.com/yxf24ctb Bugs logged by Desktop Release QA in the last 7

Re: Running C++ early in shutdown without an observer

2019-06-10 Thread David Teller
On 10/06/2019 10:28, Henri Sivonen wrote: >>> Observers are automatically cleaned up at XPCOM shutdown, so you >>> generally don't need to worry too much about them. That said, >>> nsIAsyncShutdown is really the way to go when possible. But it currently >>> requires an unfortunate amount of

Re: Running C++ early in shutdown without an observer

2019-06-10 Thread Henri Sivonen
On Fri, Jun 7, 2019 at 9:45 PM Chris Peterson wrote: > > On 6/7/2019 9:36 AM, Kris Maglione wrote: > > On Fri, Jun 07, 2019 at 09:18:38AM +0300, Henri Sivonen wrote: > >> For late shutdown cleanup, we have nsLayoutStatics::Shutdown(). Do we > >> have a similar method for running things as soon as