Engineering Effectiveness Newsletter #2

2020-07-07 Thread Marco Castelluccio
to get you up to speed! This is the second iteration of the newsletter for the period of April, May and June.  = Highlights = - Andrew Halberstadt and Marco Castelluccio improved the `mach try auto` automatic test selector to run fewer tests and catch more failures <https://groups.google.

Re: Searchfox at All-Hands: Who's interested?

2020-01-15 Thread Marco Castelluccio
I'd be interested too, in particular about 1 as we'd like to integrate more things into Searchfox (code coverage, static analysis and linting issues to name a few). - Marco. Il 09/01/20 19:43, Andrew Sutherland ha scritto: > Are people interested in a session(s) at the All-Hands on Searchfox? 

New coverage frontend and zero coverage checker

2019-07-15 Thread Marco Castelluccio
Hello everyone, We are switching from relying on codecov.io and coveralls.io to our own backend/frontend to handle coverage data. This will allow us to build more features such as filtering coverage results by OS, filtering by test suite, etc.. Moreover, codecov.io and coveralls.io were not able

PSA: Bot automatically assigning components to Untriaged (and some General) bugs

2019-04-10 Thread Marco Castelluccio
Hello all, I just wanted to notify you that since a few weeks ago, our release mgmt bot has started automatically assigning components to untriaged bugs. The results look good so far, so we are going to keep it enabled. The bot is using machine learning to select a component, so it isn't 100%

Re: Using inline variables (C++17) in Gecko

2019-03-20 Thread Marco Castelluccio
The code coverage build is using GCC 6, if you do a try build don't forget to include that too (you'll need to pass the "--full" argument if you are using mach try fuzzy). The last time I tried, switching to GCC 7 caused a lot of timeouts (https://bugzilla.mozilla.org/show_bug.cgi?id=1410217#c5),

Re: Running different instances of Firefox side-by-side

2019-03-14 Thread Marco Castelluccio
What is the bug where you made the initial changes? We should link to the bug the regressions caused by it (I've seen at least a couple regressions filed mentioning this post on dev-platform rather than the bug where the regression was introduced). - Marco. Il 13/03/19 22:14, Dave Townsend ha

Code Coverage on Phabricator

2019-01-21 Thread Marco Castelluccio
Hi everyone, We have recently implemented a solution to integrate code coverage results into Phabricator. Coverage information is uploaded either automatically for revisions after they are landed in mozilla-central (for example for release managers when looking at uplift requests), or on-demand

Re: Rust code coverage

2019-01-21 Thread Marco Castelluccio
Il 07/01/19 14:36, Henri Sivonen ha scritto: > On Fri, Jan 4, 2019 at 2:54 PM Marco Castelluccio > wrote: >> Hi everyone, >> we have recently enabled collecting code coverage for Rust code too, > Nice! > >> running Rust tests in coverage builds. > Does this mean

Rust code coverage

2019-01-04 Thread Marco Castelluccio
Hi everyone, we have recently enabled collecting code coverage for Rust code too, running Rust tests in coverage builds. The support is still experimental, file bugs in the "Testing::Code Coverage" component if you see something fishy. The Rust reports are merged together with the

Re: Extension to integrate Searchfox features in Phabricator

2018-10-11 Thread Marco Castelluccio
o's using it. > > On Tue, Oct 2, 2018 at 6:03 AM Marco Castelluccio > mailto:mcastelluc...@mozilla.com>> wrote: > > I've built an (experimental) WebExtension to integrate some of the > Searchfox features into Phabricator. > I find it very useful to be able to search co

Extension to integrate Searchfox features in Phabricator

2018-10-02 Thread Marco Castelluccio
I've built an (experimental) WebExtension to integrate some of the Searchfox features into Phabricator. I find it very useful to be able to search code while reviewing, but I have to resort to opening a new Searchfox tab and looking for the code that is being modified. This extension makes my

Re: Re: nsAutoConfig

2017-10-31 Thread Marco Castelluccio
/src/nsReadConfig.cpp#L205 https://dxr.mozilla.org/mozilla-central/rev/1c618b1a13662de7cec429f606367db3827b6dc7/extensions/pref/autoconfig/src/nsReadConfig.cpp#208 - Marco. Il 31/10/2017 10:38, Masatoshi Kimura ha scritto: > On 2017/10/31 19:22, Marco Castelluccio wrote: >> It is no

Re: nsAutoConfig

2017-10-31 Thread Marco Castelluccio
It is not covered by any automated test: https://codecov.io/gh/marco-c/gecko-dev/src/9ca76dcb7a5c61d33750e9718c02b11ba35c1032/extensions/pref/autoconfig/src/nsAutoConfig.cpp (this doesn't mean it isn't actually used ever, but it can be a clue). - Marco. Il 31/10/2017 05:09, Nicholas Nethercote

Firefox startup code coverage (ts_paint talos test)

2017-08-02 Thread Marco Castelluccio
Hello all, at https://marco-c.github.io/ts_paint_startup_coverage_report/ you can find a (C/C++-only for now) code coverage report of Firefox startup. The report was generated using the ts_paint talos test, considering code executed until the "MozAfterPaint" event and after a setTimeout(, 0). It

Re: Re: CodeCoverage Monthly Update

2017-05-08 Thread Marco Castelluccio
No, currently not, but we can build one ourselves using their API (which we might to do with codecov.io anyway, since we expect to have custom needs). - Marco. Il 04/05/17 08:22, Chris Peterson ha scritto: On 2017-05-03 8:44 PM, Kyle Lahnakoski wrote: * Daily coverage reports on