Re: What is future of editor mode-lines after the switch to clang-format?

2018-11-30 Thread Tom Tromey
Nathan> Unfortunately, it doesn't look like .dir-locals.el provides any way to Nathan> set file modes, e.g. setting python-mode for moz.build file That's correct, it's a hole in dir-locals (there's already a bug filed against Emacs for this). It's also easy to document how to update

Re: Intent To Require Manifests For Vendored Code In mozilla-central

2018-04-10 Thread Tom Tromey
>> this should be: https://goo.gl/QZyz4x for the full specification. Some code in DevTools is vendored by dropping webpack bundles into the tree. The bundles are created by running a yarn command in the source repository; this also copies the bundle into an M-C tree. If these directories are

Re: #pragma once?

2017-10-11 Thread Tom Tromey
> "Marco" == Marco Bonardo writes: Marco> See the previous pragma once proposal: Marco> https://groups.google.com/forum/#!msg/mozilla.dev.platform/PgDjWw3xp8k/PLYQc5xoWmsJ Something I didn't see in that thread is that, at least with GCC, pragma once does not scale

Re: Intent to ship: SourceMap header

2017-05-17 Thread Tom Tromey
> "Boris" == Boris Zbarsky writes: >> https://github.com/source-map/source-map-rfc Boris> Are there any plans to have a standard here? All I found was this: https://groups.google.com/forum/#!topic/mozilla.dev.js-sourcemap/SD8sZ_7VFpw ... my reading of that was that there

Intent to ship: SourceMap header

2017-05-17 Thread Tom Tromey
I intend to turn support for the SourceMap response header on by default in nightly, and let it ride the trains. It has not been developed behind a preference. The existing X-SourceMap header will still be used if SourceMap is not seen; this matches the behavior of Chrome and WebKit. Bug to

Re: Runnable labeling for Quantum DOM

2016-12-02 Thread Tom Tromey
> "Bill" == Bill McCloskey writes: Bill> As part of the Quantum DOM project, we're going to be "labeling" all Bill> runnables in the browser to say which document they're operating on. I wonder whether this can be used to fix the various "run to completion" bugs

Re: Linux distro readiness for Rust in Gecko

2016-03-19 Thread Tom Tromey
> "Henri" == Henri Sivonen writes: Henri> Ubuntu and Fedora don't have any version of rustc anywhere at Henri> all. For Fedora it's in COPR, but of course that's not official, just something to play with. You can follow the Fedora Rust packaging process here:

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-14 Thread Tom Tromey
That assumes that the 'Foo' of aFoo is stable across function boundaries, which is not always the case. Ehsan No, it doesn't. In the scenario above, all you're looking for is when Ehsan a value was computed, so you can quickly see an aDuck, aQuack, Ehsan aFoopyFoo and determine that the value

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

2015-05-01 Thread Tom Tromey
Trevor One might wish to mark Foo::IsAFoo override so the compiler Trevor checks it shadows Base::IsAFoo but both are still non virtual. Yes, I agree, one might. But that doesn't really have any bearing on the present. Right now, override is defined as only making sense on virtual functions.

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-23 Thread Tom Tromey
Axel The other easy way to reduce impact here is to reduce the use of Axel nsTextFormatter, or create a replacement that doesn't crash. L20n Axel would be one, or maybe there's C++ template stuff that can taint Axel values with their original types. Tom I don't think there is a compile-time

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-22 Thread Tom Tromey
Axel The other easy way to reduce impact here is to reduce the use of Axel nsTextFormatter, or create a replacement that doesn't crash. L20n Axel would be one, or maybe there's C++ template stuff that can taint Axel values with their original types. Tom I don't think there is a compile-time

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-20 Thread Tom Tromey
Axel == axel-4eJtQOnFJqFBDgjK7y7TUQ axel-4ejtqonfjqfbdgjk7y7...@public.gmane.org writes: Axel We can only do this in the compiler if we actually compiled each Axel localized version by itself. Yes, I see what you mean. Axel The other easy way to reduce impact here is to reduce the use of

Re: Testing for expected crashes in both C++ and js, for printf checking

2015-02-19 Thread Tom Tromey
Axel == axel-4eJtQOnFJqFBDgjK7y7TUQ axel-4ejtqonfjqfbdgjk7y7...@public.gmane.org writes: Axel I'm talking actual crashes, and I don't know how we would fix the Axel text formatter. I'm glancing at Axel http://mxr.mozilla.org/mozilla-central/source/xpcom/glue/nsTextFormatter.cpp#778, Axel