Re: Rationalising Linux audio backend support

On Fri, Mar 24, 2017 at 11:45:57AM -0700, kthies...@mozilla.com wrote: > On Wednesday, March 22, 2017 at 9:42:02 PM UTC-7, jtkel...@gmail.com wrote: > > On Wednesday, March 22, 2017 at 1:35:06 PM UTC-5, Botond Ballo wrote: > > > Based on this new information, might there be room to reconsider this

Re: Faster gecko builds with IceCC on Mac and Linux

On Tue, Jul 05, 2016 at 04:42:09PM -0700, Gregory Szorc wrote: > On Tue, Jul 5, 2016 at 3:58 PM, Ralph Giles wrote: > > > On Tue, Jul 5, 2016 at 3:36 PM, Gregory Szorc wrote: > > > > > * `mach build binaries` (touch network/dns/DNS.cpp): 14.1s > > > > 24s

Re: Intent to deprecate: MacOS 10.6-10.8 support

On Thu, Mar 10, 2016 at 04:01:15PM -0700, Tyler Downer wrote: > The other thing to note is many of those users can still update to 10.11, > and I imagine that over the next year that number will continue to go down. given they haven't upgraded from 10.6 - 10.8 why do you believe they are likely

Re: Proposal to stop revving UUIDs when changing XPIDL interfaces

On Fri, Jan 15, 2016 at 04:28:13PM -0800, Jonas Sicking wrote: > On Fri, Jan 15, 2016 at 11:41 AM, Joshua Cranmer  > wrote: > > On 1/15/2016 1:21 PM, Bobby Holley wrote: > >> > >> Has anyone measured recently whether there's still a significant perf win > >> to making IIDs

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

On Fri, May 01, 2015 at 05:05:09AM -0700, finnbry...@gmail.com wrote: On Friday, May 1, 2015 at 12:03:35 PM UTC+1, Aryeh Gregor wrote: On Thu, Apr 30, 2015 at 6:49 PM, Trevor Saunders wrote: I don't think it would actually be backward incompatible the only changes would be turning invalid

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

On Wed, Apr 29, 2015 at 02:53:03PM -0400, Ehsan Akhgari wrote: On 2015-04-27 9:54 PM, Trevor Saunders wrote: On Mon, Apr 27, 2015 at 09:07:51PM -0400, Ehsan Akhgari wrote: On Mon, Apr 27, 2015 at 5:45 PM, Trevor Saunders tbsau...@tbsaunde.org wrote: On Mon, Apr 27, 2015 at 03:48:48PM -0400

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

On Mon, Apr 27, 2015 at 03:48:48PM -0400, Ehsan Akhgari wrote: Right now, our coding style requires that both the virtual and override keywords to be specified for overridden virtual functions. A few things have changed since we decided that a number of years ago: 1. The override and final

Re: Proposal to alter the coding style to not require the usage of 'virtual' where 'override' is used

On Mon, Apr 27, 2015 at 09:07:51PM -0400, Ehsan Akhgari wrote: On Mon, Apr 27, 2015 at 5:45 PM, Trevor Saunders tbsau...@tbsaunde.org wrote: On Mon, Apr 27, 2015 at 03:48:48PM -0400, Ehsan Akhgari wrote: Right now, our coding style requires that both the virtual and override keywords

Re: Excessive inbound bustage

On Tue, Apr 21, 2015 at 03:11:36PM -0400, Andrew Halberstadt wrote: On 21/04/15 03:02 PM, Aaron Klotz wrote: On 4/21/2015 12:50 PM, Andrew Halberstadt wrote: This could be effective, but if not implemented with care it could also be very de-motivating, especially for a well-intentioned

Re: Excessive inbound bustage

On Tue, Apr 21, 2015 at 03:31:28PM -0700, Bobby Holley wrote: On Tue, Apr 21, 2015 at 3:29 PM, Robert O'Callahan rob...@ocallahan.org wrote: Right. Someone just needs to collect the data *privately* and then notify people or take other remedial action. Personally, I'd much rather keep

Re: Intent to deprecate: Insecure HTTP

On Wed, Apr 15, 2015 at 10:44:35AM +0100, Gervase Markham wrote: On 14/04/15 22:59, northrupthebandg...@gmail.com wrote: The article assumes that when folks connect to something via SSH and something changes - causing MITM-attack warnings and a refusal to connect - folks default to just

Re: Proposal to ban the usage of refcounted objects inside C++ lambdas in Gecko

On Mon, Apr 13, 2015 at 01:28:05PM -0400, Ehsan Akhgari wrote: On 2015-04-13 5:26 AM, Nicolas B. Pierron wrote: On 04/10/2015 07:47 PM, Ehsan Akhgari wrote: On 2015-04-10 1:41 PM, Nicolas B. Pierron wrote: Also, what is the alternative? Acquiring a nsCOMPtr/nsRefPtr inside the Lambda

Re: SpiderMonkey and XPConnect style changing from |T *p| to |T* p|

On Mon, Mar 30, 2015 at 11:01:28AM -0700, Bobby Holley wrote: On Mon, Mar 30, 2015 at 10:54 AM, Chris Peterson cpeter...@mozilla.com wrote: On 3/29/15 3:35 PM, smaug wrote: Having the one commit in the blame doesn't really matter. Often one needs to go to the first commit of the code

Re: Reversely iterating nsTArray

On Wed, Jan 28, 2015 at 10:59:48AM -0500, Ehsan Akhgari wrote: On 2015-01-27 9:24 PM, Xidorn Quan wrote: I asked a question in #developers that what is the best way to reversely iterating nsTArray, and there are some suggestions: tbsaunde uint32_t count = array.Length(); for (uint32_t i =

Re: PSA: Non-unified builds no longer occurring on central/inbound and friends

On Thu, Jan 15, 2015 at 06:39:56PM +0100, Sylvestre Ledru wrote: On 15/01/2015 16:56, ISHIKAWA,chiaki wrote: On 2015/01/15 10:37, Steve Fink wrote: On 01/14/2015 11:26 AM, Ehsan Akhgari wrote: From now on, the only supported build mode is unified compilation. I am planning to

Re: About the bitfield requirement for portibility

On Thu, Nov 06, 2014 at 01:36:05PM -0800, Chris Peterson wrote: On 11/6/14 10:22 AM, Jason Orendorff wrote: I guess I was a little irked that people are still tripping over this ancient document (didn't we delete that?), because I just took the time to clobber most of it and update what was

Re: Git - Hg workflows?

On Fri, Oct 31, 2014 at 02:03:35PM -0400, Ehsan Akhgari wrote: On 2014-10-31 12:51 PM, Gregory Szorc wrote: As has been said on this list before, switching canonical to Git just isn't going to happen. Valid reasons have been given before. But here's a new one: we don't need to. I think it's

Re: The worst piece of Mozilla code

On Fri, Oct 17, 2014 at 09:32:20AM +1100, Nicholas Nethercote wrote: On Thu, Oct 16, 2014 at 11:32 PM, Nicholas Nethercote n.netherc...@gmail.com wrote: I was wondering what people think is the worst piece of code in the entire Mozilla codebase. I'll leave the exact meanings of worst and

treating B2G device tests as tier 1

Hi, This morning tomcat decided to back bug 982842 and a bunch of dependant bugs out for breaking some of the gaia device tests. As I understand things, this is not the first time something like that has happened. However I think that was a mistake, it treated those tests as tier 1 when they

Re: treating B2G device tests as tier 1

On Wed, Oct 15, 2014 at 05:36:00PM -0400, Ryan VanderMeulen wrote: On 10/15/2014 5:15 PM, Trevor Saunders wrote: Hi, This morning tomcat decided to back bug 982842 and a bunch of dependant bugs out for breaking some of the gaia device tests. As I understand things, this is not the first

Re: Using c++11 right angle bracket in template code?

On Thu, Oct 02, 2014 at 01:58:52PM -0400, Ehsan Akhgari wrote: On 2014-10-02, 1:14 AM, Xidorn Quan wrote: On Wed, Oct 1, 2014 at 6:27 PM, Ehsan Akhgari ehsan.akhg...@gmail.com mailto:ehsan.akhg...@gmail.com wrote: On 2014-10-01, 7:42 PM, L. David Baron wrote: On Wednesday

Re: http-schemed URLs and HTTP/2 over unauthenticated TLS (was: Re: WebCrypto for http:// origins)

On Fri, Sep 12, 2014 at 08:55:51AM +0300, Henri Sivonen wrote: On Thu, Sep 11, 2014 at 9:00 PM, Richard Barnes rbar...@mozilla.com wrote: On Sep 11, 2014, at 9:08 AM, Anne van Kesteren ann...@annevk.nl wrote: On Thu, Sep 11, 2014 at 5:56 PM, Richard Barnes rbar...@mozilla.com wrote:

Re: Experiment with running debug tests less often on mozilla-inbound the week of August 25

On Tue, Aug 19, 2014 at 02:49:48PM -0700, Jonathan Griffin wrote: On 8/19/2014 2:41 PM, Ehsan Akhgari wrote: On 2014-08-19, 3:57 PM, Jeff Gilbert wrote: I would actually say that debug tests are more important for continuous integration than opt tests. At least in code I deal with, we have a

Re: Introducing mozilla::UniquePtr and mozilla::MakeUnique for |new T| and |new T[]| resources

On Fri, Aug 01, 2014 at 11:52:03AM +1200, Robert O'Callahan wrote: On Fri, Aug 1, 2014 at 11:24 AM, Jeff Walden jwalden+...@mit.edu wrote: One last note. UniquePtr is patterned on std::unique_ptr, the C++11 standard version of this idiom. The current mozilla::Scoped class is another

Re: Deprecating localstore.rdf

On Wed, Jul 23, 2014 at 05:10:33AM -0700, rviti...@mozilla.com wrote: Localstore.rdf will soon be replaced with a json store (see Bug 559505). I am currently planning to leave the localstore.rdf implementation as it is and issue a warning when a client tries to access to it. This is needed as

Re: C++ standards proposals of potential interest, and upcoming committee meeting

On Mon, Jun 09, 2014 at 12:31:39PM -0700, Botond Ballo wrote: Hi everyone, Here are some C++ standards proposals from the latest committee mailing that I think might be of interest to the Mozilla community: Portable C++ ABI:

Re: Policing dead/zombie code in m-c

On Tue, Jun 03, 2014 at 12:08:52PM -0400, Ehsan Akhgari wrote: On 2014-06-03, 5:57 AM, Henri Sivonen wrote: On Wed, May 28, 2014 at 5:45 PM, Nathan Froyd froy...@mozilla.com wrote: Assuming that ICU is already compiled with the moral equivalent of GCC's -ffunction-sections -fdata-sections or

Re: Policing dead/zombie code in m-c

worth investigating, but getting the build system to strip out as much as possible might be more effective – see the next item. easier probably, better no think of the hundreds of people who are stuck building it all the time. On Apr 25, 2014, at 8:12 , Trevor Saunders trev.saund...@gmail.com

Re: Policing dead/zombie code in m-c

On Fri, Apr 25, 2014 at 10:42:43AM -0400, Mike Hoye wrote: On 2014-04-25, 3:31 AM, Henri Sivonen wrote: On Thu, Apr 24, 2014 at 4:20 PM, Benoit Jacob jacob.benoi...@gmail.com wrote: * How should we identify code that we build but that isn't used anywhere? I'm afraid we need humans for

Re: Policing dead/zombie code in m-c

On Thu, Apr 24, 2014 at 09:20:06AM -0400, Benoit Jacob wrote: 2014-04-24 8:31 GMT-04:00 Henri Sivonen hsivo...@hsivonen.fi: I have prepared a queue of patches that removes Netscape-era (circa 1999) internationalization code that efforts to implement the Encoding Standard have shown

Re: Can we remove NS_HIDDEN, NS_HIDDEN_(...)?

On Wed, Apr 23, 2014 at 07:51:54AM +0900, Mike Hommey wrote: On Wed, Apr 23, 2014 at 10:41:06AM +1200, Robert O'Callahan wrote: On Wed, Apr 23, 2014 at 1:25 AM, Benjamin Smedberg benja...@smedbergs.uswrote: On 4/22/2014 7:31 AM, Robert O'Callahan wrote: It's all over the tree,

Re: Oculus VR support somehwat-non-free code in the tree

On Tue, Apr 15, 2014 at 10:33:51AM -0400, Mike Hoye wrote: On 2014-04-15, 10:25 AM, Mike Hoye wrote: On 2014-04-15, 12:47 AM, Andreas Gal wrote: Vlad asked a specific question in the first email. Are we comfortable using another open (albeit not open enough for MPL) license on trunk while we

Re: New e10s tests on tinderbox

On Tue, Apr 08, 2014 at 02:28:02PM -0700, Bill McCloskey wrote: Hi everyone, Starting today, we have new mochitests that show up as M-e10s (1 2 3 4 5). These are mochitests-plain running inside an e10s content process. Aside from being in a separate process, they work pretty much the same

Re: mozilla::Atomic considered harmful

On Wed, Apr 02, 2014 at 05:03:53PM +0200, Honza Bambas wrote: On 4/2/2014 11:33 AM, Nicolas B. Pierron wrote: --lock(mRefCnt); if (lock(mRefCnt) == 0) { delete this; } This way, this is more obvious that we might not be doing the right things, as long as we are careful to refuse

Re: mozilla::Atomic considered harmful

On Wed, Apr 02, 2014 at 05:37:39PM +0200, Honza Bambas wrote: On 4/2/2014 5:24 PM, Trevor Saunders wrote: On Wed, Apr 02, 2014 at 05:03:53PM +0200, Honza Bambas wrote: On 4/2/2014 11:33 AM, Nicolas B. Pierron wrote: --lock(mRefCnt); if (lock(mRefCnt) == 0) { delete this; } This way

Re: mozilla::NullptrT on B2G ICS vs. everything else (incl. B2G JB and Android ICS)

On Tue, Apr 01, 2014 at 09:47:15AM -0500, Joshua Cranmer ? wrote: On 4/1/2014 8:42 AM, Henri Sivonen wrote: This makes me wonder if B2G ICS emulator uses a nullptr-wise backwards compiler / compiler settings by accident. Can it be changed to use a compiler / compiler settings similar to B2G JB

Re: FYI I you have a slave currently borrowed from Releng (Maint 3/28 2200 PT)

Hi, If I'm currently borrowing a machine I don't know about it or have a particular use for it. Trev On Wed, Mar 26, 2014 at 12:14:02PM -0700, Hal Wine wrote: NOTE: if RelEng has loaned you a slave, you may be impacted by the VPN work below happening this Friday night Original

Re: Having more control over when an IPDL message is compressed

On Mon, Mar 24, 2014 at 03:18:19PM -0700, Botond Ballo wrote: Hello dev-platform, I recently fixed an APZ bug [1] that was caused by an IPDL message, PBrowser::UpdateFrame, being compressed when it shouldn't have been. I think the compression was correct back when we didn't have subframe

Re: We live in a memory-constrained world

On Tue, Mar 04, 2014 at 09:48:33AM +0200, Henri Sivonen wrote: On Fri, Feb 28, 2014 at 8:09 PM, L. David Baron dba...@dbaron.org wrote: In other words, whenever you have a pointer in a static data structure pointing to some other data, that pointer needs to get fixed up when the library

Re: We live in a memory-constrained world

On Fri, Feb 28, 2014 at 05:59:13AM -0800, Nathan Froyd wrote: - Original Message - http://en.wikipedia.org/wiki/Plain_Old_Data_Structures confirms that POD can't have a vptr :-) class Interface { public: constexpr Interface() {} virtual int f() = 0; }; class

Re: Style guide clarity on C++-isms

On Wed, Jan 08, 2014 at 02:24:46PM -0500, Ehsan Akhgari wrote: On 1/7/2014, 7:00 PM, Cameron McCormack wrote: Ehsan Akhgari wrote: Exactly. If we require braces on their own lines for function bodies everywhere, we wouldn't need to solve this! Are you sure? :) There are a bunch of

Re: PSA: Please stop using NULL in C++ code

On Mon, Jan 06, 2014 at 01:35:38PM -0500, Ehsan Akhgari wrote: On 1/6/2014, 1:20 PM, Gregory Szorc wrote: On 1/6/14, 7:12 AM, Ehsan Akhgari wrote: With Birunthan's restless efforts in bug 784739, we have finally removed the usage of NULL in our C++ code. Please stop using NULL in new C++

Re: (un)safety of NS_LITERAL_STRING(...).get()

On Thu, Dec 12, 2013 at 07:01:18PM -0600, Joshua Cranmer ? wrote: On 12/12/2013 6:52 PM, David Keeler wrote: Recently bug 539710 landed[0] to fix an unnecessary and apparently unsafe operation: const PRUnichar *comma = NS_LITERAL_STRING(,).get(); Curious, I did a quick search for other

Re: Trouble building trunk as debug ASAN on OS X

On Thu, Oct 31, 2013 at 07:54:04PM -0400, Milan Sreckovic wrote: Started happening recently, though I'm not sure if it's my system or something changed in our code. Anyone else able to build ASAN debug on OS X? I'm using clang. It looks like we changed something to make your version of

Re: C++ Standards Committee meeting next week

On Tue, Oct 01, 2013 at 01:13:37PM -0700, Botond Ballo wrote: - final on data / non virtual member functions - virtual constants (maybe ability to get at vtable pointer too?) - ability to say classes should only be used on stack / heap or not used in one of those It would be nice

Re: C++ Standards Committee meeting next week

Hi, some things that I've seen that we'd probably like to see end up in the language include. - final on data / non virtual member functions - virtual constants (maybe ability to get at vtable pointer too?) - ability to say classes should only be used on stack / heap or not used in one of

Re: Including algorithm just to get std::min and std::max

On Thu, Sep 12, 2013 at 11:59:30PM +0200, Julian Seward wrote: On 09/12/2013 11:08 PM, Chris Peterson wrote: On 9/12/13 6:35 AM, Mike Hommey wrote: Note we have *many* inline functions that the compiler decide to never inline. We should maybe try to detect those on all platforms and move

Re: Upcoming changes to the Linux 32-bits and Android builders

On Wed, May 15, 2013 at 11:36:01AM -0700, Chris Peterson wrote: On 5/15/13 2:42 AM, Mike Hommey wrote: Following this, we're going to switch all Linux builds to gcc 4.7, later this week. Android NDK r8e also includes gcc 4.7. We may want to investigate updating to gcc 4.7 on Android, too.

Re: Ordering shutdown observers?

On Wed, May 15, 2013 at 05:18:09PM -0400, Vladan Djeric wrote: Hi all, I recently came across a situation where it would have been useful to control the order in which components receive the same shutdown notification. Specifically, Telemetry writes out session data to the profile dir

Re: We should drop MathML

On Mon, May 06, 2013 at 11:30:51AM -0700, mscl...@googlemail.com wrote: On Monday, 6 May 2013 14:12:48 UTC+1, Trevor Saunders wrote: On Mon, May 06, 2013 at 08:24:07AM -0400, Boris Zbarsky wrote: I am still waiting for the rebuttal of my arguments, in the original email

Re: Proposal for using a multi-headed tree instead of inbound

On Wed, Apr 03, 2013 at 04:59:31PM -0700, Jeff Hammel wrote: On 04/03/2013 04:44 PM, Joshua Cranmer  wrote: On 4/3/2013 5:36 PM, L. David Baron wrote: On Wednesday 2013-04-03 17:31 -0400, Kartikaya Gupta wrote: 1. Take the latest green m-c change, commit your patch(es) on top of it, and push

Re: Proposal for using a multi-headed tree instead of inbound

On Wed, Apr 03, 2013 at 08:55:36PM -0400, Ehsan Akhgari wrote: On 2013-04-03 7:44 PM, Joshua Cranmer  wrote: On 4/3/2013 5:36 PM, L. David Baron wrote: On Wednesday 2013-04-03 17:31 -0400, Kartikaya Gupta wrote: Instead of running {mochitest-*,reftest,crashtest,xpcshell,marionette} on every

Re: Moz2D Repository Creation

And, Git subtree is essentially the strategy m-c uses today: one large repository holding the history (albeit sometimes squashed landings) of many external ones. however it has the possible advantage that the VCS has some idea what is happening, and you have the history for the external

Re: Paint Timing Changes and Tp5

As a partial aside, I think it might be *better* if the OMTC thread was the thread which actually processed windows events, especially if we didn't ever need to block the OMTC thread on the main gecko thread and merely dispatch them asynchronously: this could significantly improve our