Re: [PATCH] gfx: thebes: decouple GfxSurfaceType from cairo_surface_type_t

On Mon, Jul 31, 2017 at 3:40 AM, Enrico Weigelt, metux IT consult wrote: > On 31.07.2017 09:23, Cameron McCormack wrote: >> Firefox patches should be submitted via Bugzilla, rather than by email >> to dev-platform. Please see: >> >>

Re: [PATCH] gfx: thebes: decouple GfxSurfaceType from cairo_surface_type_t

yes - https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch covers this. please read all of the document linked by cameron and this one. -glob Enrico Weigelt, metux IT consult wrote: On 31.07.2017 09:23, Cameron McCormack wrote: Hi Enrico, Firefox patches

Re: [PATCH] gfx: thebes: decouple GfxSurfaceType from cairo_surface_type_t

On 31.07.2017 09:23, Cameron McCormack wrote: Hi Enrico, Firefox patches should be submitted via Bugzilla, rather than by email to dev-platform. Please see: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed Is there a way to submit

Re: [PATCH] gfx: thebes: decouple GfxSurfaceType from cairo_surface_type_t

Hey Enrico, patches are certainly appreciated, but please attach them (and corresponding rationale) to bugs instead. This one should probably go here: https://bugzilla.mozilla.org/enter_bug.cgi?product=Core=Graphics. dev-platform has a ton of subscribers and is really only meant for more

Re: [PATCH] gfx: thebes: decouple GfxSurfaceType from cairo_surface_type_t

Hi Enrico, Firefox patches should be submitted via Bugzilla, rather than by email to dev-platform. Please see: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction#Step_4_-_Get_your_code_reviewed Thanks, Cameron On Mon, Jul 31, 2017, at 03:14 PM, Enrico Weigelt, metux

[PATCH] gfx: thebes: decouple GfxSurfaceType from cairo_surface_type_t

For now, our GfxSurfaceType enum (and things depending on it) is tightly coupled to cairo_surface_type_t, which is bad for encapsulation. And we're also tightly coupled to the current, meanwhile pretty old and customized in-tree version of cairo. To reduce maintenance burden and as a first step