Re: Care in the use of MOZ_CRASH_UNSAFE_* macros: data review needed

2017-07-17 Thread Gregory Szorc
On Mon, Jul 17, 2017 at 10:01 AM, Kris Maglione wrote: > On Mon, Jul 17, 2017 at 09:52:55AM -0700, Bobby Holley wrote: > >> On Mon, Jul 17, 2017 at 9:42 AM, Benjamin Smedberg > > >> wrote: >> >> I don't know really anything about how rust panics get

Re: Care in the use of MOZ_CRASH_UNSAFE_* macros: data review needed

2017-07-17 Thread Kris Maglione
On Mon, Jul 17, 2017 at 09:52:55AM -0700, Bobby Holley wrote: On Mon, Jul 17, 2017 at 9:42 AM, Benjamin Smedberg wrote: I don't know really anything about how rust panics get reflected into crash-data. Who would be the right person to talk to about that? Rust panics

Re: Care in the use of MOZ_CRASH_UNSAFE_* macros: data review needed

2017-07-17 Thread Bobby Holley
On Mon, Jul 17, 2017 at 9:42 AM, Benjamin Smedberg wrote: > I don't know really anything about how rust panics get reflected into > crash-data. Who would be the right person to talk to about that? > Rust panics are equivalent to MOZ_CRASHES, and we treat them as such (or

Re: Care in the use of MOZ_CRASH_UNSAFE_* macros: data review needed

2017-07-17 Thread David Major
As of bug 1275780, rust panic text gets reported as a MOZ_CRASH reason. On Mon, Jul 17, 2017 at 12:42 PM, Benjamin Smedberg wrote: > I don't know really anything about how rust panics get reflected into > crash-data. Who would be the right person to talk to about that? >

Re: Care in the use of MOZ_CRASH_UNSAFE_* macros: data review needed

2017-07-17 Thread Benjamin Smedberg
I don't know really anything about how rust panics get reflected into crash-data. Who would be the right person to talk to about that? --BDS On Mon, Jul 17, 2017 at 12:40 PM, Emilio Cobos Álvarez wrote: > On 07/17/2017 05:18 PM, Benjamin Smedberg wrote:> Unlike MOZ_CRASH, >

Re: Care in the use of MOZ_CRASH_UNSAFE_* macros: data review needed

2017-07-17 Thread Emilio Cobos Álvarez
On 07/17/2017 05:18 PM, Benjamin Smedberg wrote:> Unlike MOZ_CRASH, which only annotates crashes with compile-time constants > which are inherently not risky, both MOZ_CRASH_UNSAFE_OOL and > MOZ_CRASH_UNSAFE_PRINTF can annotate crashes with arbitrary data. Crash > reasons are publicly visible in

Care in the use of MOZ_CRASH_UNSAFE_* macros: data review needed

2017-07-17 Thread Benjamin Smedberg
Please take care when using the MOZ_CRASH_UNSAFE_* macros. Because of the risk involved and because this constitutes data collection, I would like Firefox data stewards to review any new usages of the MOZ_CRASH_UNSAFE_* macros. Unlike MOZ_CRASH, which only annotates crashes with compile-time