Re: Changes in how Gecko code linkage is defined in the build system

2014-06-25 Thread Mike Hommey
On Tue, Nov 19, 2013 at 11:02:52AM +0900, Mike Hommey wrote: Hi, I am going to land a long series of patches that changes how Gecko code linkage is defined. Currently, when you add new code (like, a new module) to Gecko, you: - Add a new directory - Edit the parent moz.build to add the

Re: Changes in how Gecko code linkage is defined in the build system

2013-11-18 Thread Robert O'Callahan
Lovely!!! On Tue, Nov 19, 2013 at 3:02 PM, Mike Hommey m...@glandium.org wrote: - FINAL_LIBRARY defines what library your code is going to be linked into. That needs to match an existing LIBRARY_NAME in some other moz.build. Most code will go in either xul, gkmedias or gklayout. Note

Re: Changes in how Gecko code linkage is defined in the build system

2013-11-18 Thread Mike Hommey
On Tue, Nov 19, 2013 at 03:12:23PM +1300, Robert O'Callahan wrote: Lovely!!! On Tue, Nov 19, 2013 at 3:02 PM, Mike Hommey m...@glandium.org wrote: - FINAL_LIBRARY defines what library your code is going to be linked into. That needs to match an existing LIBRARY_NAME in some other

Re: Changes in how Gecko code linkage is defined in the build system

2013-11-18 Thread Robert O'Callahan
On Tue, Nov 19, 2013 at 3:32 PM, Mike Hommey m...@glandium.org wrote: FWIW, there's an open bug to fold gkmedias back into xul, but it looks like it's not going to happen soon. https://bugzilla.mozilla.org/show_bug.cgi?id=922912 Egad! Oh well. Rob -- Jtehsauts tshaei dS,o n Wohfy Mdaon

Re: Changes in how Gecko code linkage is defined in the build system

2013-11-18 Thread Joshua Cranmer 
On 11/18/2013 8:02 PM, Mike Hommey wrote: Hi, I am going to land a long series of patches that changes how Gecko code linkage is defined. As a comm-central build system peer (best viewed in fixed-width font): _ _ ___ _ _ __ __ _ _ _ _ |_ _| | | | / \ | \ | | |/