Re: Column numbers appended to URLs recently

2014-03-05 Thread Boris Zbarsky
On 3/5/14 3:50 AM, Martin Thomson wrote: For my gratification, why is this information not also provided as an object? It is, for XPConnect/DOM exceptions. Just not for built-in JS ones... -Boris ___ dev-platform mailing list dev-platform@lists.mozi

Re: Column numbers appended to URLs recently

2014-03-05 Thread Jan Honza Odvarko
On Wednesday, March 5, 2014 9:50:07 AM UTC+1, Martin Thomson wrote: > On 2014-03-03, at 18:54, Jan Honza Odvarko wrote: > > > > > URLs in stack traces for exception objects have been recently changed. > > There is a column number appended at the end (I am seeing this in Nightly, > > but it co

Re: Column numbers appended to URLs recently

2014-03-05 Thread Jan Honza Odvarko
On Tuesday, March 4, 2014 10:33:47 PM UTC+1, Jason Orendorff wrote: > On 3/3/14, 12:54 PM, Jan Honza Odvarko wrote: > > > URLs in stack traces for exception objects have been recently changed. > > There is a column number appended at the end (I am seeing this in Nightly, > > but it could be also

Re: Column numbers appended to URLs recently

2014-03-05 Thread Martin Thomson
On 2014-03-03, at 18:54, Jan Honza Odvarko wrote: > URLs in stack traces for exception objects have been recently changed. There > is a column number appended at the end (I am seeing this in Nightly, but it > could be also in Aurora). For my gratification, why is this information not also prov

Re: Column numbers appended to URLs recently

2014-03-04 Thread Jason Orendorff
On 3/3/14, 12:54 PM, Jan Honza Odvarko wrote: > URLs in stack traces for exception objects have been recently changed. There > is a column number appended at the end (I am seeing this in Nightly, but it > could be also in Aurora). Code that parses error.stack now needs to handle the case where b

Re: Column numbers appended to URLs recently

2014-03-03 Thread Cameron McCormack
Jan Honza Odvarko wrote: Next example: http://example.com:80 Now it isn't clear whether it's a port number or a line number. Could we somehow fix this? "http://example.com/"; is equivalent to "http://example.com"; so you could just ensure that you output a "/" when the path is empty. (http

Re: Column numbers appended to URLs recently

2014-03-03 Thread Fitzgerald, Nick
This was before that bug. See ComputeStackString: http://dxr.mozilla.org/mozilla-central/source/js/src/jsexn.cpp?from=jsexn.cpp#206 The format is: [] @ : : The last : and is what was added in that bug. I guess the port-or-line-number question is unambiguous if there is *always* a line num

Re: Column numbers appended to URLs recently

2014-03-03 Thread Dave Townsend
I'm guessing this is a result of https://bugzilla.mozilla.org/show_bug.cgi?id=762556 On Mon, Mar 3, 2014 at 11:17 AM, Boris Zbarsky wrote: > On 3/3/14 1:54 PM, Jan Honza Odvarko wrote: > >> An example of the stack trace: >> >> http://example.com/path/file.html:102 >> > > Which exact API is this

Re: Column numbers appended to URLs recently

2014-03-03 Thread Boris Zbarsky
On 3/3/14 1:54 PM, Jan Honza Odvarko wrote: An example of the stack trace: http://example.com/path/file.html:102 Which exact API is this string coming from? We have a number of different APIs here, returning slightly different things. :( -Boris

Column numbers appended to URLs recently

2014-03-03 Thread Jan Honza Odvarko
URLs in stack traces for exception objects have been recently changed. There is a column number appended at the end (I am seeing this in Nightly, but it could be also in Aurora). An example of the stack trace: http://example.com/path/file.html:102 ... means there was an exception at the specif