Re: Components.returnCode not working as expected.

2014-11-25 Thread Bobby Holley
On Sun, Nov 23, 2014 at 4:43 PM, Mark Hammond mhamm...@skippinet.com.au wrote: * Is Components.returnCode expected to be used when the code throws (as SessionStore.jsm does) or when the code returns without an exception? (Or maybe both?) It doesn't look like it's used much in the tree, but

Re: Components.returnCode not working as expected.

2014-11-24 Thread Philipp Kewisch
On 11/24/14 1:43 AM, Mark Hammond wrote: * Is Components.returnCode expected to be used when the code throws (as SessionStore.jsm does) or when the code returns without an exception? (Or maybe both?) * If it is supposed to be used with a normal return, is the change so GetPendingResult() is

Re: Components.returnCode not working as expected.

2014-11-24 Thread Boris Zbarsky
On 11/24/14, 4:40 AM, Philipp Kewisch wrote: Personally I'd prefer if the JS component could just throw and not have to use Components.returnCode at all, isn't there a way the caller can catch the exception without it being logged? There is. The question is _when_ it should do this. Consider

Re: Components.returnCode not working as expected.

2014-11-24 Thread Mark Hammond
On 24/11/2014 8:40 PM, Philipp Kewisch wrote: On 11/24/14 1:43 AM, Mark Hammond wrote: * Is Components.returnCode expected to be used when the code throws (as SessionStore.jsm does) or when the code returns without an exception? (Or maybe both?) * If it is supposed to be used with a normal

Components.returnCode not working as expected.

2014-11-23 Thread Mark Hammond
In bug 1100069, bz suggested I look at using Components.returnCode so a JS component called by c++ can return failure without having an exception logged. However, this isn't working as I expect. Further, the few uses of this in the tree also don't seem to work as expected. SessionStore.js