Re: Individual files should have a reviewer reference

2014-02-13 Thread Gregory Szorc
On 2/13/14, 1:23 PM, Honza Bambas wrote: An optional /* @reviewer: m...@foo.com */ comment under the license would do. If not present, find reviewer the usual way (not always hitting the right person). Reason is that despite we have peer lists, sometimes files are written/maintained by non-peer

Re: Individual files should have a reviewer reference

2014-02-13 Thread Steve Fink
On Thu 13 Feb 2014 01:42:23 PM PST, Till Schneidereit wrote: > sfink's mqext Mercurial plugin[1] adds the command `hg reviewers`, that > gives you a list of potential reviewers for the current mq tip. Is there > anything you'd want to find out about reviewers that this doesn't provide? Or you can

Re: Individual files should have a reviewer reference

2014-02-13 Thread Till Schneidereit
On Fri, Feb 14, 2014 at 10:35 AM, Nick Alexander wrote: > On 2/13/2014, 1:23 PM, Honza Bambas wrote: > >> An optional /* @reviewer: m...@foo.com */ comment under the license would >> do. If not present, find reviewer the usual way (not always hitting the >> right person). >> > > -1 from me on any

Re: Individual files should have a reviewer reference

2014-02-13 Thread Douglas Sherk
k the wrong person to review, they can just punt it to the right person without any real harm. Doug - Original Message - From: "Honza Bambas" To: dev-platform@lists.mozilla.org Sent: Thursday, February 13, 2014 4:23:07 PM Subject: Individual files should have a reviewer referen

Re: Individual files should have a reviewer reference

2014-02-13 Thread Nick Alexander
On 2/13/2014, 1:23 PM, Honza Bambas wrote: An optional /* @reviewer: m...@foo.com */ comment under the license would do. If not present, find reviewer the usual way (not always hitting the right person). -1 from me on anything that even *looks* like a file owner in the file itself. This is r

Individual files should have a reviewer reference

2014-02-13 Thread Honza Bambas
An optional /* @reviewer: m...@foo.com */ comment under the license would do. If not present, find reviewer the usual way (not always hitting the right person). Reason is that despite we have peer lists, sometimes files are written/maintained by non-peers of the module a file is in or should