Re: Intent to implement and ship: document.origin

2017-02-09 Thread Boris Zbarsky
On 2/9/17 5:44 AM, Mike West wrote: Perhaps we could deprecate `document.origin` and ship `self.origin` in Blink instead of y'all shipping `document.origin`? It seems like we want to encourage folks to use `self.origin` going forward... So specifically, should I be asking Anne to remove

Re: Intent to implement and ship: document.origin

2017-02-09 Thread Boris Zbarsky
On 2/9/17 5:44 AM, Mike West wrote: Perhaps we could deprecate `document.origin` and ship `self.origin` in Blink instead of y'all shipping `document.origin`? Given the lack of support in Edge and the incompatible support in WebKit, I can probably live with that. Especially if y'all remove it

Re: Intent to implement and ship: document.origin

2017-02-08 Thread Boris Zbarsky
I would like to revive this intent. At this point estimated release would be 54, and Blink has shipped this a while ago. The state of things here is as follows: 1) location.origin still exists and sites use it, so we can't remove it. But we can deprecate it if we want. 2)

Re: Intent to implement and ship: document.origin

2015-03-19 Thread Jonas Sicking
I think it would be weird if the invariants that hold for a and new URL() don't hold for Location. That's already the case for tons of invariants. I don't think so. The various component attributes all return what you'd expect. I still think the value added by making window.location be

Re: Intent to implement and ship: document.origin

2015-03-19 Thread Anne van Kesteren
On Wed, Mar 18, 2015 at 2:18 PM, Boris Zbarsky bzbar...@mit.edu wrote: On 3/18/15 2:39 AM, Anne van Kesteren wrote: Other than the location object tracking a URL you might not expect And not having .searchParams. That is in our implementation and still an outstanding issue in the

Re: Intent to implement and ship: document.origin

2015-03-19 Thread Boris Zbarsky
On 3/19/15 3:16 AM, Anne van Kesteren wrote: That is in our implementation Yes, because it was a security bug as specified, iirc. Of course no one else implements searchParams at all, or plans to. But as long as we're talking implementations, last I checked no one else even implemented

Re: Intent to implement and ship: document.origin

2015-03-18 Thread Boris Zbarsky
On 3/18/15 2:39 AM, Anne van Kesteren wrote: On Wed, Mar 18, 2015 at 1:09 AM, Jonas Sicking jo...@sicking.cc wrote: I think making the location object match URLUtils is futile. There's so much weirdness about the location object that I think we should treat it as the special flower that it is.

Re: Intent to implement and ship: document.origin

2015-03-18 Thread Anne van Kesteren
On Wed, Mar 18, 2015 at 1:09 AM, Jonas Sicking jo...@sicking.cc wrote: I think making the location object match URLUtils is futile. There's so much weirdness about the location object that I think we should treat it as the special flower that it is. Other than the location object tracking a

Re: Intent to implement and ship: document.origin

2015-03-17 Thread Jonas Sicking
Pinging this old thread since nothing seems to have happened since it was last discussed. My recommendation is still to make location.origin return the origin of the document rather than the origin of the URL. I would be surprised if that didn't fix many more pages than it broke. I think making

Re: Intent to implement and ship: document.origin

2014-12-03 Thread Jonas Sicking
On Dec 2, 2014 1:41 PM, Boris Zbarsky bzbar...@mit.edu wrote: On 12/2/14, 8:17 AM, Kevin Grandon wrote: We currently use location.origin quite frequently in gaia, and we also use it in workers. So the difference between location.origin and document.origin is that the latter is the origin of

Re: Intent to implement and ship: document.origin

2014-12-03 Thread Boris Zbarsky
On 12/3/14, 2:28 AM, Jonas Sicking wrote: This difference seems really esoteric to me. Do we really expect developers to understand this difference and use the right one? Especially given the very similar names? I don't. Hence my proposal to remove location.origin. Are there use cases for

Re: Intent to implement and ship: document.origin

2014-12-03 Thread Anne van Kesteren
On Wed, Dec 3, 2014 at 11:50 AM, Boris Zbarsky bzbar...@mit.edu wrote: I can't think of sane use cases for location.origin. Afaict the only reason it's on there is that all URLUtils things have a .origin... Correct. I thought that was added a long time ago. Anyway, the difference between a

Re: Intent to implement and ship: document.origin

2014-12-03 Thread Martin Thomson
On 2014-12-03, at 02:50, Boris Zbarsky bzbar...@mit.edu wrote: I can't think of sane use cases for location.origin. Afaict the only reason it's on there is that all URLUtils things have a .origin... I think that you will find that there are a few uses of location.origin already. I’m

Re: Intent to implement and ship: document.origin

2014-12-03 Thread Boris Zbarsky
On 12/3/14, 6:30 AM, Anne van Kesteren wrote: Correct. I thought that was added a long time ago. location.origin has existed in Firefox since Firefox 21, I guess (and Firefox 29 for Workers). I guess that does make it hard to remove. That sucks. :( Anyway, the difference between a

Re: Intent to implement and ship: document.origin

2014-12-03 Thread Anne van Kesteren
On Wed, Dec 3, 2014 at 7:58 AM, Boris Zbarsky bzbar...@mit.edu wrote: Indeed. Bringing us back to why would someone ever care about the latter? I don't think you should use that unless you want to know the origin of the URL of the corresponding href in question. E.g. similar to why you might

Re: Intent to implement and ship: document.origin

2014-12-02 Thread Mounir Lamouri
On Tue, 2 Dec 2014, at 02:09, Boris Zbarsky wrote: Summary: document.origin returns the Unicode serialization of the document's origin. The returned value does not depend on what document.domain was set to. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=931884 Spec:

Re: Intent to implement and ship: document.origin

2014-12-02 Thread Kevin Grandon
to implement and ship: document.origin On Tue, 2 Dec 2014, at 02:09, Boris Zbarsky wrote: Summary: document.origin returns the Unicode serialization of the document's origin. The returned value does not depend on what document.domain was set to. Bug: https://bugzilla.mozilla.org

Re: Intent to implement and ship: document.origin

2014-12-02 Thread Boris Zbarsky
On 12/2/14, 8:17 AM, Kevin Grandon wrote: We currently use location.origin quite frequently in gaia, and we also use it in workers. So the difference between location.origin and document.origin is that the latter is the origin of the document and the former is the origin of the document's

Intent to implement and ship: document.origin

2014-12-01 Thread Boris Zbarsky
Summary: document.origin returns the Unicode serialization of the document's origin. The returned value does not depend on what document.domain was set to. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=931884 Spec: http://dom.spec.whatwg.org/#dom-document-origin Platform coverage: All