Re: Intent to ship: Visual Viewport API on Android

2019-05-29 Thread Botond Ballo
Hi, > Target release: Firefox 68 or 69, depending on when the patches are > ready. If it doesn't make 68, I would like to get it into Fennec > 68.1esr, as it's an important web compat feature. Just wanted to follow up and say that this did make 68. There is one remaining Android wpt failure [1]

Re: Intent to ship: Visual Viewport API on Android

2019-05-13 Thread James Graham
On 10/05/2019 21:49, David Burns wrote: Not yet as we are stabilising tests for gecko view but hopefully soon! That won't automatically work; we'd need to start uploading Android results to wpt.fyi. Which is possible in one of two ways: * Add Geckoview on Android to the TC configuration

Re: Intent to ship: Visual Viewport API on Android

2019-05-10 Thread David Burns
Not yet as we are stabilising tests for gecko view but hopefully soon! David On May 10, 2019, 7:22 PM +0100, Botond Ballo , wrote: > On Thu, May 9, 2019 at 7:50 AM David Burns wrote: > > There are a number of wpt that fail only in firefox. Are we planning on > > fixing those tests with this

Re: Intent to ship: Visual Viewport API on Android

2019-05-10 Thread Botond Ballo
On Thu, May 9, 2019 at 7:50 AM David Burns wrote: > There are a number of wpt that fail only in firefox. Are we planning on > fixing those tests with this work? We are, at least on Android. (On desktop, some of the tests need desktop zooming, which we do not yet have, to pass.) A number of

Re: Intent to ship: Visual Viewport API on Android

2019-05-09 Thread David Burns
There are a number of wpt that fail only in firefox[1]. Are we planning on fixing those tests with this work? David [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1546387 On Thu, 9 May 2019 at 01:41, Botond Ballo wrote: > Hi everyone! > > I would like to ship the Visual Viewport API [1] on

Intent to ship: Visual Viewport API on Android

2019-05-08 Thread Botond Ballo
Hi everyone! I would like to ship the Visual Viewport API [1] on Android. The initial implementation [2] was done in Firefox 63 behind the pref "dom.visualviewport.enabled" (see "Intent to Implement" thread [3]). It has since seen bug fixes, polish, and expanded test coverage. I intend to ship