On Thursday, September 22, 2016 at 5:58:58 PM UTC+10, Paul Adenot wrote:
> On Thu, Sep 22, 2016, at 07:33 AM, Gerald Squelart wrote:
> > Sitting on the shoulders of giants, an idea, in the unlikely case it's
> > not been thought of yet:
> > How about an assertion that files a crash report (or somet
On Thu, Sep 22, 2016, at 07:33 AM, Gerald Squelart wrote:
> Sitting on the shoulders of giants, an idea, in the unlikely case it's
> not been thought of yet:
> How about an assertion that files a crash report (or something lighter
> like a telemetry blip) but does not actually crash?
I think you c
On Thursday, September 22, 2016 at 2:58:46 PM UTC+10, Daniel Holbert wrote:
> On 09/21/2016 08:41 PM, Samael Wang wrote:
> > The NS_ASSERTION document [1] says "Don't use NS_ASSERTION", which could be
> > a bit confusing that now some of the similar named macros may be deprecated
> > but some are
On 09/21/2016 08:41 PM, Samael Wang wrote:
> The NS_ASSERTION document [1] says "Don't use NS_ASSERTION", which could be a
> bit confusing that now some of the similar named macros may be deprecated but
> some are new and encouraged.
I think that document's advice is too severe.
roc made a comp
The NS_ASSERTION document [1] says "Don't use NS_ASSERTION", which could be a
bit confusing that now some of the similar named macros may be deprecated but
some are new and encouraged.
Could we possibly have a section in the coding guideline explaining all these
NS_ASSERTION / MOZ_ASSERT / NS_E
On 2016/09/22 5:56, Daniel Holbert wrote:
On 09/21/2016 12:48 PM, ISHIKAWA,chiaki wrote:
In the following URL about coding style,
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style
--- begin quote ---
if (NS_WARN_IF(somethingthatshouldbetrue)) {
return NS_ERROR_INVAL
On 09/21/2016 12:48 PM, ISHIKAWA,chiaki wrote:
> In the following URL about coding style,
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style
> --- begin quote ---
> if (NS_WARN_IF(somethingthatshouldbetrue)) {
> return NS_ERROR_INVALID_ARG;
> }
>
> if (NS_WARN_IF(NS_
On 2016/09/02 16:02, Nicholas Nethercote wrote:
Greetings,
NS_WARN_IF_FALSE has been renamed NS_WARNING_ASSERTION.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1299727 for details,
including the justification.
See https://bugzilla.mozilla.org/show_bug.cgi?id=137 for a bug
that this
Greetings,
NS_WARN_IF_FALSE has been renamed NS_WARNING_ASSERTION.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1299727 for details,
including the justification.
See https://bugzilla.mozilla.org/show_bug.cgi?id=137 for a bug
that this change exposed, thus adding weight to the
9 matches
Mail list logo
