Re: Off-main-thread Painting

2013-02-13 Thread Chris Lord
On 12 February 2013 21:57:53, Clint Talbert wrote: I agree in part with the assertion about testing - that the existing reftests will catch most regressions stemming from this. But I think we also need some measurements around scrolling/responsiveness in order to verify that off main thread

Re: Off-main-thread Painting

2013-02-12 Thread Chris Lord
On 12 February 2013 13:05:33, Jean-Marc Desperrier wrote: Matt Woodrow a écrit : to improve both performance and responsiveness of the browser, we are planning on moving painting to happen on a separate thread. I think you should take some time to consider what impact it has on the

Re: Off-main-thread Painting

2013-02-12 Thread L. David Baron
On Tuesday 2013-02-12 11:17 +, Chris Lord wrote: Sounds good, I'd like to help if I can. How would this affect the display-list optimisation process - would we transfer across the unoptimised display list and re-optimise and process for each viewport change? I assume with OMTC, we'd still

Re: Off-main-thread Painting

2013-02-12 Thread Milan Sreckovic
I think we need a stronger statement than worthwhile in this: It would be worthwhile to wait for the Layers refactoring to be completed to avoid too many conflicts. when it comes to actually landing code. Something like we should or even we must comes to mind :-) That doesn't preclude

Re: Off-main-thread Painting

2013-02-12 Thread Andreas Gal
On Feb 12, 2013, at 9:50 AM, Milan Sreckovic msrecko...@mozilla.com wrote: I think we need a stronger statement than worthwhile in this: It would be worthwhile to wait for the Layers refactoring to be completed to avoid too many conflicts. when it comes to actually landing code.

Re: Off-main-thread Painting

2013-02-12 Thread Jet Villegas
: dev-platform@lists.mozilla.org, Matt Woodrow mwood...@mozilla.com, Robert O'Callahan r...@ocallahan.org Sent: Tuesday, February 12, 2013 8:04:38 AM Subject: Re: Off-main-thread Painting On Tuesday 2013-02-12 11:17 +, Chris Lord wrote: Sounds good, I'd like to help if I can. How would

Re: Off-main-thread Painting

2013-02-12 Thread Jet Villegas
. This should be a lively discussion. --Jet - Original Message - From: Milan Sreckovic msrecko...@mozilla.com To: Matt Woodrow mwood...@mozilla.com Cc: Robert O'Callahan r...@ocallahan.org, dev-platform@lists.mozilla.org Sent: Tuesday, February 12, 2013 6:50:42 AM Subject: Re: Off-main-thread

Re: Off-main-thread Painting

2013-02-12 Thread Andreas Gal
-main-thread Painting I think we need a stronger statement than worthwhile in this: It would be worthwhile to wait for the Layers refactoring to be completed to avoid too many conflicts. when it comes to actually landing code. Something like we should or even we must comes to mind

Re: Off-main-thread Painting

2013-02-12 Thread Anthony Jones
Message - From: L. David Baron dba...@dbaron.org To: Chris Lord cl...@mozilla.com Cc: dev-platform@lists.mozilla.org, Matt Woodrow mwood...@mozilla.com, Robert O'Callahan r...@ocallahan.org Sent: Tuesday, February 12, 2013 8:04:38 AM Subject: Re: Off-main-thread Painting On Tuesday 2013-02

Re: Off-main-thread Painting

2013-02-12 Thread Robert O'Callahan
On Wed, Feb 13, 2013 at 6:17 AM, Jet Villegas j...@mozilla.com wrote: I assume we would send the same diff we use for DLBI over to the painting thread to minimize the cost. No, the plan is to ship the entire unoptimized display list over to the painting thread and do optimization and DLBI

Re: Off-main-thread Painting

2013-02-12 Thread Robert O'Callahan
On Wed, Feb 13, 2013 at 9:43 AM, Robert O'Callahan rob...@ocallahan.orgwrote: A large chunk of the work of off-main-thread painting is refactoring display lists to be independent of frames, which definitely can and should be done incrementally and could be done in parallel with the layers

Re: Off-main-thread Painting

2013-02-12 Thread Clint Talbert
I agree in part with the assertion about testing - that the existing reftests will catch most regressions stemming from this. But I think we also need some measurements around scrolling/responsiveness in order to verify that off main thread painting is giving us the wins we hope it will give

Re: Off-main-thread Painting

2013-02-12 Thread Anthony Jones
On 13/02/13 09:52, Robert O'Callahan wrote: On Wed, Feb 13, 2013 at 9:20 AM, Anthony Jones ajo...@mozilla.com mailto:ajo...@mozilla.com wrote: We need to have a cheap snapshot mechanism. We don't need that for this. The display list can be constructed on the main thread and

Re: Off-main-thread Painting

2013-02-12 Thread Robert O'Callahan
On Wed, Feb 13, 2013 at 12:28 PM, Matt Woodrow mwood...@mozilla.com wrote: This is the second half of the plan. Third paragraph of 'Proposed Solution' The basic idea is that the display list owned by the painting thread already contains all the information required to render the page at any