> It might be better to have some indicator that the analysis *did* run,
> because otherwise, you can't tell if you should wait longer for the
> result or whether your code is clean.
Originally, our bot *did* publish a comment when analysis didn't find any
defects in a patch, but this was causing
On Tue, Jul 17, 2018 at 05:06:07PM +0200, Jan Keromnes wrote:
> Thanks all for the enthusiasm, we're also excited about what this can do
> for us.
>
> > When did this become active?
>
> Last year on MozReview, yesterday on Phabricator.
>
> > Can existing diff be forced to be scanned if they
Thanks all for the enthusiasm, we're also excited about what this can do
for us.
> When did this become active?
Last year on MozReview, yesterday on Phabricator.
> Can existing diff be forced to be scanned if they weren’t before?
The easiest way to force a re-scan is to re-upload the patch
Hi
> On 17 Jul 2018, at 3:22 pm, Jan Keromnes wrote:
>
> TL;DR -- “reviewbot” is now enabled in Phabricator. It reports potential
> defects in pending patches for Firefox.
>
> Last year, we announced Code Review Bot (“reviewbot”, née “clangbot”), a
> Taskcluster bot that analyzes every patch
On Tue, Jul 17, 2018, at 9:22 AM, Jan Keromnes wrote:
> TL;DR -- “reviewbot” is now enabled in Phabricator. It reports potential
> defects in pending patches for Firefox.
Great work! This sounds super useful!
-Ted
___
dev-platform mailing list
This is amazing and looks super-useful. Really looking forward to seeing
what else we can add in this area!
-Ekr
On Tue, Jul 17, 2018 at 6:22 AM, Jan Keromnes wrote:
> TL;DR -- “reviewbot” is now enabled in Phabricator. It reports potential
> defects in pending patches for Firefox.
>
> Last
Congrats, thanks to everyone involved for getting this working!
I really like the idea of comparing errors with and without the patch,
this would let us lint code where linting isn't explicitly enabled in
mach lint/CI. One caveat to doing is that the review bot would need
to make it very clear
TL;DR -- “reviewbot” is now enabled in Phabricator. It reports potential
defects in pending patches for Firefox.
Last year, we announced Code Review Bot (“reviewbot”, née “clangbot”), a
Taskcluster bot that analyzes every patch submitted to MozReview, in order
to automatically detect and report
8 matches
Mail list logo
