Re: PSA: Major ChromeUtils.import() API change

2019-01-28 Thread Jan de Mooij
On Tue, Jan 29, 2019 at 5:51 AM Kris Maglione wrote: > To begin with, the weirdness of our JSM scopes makes a fair amount of our > system code un-JITtable, which should be enough on its own. In case people are wondering: un-JITtable applies to Ion, the optimizing JIT. The Baseline JIT is able

Re: PSA: Major ChromeUtils.import() API change

2019-01-28 Thread Kris Maglione
On Mon, Jan 28, 2019 at 04:50:28PM -0800, Kris Maglione wrote: Whatever else this whole process accomplishes, it will have the major side-effect of making our system JS code much more JIT-friendly, and in many cases, some orders of magnitude faster. Since there's been some question about my

PSA: Major ChromeUtils.import() API change

2019-01-28 Thread Kris Maglione
As of bug 1514594, the behavior ChromeUtils.import() API has changed in order to avoid touching the caller's global scope, or returning the imported module's global scope. In short, where you previously wrote: ChromeUtils.import("resource://gre/modules/Services.jsm"); You should now write